github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 10:40:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

Improve Type Check Commit Diff script (#167381)

Browse source
This commit is contained in:
Thomas Watson 2023-09-27 13:20:47 +02:00 • committed by GitHub
parent 3cec6e5ed5
commit 22fca89861
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

23
.buildkite/scripts/steps/check_types_commits.sh
View file

@ -2,7 +2,6 @@
set -euo pipefail set -euo pipefail
if [[ "${CI-}" == "true" ]]; then if [[ "${CI-}" == "true" ]]; then
.buildkite/scripts/bootstrap.sh .buildkite/scripts/bootstrap.sh
@ -106,10 +105,12 @@ done
echo "Looking for related tsconfig.json files..." echo "Looking for related tsconfig.json files..."
for dir in "${uniq_dirs[@]}" if [ ${#uniq_dirs[@]} -gt 0 ]; then
do for dir in "${uniq_dirs[@]}"
find_tsconfig $dir do
done find_tsconfig $dir
done
fi
if [ ${#uniq_tsconfigs[@]} -eq 0 ]; then if [ ${#uniq_tsconfigs[@]} -eq 0 ]; then
if [[ "$sha1" == "--cached" ]]; then if [[ "$sha1" == "--cached" ]]; then
@ -122,7 +123,17 @@ fi
echo "Running scripts/type_check for each found tsconfig.json file..." echo "Running scripts/type_check for each found tsconfig.json file..."
finalExitCode=0
for tsconfig in "${uniq_tsconfigs[@]}" for tsconfig in "${uniq_tsconfigs[@]}"
do do
set +e
node scripts/type_check --project $tsconfig node scripts/type_check --project $tsconfig
done exitCode=$?
set -e
if [ "$exitCode" -gt "$finalExitCode" ]; then
finalExitCode=$exitCode
fi
done
exit $finalExitCode