[8.8] Update ftr services to handle occasional WebDriverError (#157283) (#157326)

# Backport This will backport the following commits from `main` to `8.8`: - [Update ftr services to handle occasional WebDriverError (#157283)](https://github.com/elastic/kibana/pull/157283)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
2025-04-24 17:59:23 -04:00 · 2023-05-10 22:50:57 +02:00 · 2023-05-10 22:50:57 +02:00 · 23decee29e
commit 23decee29e
parent f18eeb0f51
4 changed files with 45 additions and 25 deletions
--- a/test/functional/apps/visualize/replaced_vislib_chart_types/_area_chart.ts
+++ b/test/functional/apps/visualize/replaced_vislib_chart_types/_area_chart.ts
@ -433,8 +433,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
        expect(isFieldErrorMessageExists).to.be(false);
      });

-      // FLAKY: https://github.com/elastic/kibana/issues/156821
-      describe.skip('interval errors', () => {
+      describe('interval errors', () => {
        before(async () => {
          // to trigger displaying of error messages
          await testSubjects.clickWhenNotDisabledWithoutRetry('visualizeEditorRenderButton');
--- a/test/functional/services/combo_box.ts
+++ b/test/functional/services/combo_box.ts
@ -117,7 +117,6 @@ export class ComboBoxService extends FtrService {
   * @param value option text
   */
  public async setCustom(comboBoxSelector: string, value: string): Promise<void> {
-    this.log.debug(`comboBox.setCustom, comboBoxSelector: ${comboBoxSelector}, value: ${value}`);
    const comboBoxElement = await this.testSubjects.find(comboBoxSelector);
    await this.setFilterValue(comboBoxElement, value);
    await this.common.pressEnterKey();
--- a/test/functional/services/common/find.ts
+++ b/test/functional/services/common/find.ts
@ -195,7 +195,7 @@ export class FindService extends FtrService {
  ): Promise<WebElementWrapper[]> {
    this.log.debug(`Find.allDescendantDisplayedByTagName('${tagName}')`);
    const allElements = await this.wrapAll(
-      await parentElement._webElement.findElements(By.tagName(tagName))
+      await parentElement._webElement.findElements(By.css(tagName))
    );
    return await this.filterElementIsDisplayed(allElements);
  }
@ -372,7 +372,7 @@ export class FindService extends FtrService {
    return await this.retry.tryForTime(timeout, async () => {
      // tslint:disable-next-line:variable-name
      const _element = element instanceof WebElementWrapper ? element._webElement : element;
-      const allButtons = this.wrapAll(await _element.findElements(By.tagName('button')));
+      const allButtons = this.wrapAll(await _element.findElements(By.css('button')));
      const buttonTexts = await Promise.all(
        allButtons.map(async (el) => {
          return el.getVisibleText();
--- a/test/functional/services/lib/web_element_wrapper/web_element_wrapper.ts
+++ b/test/functional/services/lib/web_element_wrapper/web_element_wrapper.ts
@ -25,11 +25,12 @@ interface ClearOptions {
  withJS: boolean;
 }

-const RETRY_CLICK_MAX_ATTEMPTS = 3;
-const RETRY_CLICK_RETRY_ON_ERRORS = [
+const RETRY_MAX_ATTEMPTS = 3;
+const RETRY_ON_ERRORS = [
  'ElementClickInterceptedError',
  'ElementNotInteractableError',
  'StaleElementReferenceError',
+  'WebDriverError',
 ];

 export class WebElementWrapper {
@ -105,25 +106,34 @@ export class WebElementWrapper {

  private async retryCall<T>(
    fn: (wrapper: this) => T | Promise<T>,
-    attemptsRemaining: number = RETRY_CLICK_MAX_ATTEMPTS
+    attemptsRemaining: number = RETRY_MAX_ATTEMPTS
  ): Promise<T> {
    try {
      return await fn(this);
    } catch (err) {
-      if (
-        !RETRY_CLICK_RETRY_ON_ERRORS.includes(err.name) ||
-        this.locator === null ||
-        attemptsRemaining === 0
-      ) {
+      if (!RETRY_ON_ERRORS.includes(err.name) || this.locator === null || attemptsRemaining === 0) {
        throw err;
      }

-      this.logger.warning(`WebElementWrapper.${fn.name}: ${err.message}`);
+      /*
+        https://bugs.chromium.org/p/chromedriver/issues/detail?id=4440
+        Starting with v113 driver occasionally returns WebDriverError instead of StaleElementReferenceError
+      */
+      if (err.message.includes('"code":-32000,"message":"No node with given id found"')) {
+        // WebDriverError: unknown error: unhandled inspector error: {"code":-32000,"message":"No node with given id found"}
+        this.logger.debug(`Chromedriver issue #4440, WebElementWrapper.${fn.name}: ${err}`);
+      } else {
+        this.logger.warning(`WebElementWrapper.${fn.name}: ${err}`);
+      }
+
      this.logger.debug(
-        `finding element '${this.locator.toString()}' again, ${attemptsRemaining - 1} attempts left`
+        `Searching again for the element '${this.locator?.toString()}', ${
+          attemptsRemaining - 1
+        } attempts left`
      );

      await setTimeoutAsync(200);
+      // WebElement reference id will be updated if element is no longer in DOM (StaleElementReferenceError)
      this._webElement = await this.driver.findElement(this.locator);
      return await this.retryCall(fn, attemptsRemaining - 1);
    }
@ -466,7 +476,6 @@ export class WebElementWrapper {
   * @return {Promise<WebElementWrapper>}
   */
  public async findByCssSelector(selector: string) {
-    this.logger.debug(`WebElementWrapper.findByCssSelector(${selector})`);
    return await this.retryCall(async function findByCssSelector(wrapper) {
      return wrapper._wrap(
        await wrapper._webElement.findElement(wrapper.By.css(selector)),
@ -576,8 +585,8 @@ export class WebElementWrapper {
  public async findByTagName(tagName: string): Promise<WebElementWrapper> {
    return await this.retryCall(async function findByTagName(wrapper) {
      return wrapper._wrap(
-        await wrapper._webElement.findElement(wrapper.By.tagName(tagName)),
-        wrapper.By.tagName(tagName)
+        await wrapper._webElement.findElement(wrapper.By.css(tagName)),
+        wrapper.By.css(tagName)
      );
    });
  }
@ -602,7 +611,7 @@ export class WebElementWrapper {
    return await this.retryCall(async function findAllByTagName(wrapper) {
      return wrapper._wrapAll(
        await wrapper._findWithCustomTimeout(
-          async () => await wrapper._webElement.findElements(wrapper.By.tagName(tagName)),
+          async () => await wrapper._webElement.findElements(wrapper.By.css(tagName)),
          timeout
        )
      );
@ -687,16 +696,29 @@ export class WebElementWrapper {
   * @param {string} className
   * @return {Promise<void>}
   */
-  public async waitForDeletedByCssSelector(
-    selector: string,
-    implicitTimeout = 1000
-  ): Promise<void> {
+  public async waitForDeletedByCssSelector(selector: string, implicitTimeout = 200): Promise<void> {
    try {
+      this.logger.debug(
+        `waitForDeletedByCssSelector: implicitTimeout=${implicitTimeout}, wait=${this.timeout}`
+      );
      await this.driver.manage().setTimeouts({ implicit: implicitTimeout });
      await this.driver.wait(
        async () => {
-          const found = await this._webElement.findElements(this.By.css(selector));
-          return found.length === 0;
+          if (this.locator) {
+            try {
+              const parentElement = await this.driver.findElement(this.locator);
+              const found = await parentElement.findElements(this.By.css(selector));
+              return found.length === 0;
+            } catch (err) {
+              this.logger.debug(
+                `waitForDeletedByCssSelector: parent element is no longer in DOM, wait is done`
+              );
+              return true;
+            }
+          } else {
+            const found = await this._webElement.findElements(this.By.css(selector));
+            return found.length === 0;
+          }
        },
        this.timeout,
        `The element with ${selector} selector was still present after ${this.timeout} sec.`