github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.17] [Index Management] Small copy change for index settings callout (#201264) (#201614)

Browse source 
# Backport

This will backport the following commits from `main` to `8.17`:
- [[Index Management] Small copy change for index settings callout
(#201264)](https://github.com/elastic/kibana/pull/201264)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-25T14:40:16Z","message":"[Index
Management] Small copy change for index settings callout (#201264)\n\n##
Summary\r\n\r\nA small update on the copy of the index settings callout,
based on\r\nfeedback we received from @tylerperk.\r\n\r\n<img
width=\"1516\" alt=\"Screenshot 2024-11-21 at 18 07
40\"\r\nsrc=\"https://github.com/user-attachments/assets/7e50b60c-abb8-472d-b0c2-6b98fc0d1026\">","sha":"cb63818b6faccdd9602cc1992b8bb337913fc9a7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor","v8.17.0","v8.18.0"],"title":"[Index
Management] Small copy change for index settings
callout","number":201264,"url":"https://github.com/elastic/kibana/pull/201264","mergeCommit":{"message":"[Index
Management] Small copy change for index settings callout (#201264)\n\n##
Summary\r\n\r\nA small update on the copy of the index settings callout,
based on\r\nfeedback we received from @tylerperk.\r\n\r\n<img
width=\"1516\" alt=\"Screenshot 2024-11-21 at 18 07
40\"\r\nsrc=\"https://github.com/user-attachments/assets/7e50b60c-abb8-472d-b0c2-6b98fc0d1026\">","sha":"cb63818b6faccdd9602cc1992b8bb337913fc9a7"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201264","number":201264,"mergeCommit":{"message":"[Index
Management] Small copy change for index settings callout (#201264)\n\n##
Summary\r\n\r\nA small update on the copy of the index settings callout,
based on\r\nfeedback we received from @tylerperk.\r\n\r\n<img
width=\"1516\" alt=\"Screenshot 2024-11-21 at 18 07
40\"\r\nsrc=\"https://github.com/user-attachments/assets/7e50b60c-abb8-472d-b0c2-6b98fc0d1026\">","sha":"cb63818b6faccdd9602cc1992b8bb337913fc9a7"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2024-11-26 03:30:08 +11:00 • committed by GitHub
parent a61a2bb764
commit 247ea32b2e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/index_management/__jest__/client_integration/index_template_wizard/template_create.test.tsx
View file

@ -315,7 +315,7 @@ describe('<TemplateCreate />', () => {
expect(exists('indexModeCallout')).toBe(true);
expect(find('indexModeCallout').text()).toContain(
'The index.mode setting has been set to Standard within template Logistics.'
'The index.mode setting has been set to Standard within the Logistics step.'
);
});

4
x-pack/plugins/index_management/public/application/components/shared/components/wizard_steps/step_settings.tsx
View file

@ -92,7 +92,7 @@ export const StepSettings: React.FunctionComponent<Props> = React.memo(
title={
<FormattedMessage
id="xpack.idxMgmt.formWizard.stepSettings.indexModeCallout.title"
defaultMessage="The {settingName} setting has been set to {indexMode} within template {logisticsLink}. Any changes to {settingName} set on this page will be overwritten by the Logistics selection."
defaultMessage="The {settingName} setting has been set to {indexMode} within the {logisticsLink}. Any changes to {settingName} set on this page will be overwritten by the Logistics selection."
values={{
settingName: (
<EuiCode>
@ -110,7 +110,7 @@ export const StepSettings: React.FunctionComponent<Props> = React.memo(
{i18n.translate(
'xpack.idxMgmt.formWizard.stepSettings.indexModeCallout.logisticsLinkLabel',
{
defaultMessage: 'Logistics',
defaultMessage: 'Logistics step',
}
)}
</EuiLink>

2
x-pack/test/functional/apps/index_management/index_template_wizard.ts
View file

@ -70,7 +70,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
// Verify that index mode callout is displayed
const indexModeCalloutText = await testSubjects.getVisibleText('indexModeCallout');
expect(indexModeCalloutText).to.be(
'The index.mode setting has been set to Standard within template Logistics. Any changes to index.mode set on this page will be overwritten by the Logistics selection.'
'The index.mode setting has been set to Standard within the Logistics step. Any changes to index.mode set on this page will be overwritten by the Logistics selection.'
);
// Click Next button