github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Infra UI] Fix throughput and disk availability formulas in the Asset Details Flyout (#163149)

Browse source 
closes https://github.com/elastic/kibana/issues/163144

## Summary

This PR fixes the Disk Throughput Read and Write formulas, and Disk
Usage Availability formula in the Asset Details flyout.

The flyout had another problem. the Disk IOPS was using Disk Throughput
formulas and vice-versa.

<img width="570" alt="image"
src="c1e987a1-43cf-459a-8491-51de0e3b4f3d">


<img width="570" alt="image"
src="bf2976bb-0409-46c4-ba02-002528947cff">

<img width="570" alt="image"
src="7f542b21-9992-4088-adac-05a344f066ac">




### How to test

- Start a local Kibana instance
- Navigate to `Infrastructure` > `Hosts`
- Open the flyout for a host

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Carlos Crespo 2023-08-09 11:32:37 +02:00 • committed by GitHub
parent c0c827009b
commit 253954c15f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 29 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/infra/public/common/visualizations/constants.ts
View file

@ -11,6 +11,7 @@ import {
diskIOWrite,
diskReadThroughput,
diskWriteThroughput,
diskSpaceAvailability,
diskSpaceAvailable,
diskSpaceUsage,
logRate,
@ -28,6 +29,7 @@ export const hostLensFormulas = {
diskIOWrite,
diskReadThroughput,
diskWriteThroughput,
diskSpaceAvailability,
diskSpaceAvailable,
diskSpaceUsage,
hostCount,

2
x-pack/plugins/infra/public/common/visualizations/lens/formulas/host/disk_read_throughput.ts
View file

@ -9,7 +9,7 @@ import type { FormulaConfig } from '../../../types';
export const diskReadThroughput: FormulaConfig = {
label: 'Disk Read Throughput',
value: "counter_rate(max(system.diskio.read.count), kql='system.diskio.read.count: *')",
value: "counter_rate(max(system.diskio.read.bytes), kql='system.diskio.read.bytes: *')",
format: {
id: 'bytes',
params: {

19
x-pack/plugins/infra/public/common/visualizations/lens/formulas/host/disk_space_availability.ts Normal file
View file

@ -0,0 +1,19 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import type { FormulaConfig } from '../../../types';
export const diskSpaceAvailability: FormulaConfig = {
label: 'Disk Space Availability',
value: '1 - average(system.filesystem.used.pct)',
format: {
id: 'percent',
params: {
decimals: 0,
},
},
};

2
x-pack/plugins/infra/public/common/visualizations/lens/formulas/host/disk_write_throughput.ts
View file

@ -9,7 +9,7 @@ import type { FormulaConfig } from '../../../types';
export const diskWriteThroughput: FormulaConfig = {
label: 'Disk Write Throughput',
value: "counter_rate(max(system.diskio.write.count), kql='system.diskio.write.count: *')",
value: "counter_rate(max(system.diskio.write.bytes), kql='system.diskio.write.bytes: *')",
format: {
id: 'bytes',
params: {

1
x-pack/plugins/infra/public/common/visualizations/lens/formulas/host/index.ts
View file

@ -10,6 +10,7 @@ export { diskIORead } from './disk_read_iops';
export { diskIOWrite } from './disk_write_iops';
export { diskReadThroughput } from './disk_read_throughput';
export { diskWriteThroughput } from './disk_write_throughput';
export { diskSpaceAvailability } from './disk_space_availability';
export { diskSpaceAvailable } from './disk_space_available';
export { diskSpaceUsage } from './disk_space_usage';
export { hostCount } from './host_count';

10
x-pack/plugins/infra/public/components/asset_details/tabs/overview/metrics/metrics_grid.tsx
View file

@ -126,7 +126,7 @@ const CHARTS_IN_ORDER: Array<
}),
},
{
...hostLensFormulas.diskSpaceAvailable,
...hostLensFormulas.diskSpaceAvailability,
label: i18n.translate(
'xpack.infra.assetDetails.metricsCharts.diskSpace.label.available',
{
@ -163,13 +163,13 @@ const CHARTS_IN_ORDER: Array<
{
data: [
{
...hostLensFormulas.diskReadThroughput,
...hostLensFormulas.diskIORead,
label: i18n.translate('xpack.infra.assetDetails.metricsCharts.metric.label.read', {
defaultMessage: 'Read',
}),
},
{
...hostLensFormulas.diskWriteThroughput,
...hostLensFormulas.diskIOWrite,
label: i18n.translate('xpack.infra.assetDetails.metricsCharts.metric.label.write', {
defaultMessage: 'Write',
}),
@ -195,13 +195,13 @@ const CHARTS_IN_ORDER: Array<
{
data: [
{
...hostLensFormulas.diskIORead,
...hostLensFormulas.diskReadThroughput,
label: i18n.translate('xpack.infra.assetDetails.metricsCharts.metric.label.read', {
defaultMessage: 'Read',
}),
},
{
...hostLensFormulas.diskIOWrite,
...hostLensFormulas.diskWriteThroughput,
label: i18n.translate('xpack.infra.assetDetails.metricsCharts.metric.label.write', {
defaultMessage: 'Write',
}),