github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[APM] Fix cypress flakiness related to multiple tests (#164708)

Browse source 
Relates to https://github.com/elastic/kibana/issues/162032
Attempts to fix most of the Cypress Flaky tests as almost all reported
Flaky tests have this piece in common which is the absolute time range
selection logic.

APM Cypress test running 50 times on the Flaky Test Runner -
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2990
This commit is contained in:
Achyut Jhunjhunwala 2023-08-25 17:07:30 +02:00 • committed by GitHub
parent 9058d1e83a
commit 2595709321
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 55 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/apm/ftr_e2e/cypress/e2e/service_overview/instances_table.cy.ts
View file

@ -108,7 +108,6 @@ describe('Instances table', () => {
cy.wait('@instancesDetailsRequest');
cy.getByTestSubj(`instanceDetailsButton_${serviceNodeName}`).realClick();
cy.getByTestSubj('loadingSpinner').should('be.visible');
cy.wait('@instanceDetailsRequest').then(() => {
cy.contains('Service');
});

85
x-pack/plugins/apm/ftr_e2e/cypress/e2e/service_overview/time_comparison.cy.ts
View file

@ -50,7 +50,7 @@ const apisToIntercept = [
},
];
describe.skip('Service overview: Time Comparison', () => {
describe('Service overview: Time Comparison', () => {
before(() => {
synthtrace.index(
opbeans({
@ -108,48 +108,53 @@ describe.skip('Service overview: Time Comparison', () => {
cy.getByTestSubj('comparisonSelect').should('have.value', '1w');
});
it('changes comparison type when a new time range is selected', () => {
cy.visitKibana(serviceOverviewHref);
cy.contains('opbeans-java');
// Time comparison default value
cy.getByTestSubj('comparisonSelect').should('have.value', '1d');
cy.contains('Day before');
cy.contains('Week before');
describe('changes comparison type when a new time range is selected', () => {
it('when selecting a manual time range, comparison should display the custom time range', () => {
cy.visitKibana(serviceOverviewHref);
cy.contains('opbeans-java');
// Time comparison default value
cy.getByTestSubj('comparisonSelect').should('have.value', '1d');
cy.contains('Day before');
cy.contains('Week before');
cy.selectAbsoluteTimeRange(
'2021-10-10T00:00:00.000Z',
'2021-10-20T00:00:00.000Z'
);
cy.selectAbsoluteTimeRange(
'2021-10-10T00:00:00.000Z',
'2021-10-20T00:00:00.000Z'
);
cy.getByTestSubj('querySubmitButton').click();
cy.getByTestSubj('querySubmitButton').click();
cy.getByTestSubj('comparisonSelect').should('have.value', '864000000ms');
cy.getByTestSubj('comparisonSelect').should(
'not.contain.text',
'Day before'
);
cy.getByTestSubj('comparisonSelect').should(
'not.contain.text',
'Week before'
);
cy.changeTimeRange('Today');
cy.contains('Day before');
cy.contains('Week before');
cy.changeTimeRange('Last 24 hours');
cy.getByTestSubj('comparisonSelect').should('have.value', '1d');
cy.contains('Day before');
cy.contains('Week before');
cy.changeTimeRange('Last 7 days');
cy.getByTestSubj('comparisonSelect').should('have.value', '1w');
cy.getByTestSubj('comparisonSelect').should('contain.text', 'Week before');
cy.getByTestSubj('comparisonSelect').should(
'not.contain.text',
'Day before'
);
cy.contains('Week before');
cy.getByTestSubj('comparisonSelect').should('have.value', '864000000ms');
cy.getByTestSubj('comparisonSelect').should(
'not.contain.text',
'Day before'
);
cy.getByTestSubj('comparisonSelect').should(
'not.contain.text',
'Week before'
);
});
it('when selecting Today from time range, comparison should display both day and week options', () => {
cy.visitKibana(serviceOverviewHref);
cy.changeTimeRange('Today');
cy.getByTestSubj('comparisonSelect').should('have.value', '1d');
cy.contains('Day before');
cy.contains('Week before');
});
// Skipped as the test is Flaky
xit('when selecting Last Week from time range, comparison should only display week options', () => {
cy.visitKibana(serviceOverviewHref);
cy.changeTimeRange('Last 7 days');
cy.getByTestSubj('comparisonSelect').should('have.value', '1w');
cy.getByTestSubj('comparisonSelect').should(
'contain.text',
'Week before'
);
cy.getByTestSubj('comparisonSelect').should(
'not.contain.text',
'Day before'
);
});
});
it('hovers over throughput chart shows previous and current period', () => {

1
x-pack/plugins/apm/ftr_e2e/cypress/e2e/storage_explorer/storage_explorer.cy.ts
View file

@ -187,7 +187,6 @@ describe('Storage Explorer', () => {
cy.contains('opbeans-node');
cy.getByTestSubj('storageDetailsButton_opbeans-node').click();
cy.getByTestSubj('loadingSpinner').should('be.visible');
cy.wait('@storageDetailsRequest');
cy.contains('Service storage details');

14
x-pack/plugins/apm/ftr_e2e/cypress/support/commands.ts
View file

@ -80,19 +80,25 @@ Cypress.Commands.add('visitKibana', (url: string) => {
});
});
// This command expects from and to both values to be present on the URL where
// this command is being executed. If from and to values are not present,
// the date picker renders singleValueInput where this command won't work.
Cypress.Commands.add(
'selectAbsoluteTimeRange',
(start: string, end: string) => {
const format = 'MMM D, YYYY @ HH:mm:ss.SSS';
cy.getByTestSubj('superDatePickerstartDatePopoverButton').click();
cy.getByTestSubj('superDatePickerAbsoluteDateInput')
.eq(0)
cy.contains('Start date')
.nextAll()
.find('[data-test-subj="superDatePickerAbsoluteDateInput"]')
.clear({ force: true })
.type(moment(start).format(format), { force: true });
cy.getByTestSubj('superDatePickerendDatePopoverButton').click();
cy.getByTestSubj('superDatePickerAbsoluteDateInput')
.eq(1)
cy.contains('End date')
.nextAll()
.find('[data-test-subj="superDatePickerAbsoluteDateInput"]')
.clear({ force: true })
.type(moment(end).format(format), { force: true });
}