github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

ensure time picker open in retry loop (#15034) (#15054)

Browse source 
* ensure time picker open in retry loop

* clean up isTimepickerOpen to use testSubjects.exists
This commit is contained in:
Stacey Gammon 2017-11-20 10:53:40 -05:00 • committed by GitHub
parent 82bcf81026
commit 2a4600f84a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ui/public/timepicker/timepicker.html
View file

@ -1,4 +1,4 @@
<div class="kbn-timepicker"> <div class="kbn-timepicker" data-test-subj="timePicker">
<div class="tab-content kbn-timepicker-content"> <div class="tab-content kbn-timepicker-content">
<!-- Filters --> <!-- Filters -->

17
test/functional/page_objects/header_page.js
View file

@ -54,13 +54,7 @@ export function HeaderPageProvider({ getService, getPageObjects }) {
} }
async isTimepickerOpen() { async isTimepickerOpen() {
remote.setFindTimeout(2000); return await testSubjects.exists('timePicker');
try {
await remote.findDisplayedByCssSelector('.kbn-timepicker');
return true;
} catch (error) {
return false;
}
} }
async isAbsoluteSectionShowing() { async isAbsoluteSectionShowing() {
@ -138,11 +132,14 @@ export function HeaderPageProvider({ getService, getPageObjects }) {
} }
async ensureTimePickerIsOpen() { async ensureTimePickerIsOpen() {
log.debug('ensureTimePickerIsOpen');
const isOpen = await this.isTimepickerOpen(); const isOpen = await this.isTimepickerOpen();
log.debug(`ensureTimePickerIsOpen: ${isOpen}`);
if (!isOpen) { if (!isOpen) {
log.debug('--Opening time picker'); await retry.try(async () => {
await this.clickTimepicker(); await this.clickTimepicker();
const isOpen = await this.isTimepickerOpen();
if (!isOpen) throw new Error('Time picker still not open, try again.');
});
} }
} }