github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Stack monitoring] deprecation warning for allowedSpaces setting (#120561)

Browse source 
* add deprecation warning for allowedSpaces setting

* add i18n wrapper

* add deprecation message in docs

* Update x-pack/plugins/monitoring/server/deprecations.ts

Co-authored-by: Mat Schaffer <mat@schaffer.me>

Co-authored-by: Mat Schaffer <mat@schaffer.me>
This commit is contained in:
Kevin Lacabane 2021-12-08 16:12:13 +01:00 • committed by GitHub
parent a75f472d1a
commit 2c4032df0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
docs/settings/monitoring-settings.asciidoc
View file

@ -80,7 +80,8 @@ For more information, see
| Shares the same configuration as <<elasticsearch-ssl-cert-key, `elasticsearch.ssl`>>. These settings configure encrypted communication between {kib} and the monitoring cluster.
| `monitoring.cluster_alerts.allowedSpaces` {ess-icon}
| Specifies the spaces where cluster Stack Monitoring alerts can be created. You must specify all spaces where you want to generate alerts, including the default space. Defaults to `[ "default" ]`.
| deprecated:[7.16.0,"In 8.0 and later, this setting will no longer be supported."]
Specifies the spaces where cluster Stack Monitoring alerts can be created. You must specify all spaces where you want to generate alerts, including the default space. Defaults to `[ "default" ]`.
|===

9
x-pack/plugins/monitoring/server/deprecations.ts
View file

@ -5,6 +5,7 @@
* 2.0.
*/
import { i18n } from '@kbn/i18n';
import { ConfigDeprecation, ConfigDeprecationFactory } from 'kibana/server';
/**
@ -22,6 +23,14 @@ export const deprecations = ({
}: ConfigDeprecationFactory): ConfigDeprecation[] => {
return [
deprecate('enabled', '8.0.0', { level: 'critical' }),
deprecate('cluster_alerts.allowedSpaces', '8.0.0', {
level: 'warning',
message: i18n.translate('xpack.monitoring.deprecations.allowedSpaces', {
defaultMessage:
'Starting in 7.15, the Stack Monitoring application will prompt you to create cluster alerts rather than creating them automatically in allowed spaces.' +
' This configuration is no longer used and will be removed in a future version. ',
}),
}),
// This order matters. The "blanket rename" needs to happen at the end
renameFromRoot('xpack.monitoring.max_bucket_size', 'monitoring.ui.max_bucket_size', {
level: 'warning',