github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.3] [RAM] Prevent negative snooze intervals (#134935)

Browse source 
* [8.3]  [RAM] Prevent negative snooze intervals

* Disable apply button when interval is less than 1

* Guard against bad intervals in localstorage

* Clear localstorage when unparseable

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Zacqary Adam Xeper 2022-06-28 11:01:46 -05:00 • committed by GitHub
parent 4641477488
commit 2c41ae3e5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx
View file

@ -62,11 +62,20 @@ const PREV_SNOOZE_INTERVAL_KEY = 'triggersActionsUi_previousSnoozeInterval';
export const usePreviousSnoozeInterval: (
p?: string | null
) => [string | null, (n: string) => void] = (propsInterval) => {
const intervalFromStorage = localStorage.getItem(PREV_SNOOZE_INTERVAL_KEY);
let intervalFromStorage = localStorage.getItem(PREV_SNOOZE_INTERVAL_KEY);
if (intervalFromStorage) {
try {
parseInterval(intervalFromStorage);
} catch (e) {
intervalFromStorage = null;
localStorage.removeItem(PREV_SNOOZE_INTERVAL_KEY);
}
}
const usePropsInterval = typeof propsInterval !== 'undefined';
const interval = usePropsInterval ? propsInterval : intervalFromStorage;
const [previousSnoozeInterval, setPreviousSnoozeInterval] = useState<string | null>(interval);
const storeAndSetPreviousSnoozeInterval = (newInterval: string) => {
if (newInterval.startsWith('-')) throw new Error('Cannot store a negative interval');
if (!usePropsInterval) {
localStorage.setItem(PREV_SNOOZE_INTERVAL_KEY, newInterval);
}
@ -426,6 +435,7 @@ export const SnoozePanel: React.FunctionComponent<SnoozePanelProps> = ({
<EuiFlexGroup data-test-subj="snoozePanel" gutterSize="xs">
<EuiFlexItem>
<EuiFieldNumber
min={1}
value={intervalValue}
onChange={onChangeValue}
aria-label={i18n.translate(
@ -456,6 +466,7 @@ export const SnoozePanel: React.FunctionComponent<SnoozePanelProps> = ({
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButton
disabled={!intervalValue || intervalValue < 1}
isLoading={isLoading}
onClick={onClickApplyButton}
data-test-subj="ruleSnoozeApply"