github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.7] [Guided onboarding] Fix the value of data-test-subj for telemetry (#154462) (#154530)

Browse source 
# Backport

This will backport the following commits from `main` to `8.7`:
- [[Guided onboarding] Fix the value of `data-test-subj` for telemetry
(#154462)](https://github.com/elastic/kibana/pull/154462)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yulia
Čech","email":"6585477+yuliacech@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-06T09:35:12Z","message":"[Guided
onboarding] Fix the value of `data-test-subj` for telemetry
(#154462)\n\n## Summary\r\nThis PR changes the value of `data-test-subj`
on the landing page to fix\r\nthe telemetry for guided onboarding. In
the code, this attribute is only\r\nused for testing.\r\n\r\nMore
details in
https://github.com/elastic/telemetry/issues/2155.","sha":"b2812f3278f06cac001cb5bba0c0280eaafda6bc","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Journey/Onboarding","v8.8.0","v8.7.1"],"number":154462,"url":"https://github.com/elastic/kibana/pull/154462","mergeCommit":{"message":"[Guided
onboarding] Fix the value of `data-test-subj` for telemetry
(#154462)\n\n## Summary\r\nThis PR changes the value of `data-test-subj`
on the landing page to fix\r\nthe telemetry for guided onboarding. In
the code, this attribute is only\r\nused for testing.\r\n\r\nMore
details in
https://github.com/elastic/telemetry/issues/2155.","sha":"b2812f3278f06cac001cb5bba0c0280eaafda6bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/154462","number":154462,"mergeCommit":{"message":"[Guided
onboarding] Fix the value of `data-test-subj` for telemetry
(#154462)\n\n## Summary\r\nThis PR changes the value of `data-test-subj`
on the landing page to fix\r\nthe telemetry for guided onboarding. In
the code, this attribute is only\r\nused for testing.\r\n\r\nMore
details in
https://github.com/elastic/telemetry/issues/2155.","sha":"b2812f3278f06cac001cb5bba0c0280eaafda6bc"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2023-04-11 09:08:11 -04:00 • committed by GitHub
parent b68b962a1e
commit 2cb16982cb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/home/public/application/components/guided_onboarding/__snapshots__/getting_started.test.tsx.snap generated
View file

@ -18,7 +18,7 @@ exports[`getting started should render getting started component 1`] = `
"toString": [Function],
}
}
data-test-subj="onboarding--landing-page"
data-test-subj="guided-onboarding--landing-page"
>
<EuiTitle
className="eui-textCenter"

2
src/plugins/home/public/application/components/guided_onboarding/getting_started.tsx
View file

@ -185,7 +185,7 @@ export const GettingStarted = () => {
<EuiPageTemplate.Section
alignment="center"
css={paddingCss}
data-test-subj="onboarding--landing-page"
data-test-subj="guided-onboarding--landing-page"
>
<EuiTitle size="l" className="eui-textCenter">
<h1>{title}</h1>

2
test/functional/page_objects/home_page.ts
View file

@ -57,7 +57,7 @@ export class HomePageObject extends FtrService {
}
async isGuidedOnboardingLandingDisplayed() {
return await this.testSubjects.isDisplayed('onboarding--landing-page');
return await this.testSubjects.isDisplayed('guided-onboarding--landing-page');
}
async isHomePageDisplayed() {