github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix WebElementWrapper.findByTestSubject passing css selector to the created wrapper (#121493)

Browse source 
* Fix WebElementWrapper.findByTestSubject incorrectly passing a css selector to created wrapper

* lint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Pierre Gayvallet 2021-12-20 16:09:11 +01:00 • committed by GitHub
parent eea2fc333b
commit 2ccfb084d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/functional/services/lib/web_element_wrapper/web_element_wrapper.ts
View file

@ -490,8 +490,7 @@ export class WebElementWrapper {
public async findByTestSubject(selector: string) { public async findByTestSubject(selector: string) {
return await this.retryCall(async function find(wrapper) { return await this.retryCall(async function find(wrapper) {
return wrapper._wrap( return wrapper._wrap(
await wrapper._webElement.findElement(wrapper.By.css(testSubjSelector(selector))), await wrapper._webElement.findElement(wrapper.By.css(testSubjSelector(selector)))
wrapper.By.css(selector)
); );
}); });
} }

3
test/plugin_functional/test_suites/saved_objects_management/hidden_types.ts
View file

@ -68,8 +68,7 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
}); });
}); });
// FLAKY: https://github.com/elastic/kibana/issues/116059 describe('Delete modal', () => {
describe.skip('Delete modal', () => {
it('should display a warning then trying to delete hidden saved objects', async () => { it('should display a warning then trying to delete hidden saved objects', async () => {
await PageObjects.savedObjects.clickCheckboxByTitle('A Pie'); await PageObjects.savedObjects.clickCheckboxByTitle('A Pie');
await PageObjects.savedObjects.clickCheckboxByTitle('A Dashboard'); await PageObjects.savedObjects.clickCheckboxByTitle('A Dashboard');