github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover] Fix hiding histogram for rollup data views (#137157) (#137457)

Browse source 
* [Discover] hide chart for rollup data views

* [Discover] change implementation

* [Discover] apply suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0a938d5fb0)

# Conflicts:
#	src/plugins/discover/public/application/main/components/chart/discover_chart.tsx
This commit is contained in:
Dmitry Tomashevich 2022-07-28 17:43:34 +03:00 • committed by GitHub
parent 2d751d46d8
commit 2e49594903
3 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/plugins/discover/public/application/main/components/chart/discover_chart.test.tsx
View file

@ -112,6 +112,7 @@ async function mountComponent(isTimeBased: boolean = false) {
} as unknown as GetStateReturn,
viewMode: VIEW_MODE.DOCUMENT_LEVEL,
setDiscoverViewMode: jest.fn(),
isTimeBased,
};
let instance: ReactWrapper = {} as ReactWrapper;

3
src/plugins/discover/public/application/main/components/chart/discover_chart.tsx
View file

@ -46,6 +46,7 @@ export function DiscoverChart({
setDiscoverViewMode,
hideChart,
interval,
isTimeBased,
}: {
resetSavedSearch: () => void;
savedSearch: SavedSearch;
@ -55,10 +56,10 @@ export function DiscoverChart({
indexPattern: DataView;
viewMode: VIEW_MODE;
setDiscoverViewMode: (viewMode: VIEW_MODE) => void;
isTimeBased: boolean;
hideChart?: boolean;
interval?: string;
}) {
const isTimeBased = indexPattern.isTimeBased();
const { uiSettings, data, storage } = useDiscoverServices();
const [showChartOptionsPopover, setShowChartOptionsPopover] = useState(false);
const showViewModeToggle = uiSettings.get(SHOW_FIELD_STATISTICS) ?? false;

1
src/plugins/discover/public/application/main/components/layout/discover_layout.tsx
View file

@ -348,6 +348,7 @@ export function DiscoverLayout({
setDiscoverViewMode={setDiscoverViewMode}
hideChart={state.hideChart}
interval={state.interval}
isTimeBased={isTimeBased}
/>
</EuiFlexItem>
<EuiHorizontalRule margin="none" />