github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

fix Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/sync_colors·ts (#150087)

Browse source 
Fixes https://github.com/elastic/kibana/issues/148557 and
https://github.com/elastic/kibana/issues/148558

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1854

See
https://github.com/elastic/kibana/issues/148557#issuecomment-1412415539
for explanation of failure. PR resolves flakiness by adding retry in
clickCreateNewLink, ensuring clickCreateNewLink opens lens or else
retries.
This commit is contained in:
Nathan Reese 2023-02-01 11:43:17 -07:00 • committed by GitHub
parent b8f640ca3f
commit 2f39242610
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
test/functional/services/dashboard/add_panel.ts
View file

@ -25,9 +25,14 @@ export class DashboardAddPanelService extends FtrService {
async clickCreateNewLink() {
this.log.debug('DashboardAddPanel.clickAddNewPanelButton');
await this.testSubjects.click('dashboardAddNewPanelButton');
// Give some time for the animation to complete
await this.common.sleep(500);
await this.retry.try(async () => {
await this.testSubjects.click('dashboardAddNewPanelButton');
await this.testSubjects.waitForDeleted('dashboardAddNewPanelButton');
await this.header.waitUntilLoadingHasFinished();
await this.testSubjects.existOrFail('lnsApp', {
timeout: 5000,
});
});
}
async clickQuickButton(visType: string) {

2
x-pack/test/functional/apps/dashboard/group2/sync_colors.ts
View file

@ -54,7 +54,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await elasticChart.setNewChartUiDebugFlag(true);
await PageObjects.dashboard.clickCreateDashboardPrompt();
await dashboardAddPanel.clickCreateNewLink();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.lens.goToTimeRange();
await PageObjects.lens.configureDimension({
@ -72,7 +71,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.lens.save('vis1', false, true);
await PageObjects.header.waitUntilLoadingHasFinished();
await dashboardAddPanel.clickCreateNewLink();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.lens.configureDimension({
dimension: 'lnsXY_yDimensionPanel > lns-empty-dimension',