github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

refactor 'var remote = this.remote' to setup in testSettings. Remove checking code on clickVisualize. I don't think it's needed (and not used in tests in this PR).

Browse source
This commit is contained in:
LeeDr 2015-10-28 14:01:39 -05:00 • committed by Joe Fleming
parent e40c7fa7a5
commit 2fb2e4bcbd
2 changed files with 1 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/functional/testSettings.js
View file

@ -86,7 +86,6 @@ define(function (require) {
** Test the default state of checboxes and the 2 text input fields
*/
'testSettingsInitialState': function () {
var remote = this.remote;
var testSubName = 'testSettingsInitialState';
return settingsPage
@ -135,7 +134,6 @@ define(function (require) {
*/
'testCreateButtonDisabledUntilTimeFieldSelected': function () {
var testSubName = 'testCreateButtonDisabledUntilTimeFieldSelected';
var remote = this.remote;
return settingsPage
.getCreateButton()
@ -192,7 +190,6 @@ define(function (require) {
// Index pattern field list
'testCreateRemoveIndexPattern': function () {
var remote = this.remote;
var testSubName = 'testCreateRemoveIndexPattern';
// select a time field and then Create button
@ -258,7 +255,6 @@ define(function (require) {
},
'testIndexPatternResultsHeader': function () {
var remote = this.remote;
var testSubName = 'testIndexPatternResultsHeader';
return settingsPage
@ -372,7 +368,6 @@ define(function (require) {
'testIndexPatternResultsSort': function () {
var remote = this.remote;
var testSubName = 'testIndexPatternResultsSort';
return settingsPage
@ -571,7 +566,6 @@ define(function (require) {
'testIndexPatternPopularity': function () {
var remote = this.remote;
var testSubName = 'testIndexPatternPopularity';
return settingsPage

10
test/support/pages/HeaderPage.js
View file

@ -39,15 +39,7 @@ define(function (require) {
.setFindTimeout(defaultTimeout)
.findByCssSelector('a[href*=\'visualize\']')
.then(function (tab) {
return tab.click()
.then(function checkUrl() {
return self
.getCurrentUrl()
.then(function logUrl(currentUrl) {
common.log('currentUrl = ' + currentUrl);
expect(currentUrl).to.contain('visualize');
});
});
return tab.click();
});
});
},