mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 09:48:58 -04:00
fix banner overlap in dashboard embed and fullscreen mode (#150012)
## Summary
Fix https://github.com/elastic/kibana/issues/116103,
https://github.com/elastic/kibana/issues/149112
Better version of the initial attempt
https://github.com/elastic/kibana/pull/149197
Fixes banner overlap in dashboard embed and fullscreen mode. The fix
follows `chaos`'s suggestion
https://github.com/elastic/kibana/issues/116103#issuecomment-957599532.
The bug root cause is described in
https://github.com/elastic/kibana/issues/116103#issuecomment-953252893
and
https://github.com/elastic/kibana/issues/116103#issuecomment-957369465
To reproduce and test:
Simple way to reproduce locally (no need for an iframe):
1. Add to kibana.dev.yml
```
xpack.banners:
placement: 'top'
textContent: 'P-System'
textColor: '#FFFFFF'
backgroundColor: '#FF0000'
```
2. Enable platinum license trial through Stack Management > Stack >
License Management (banners are not available in basic)
3. Fullscreen: View a dashboard and switch to fullscreen mode
4. Embed mode: Open a dashboard, copy the URL, open that URL in a new
window appending `embed=true` to the URL. e.g.:
`edf84fe0
-e1a0-11e7-b6d5-4dc382ef7f5b?embed=true&_g=()`
fixed fullscreen (no panel title overlap):

fixed embed (no controls overlap):

This commit is contained in:
parent
a7cec2200c
commit
30ed57628e
1 changed files with 2 additions and 0 deletions
|
@ -62,6 +62,8 @@
|
|||
@include kbnAffordForHeader($kbnHeaderOffset);
|
||||
|
||||
&.kbnBody--hasHeaderBanner {
|
||||
padding-top: $kbnHeaderBannerHeight;
|
||||
|
||||
@include kbnAffordForHeader($kbnHeaderOffsetWithBanner);
|
||||
|
||||
// Prevents banners from covering full screen data grids
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue