[8.16] [Security GenAI] "Select a Connector" popup does not show up after the user selects any connector and then cancels it from Endpoint Insights. (#208907) (#208969) (#208989)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security GenAI] "Select a Connector" popup does not show
up after the user selects any connector and then cancels it from
Endpoint Insights. (#208907)
(#208969)](https://github.com/elastic/kibana/pull/208969)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-30T16:53:36Z","message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:
SecuritySolution","backport:prev-major","Team:Security Generative
AI"],"title":"[Security GenAI] \"Select a Connector\" popup does not
show up after the user selects any connector and then cancels it from
Endpoint Insights.
(#208907)","number":208969,"url":"https://github.com/elastic/kibana/pull/208969","mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208969","number":208969,"mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
This commit is contained in:
Kibana Machine 2025-01-31 05:44:38 +11:00 committed by GitHub
parent 88d8fef550
commit 310514fd16
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -217,7 +217,7 @@ export const ConnectorSelector: React.FC<Props> = React.memo(
<AddConnectorModal
actionTypeRegistry={actionTypeRegistry}
actionTypes={actionTypes}
onClose={() => setIsConnectorModalVisible(false)}
onClose={cleanupAndCloseModal}
onSaveConnector={onSaveConnector}
onSelectActionType={(actionType: ActionType) => setSelectedActionType(actionType)}
selectedActionType={selectedActionType}