github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution] fix broken encoding for the expandable flyout values (#172603)

Browse source 
## Summary

This fixes an issue with url encoding in the flyout. Turns out that
`rison` does not produce url safe strings by default.
This commit is contained in:
Luke G 2023-12-06 18:31:00 +01:00 • committed by GitHub
parent ff9c299fc9
commit 3390d8c54a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

19
packages/kbn-url-state/index.test.ts
View file

@ -52,7 +52,24 @@ describe('useSyncToUrl', () => {
expect(window.history.pushState).toHaveBeenCalledWith(
{},
'',
'#should_be_there?namespace=(test:foo)'
'#should_be_there?namespace=(test%3Afoo)'
);
});
it('should escape values correctly', () => {
window.location.hash = '#should_be_there';
const { result } = renderHook(() => useUrlState('namespace', 'test'));
act(() => {
result.current[1]('foo#bar');
jest.runAllTimers();
});
expect(window.history.pushState).toHaveBeenCalledWith(
{},
'',
'#should_be_there?namespace=(test%3Afoo%23bar)'
);
});

3
packages/kbn-url-state/index.ts
View file

@ -99,9 +99,10 @@ export const useUrlState = <T = unknown>(urlNamespace: string, key: string) => {
if (!Object.prototype.hasOwnProperty.call(cache.namespaces, ns)) {
continue;
}
searchParams[ns] = encode(cache.namespaces[ns]);
searchParams[ns] = encodeURIComponent(encode(cache.namespaces[ns]));
}
// NOTE: don't re-encode the entire url params string
const newSearch = stringify(searchParams, { encode: false });
if (window.location.search === newSearch) {