github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Obs AI Assistant]fixing error - Display results and Visualize query Bedrock Error (#218213)

Browse source 
### Fix: Bedrock Streaming Error on ES|QL Actions

#### Summary

When an ES|QL is generated, we present two action buttons:
- Visualize Query
- Display Results

These actions were not working as expected when using Bedrock as the
model provider.

#### Error Details
```txt
Encountered error in Bedrock stream of type validationException messages.8: Did not find 1 `tool_result` block(s) at the beginning of this message. Messages following `tool_use` blocks must begin with a matching number of `tool_result` blocks.
```
#### Root Cause

We were sending a tool_use block in the assistant message without
immediately following it with the corresponding tool_result block. This
violates Bedrock’s message protocol.
This commit is contained in:
Arturo Lidueña 2025-04-21 10:51:18 +02:00 • committed by GitHub
parent 1fe09dcff4
commit 33993b7123
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 64 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

123
x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx
View file

@ -291,75 +291,74 @@ export function ChatBody({
}
});
const handleActionClick = ({
message,
payload,
}: {
message: Message;
payload: ChatActionClickPayload;
}) => {
setStickToBottom(true);
switch (payload.type) {
case ChatActionClickType.executeEsqlQuery:
next(
messages.concat({
'@timestamp': new Date().toISOString(),
message: {
role: MessageRole.Assistant,
content: '',
function_call: {
name: 'execute_query',
arguments: JSON.stringify({
query: payload.query,
}),
trigger: MessageRole.User,
const handleActionClick = useCallback(
({ message, payload }: { message: Message; payload: ChatActionClickPayload }) => {
setStickToBottom(true);
switch (payload.type) {
case ChatActionClickType.executeEsqlQuery:
next(
messages.concat({
'@timestamp': new Date().toISOString(),
message: {
role: MessageRole.Assistant,
content: '',
function_call: {
name: 'execute_query',
arguments: JSON.stringify({
query: payload.query,
}),
trigger: MessageRole.User,
},
},
},
})
);
break;
})
);
break;
case ChatActionClickType.updateVisualization:
const visualizeQueryResponse = message;
case ChatActionClickType.updateVisualization:
const visualizeQueryResponse = message;
const visualizeQueryResponseData = JSON.parse(visualizeQueryResponse.message.data ?? '{}');
const visualizeQueryResponseData = JSON.parse(
visualizeQueryResponse.message.data ?? '{}'
);
next(
messages.slice(0, messages.indexOf(visualizeQueryResponse)).concat({
'@timestamp': new Date().toISOString(),
message: {
name: 'visualize_query',
content: visualizeQueryResponse.message.content,
data: JSON.stringify({
...visualizeQueryResponseData,
userOverrides: payload.userOverrides,
}),
role: MessageRole.User,
},
})
);
break;
case ChatActionClickType.visualizeEsqlQuery:
next(
messages.concat({
'@timestamp': new Date().toISOString(),
message: {
role: MessageRole.Assistant,
content: '',
function_call: {
next(
messages.slice(0, messages.indexOf(visualizeQueryResponse)).concat({
'@timestamp': new Date().toISOString(),
message: {
name: 'visualize_query',
arguments: JSON.stringify({
query: payload.query,
intention: VisualizeESQLUserIntention.visualizeAuto,
content: visualizeQueryResponse.message.content,
data: JSON.stringify({
...visualizeQueryResponseData,
userOverrides: payload.userOverrides,
}),
trigger: MessageRole.User,
role: MessageRole.User,
},
},
})
);
break;
}
};
})
);
break;
case ChatActionClickType.visualizeEsqlQuery:
next(
messages.concat({
'@timestamp': new Date().toISOString(),
message: {
role: MessageRole.Assistant,
content: '',
function_call: {
name: 'visualize_query',
arguments: JSON.stringify({
query: payload.query,
intention: VisualizeESQLUserIntention.visualizeAuto,
}),
trigger: MessageRole.User,
},
},
})
);
break;
}
},
[messages, next]
);
const handleConversationAccessUpdate = async (access: ConversationAccess) => {
await updateConversationAccess(access);

10
x-pack/platform/plugins/shared/observability_ai_assistant/public/components/message_panel/message_text.tsx
View file

@ -18,7 +18,7 @@ import {
import { css } from '@emotion/css';
import classNames from 'classnames';
import type { Code, InlineCode, Parent, Text } from 'mdast';
import React, { useMemo, useRef } from 'react';
import React, { useMemo } from 'react';
import type { Node } from 'unist';
import { ChatActionClickHandler } from '../chat/types';
import { CodeBlock, EsqlCodeBlock } from './esql_code_block';
@ -120,10 +120,6 @@ export function MessageText({ loading, content, onActionClick }: Props) {
overflow-wrap: anywhere;
`;
const onActionClickRef = useRef(onActionClick);
onActionClickRef.current = onActionClick;
const { parsingPluginList, processingPluginList } = useMemo(() => {
const parsingPlugins = getDefaultEuiMarkdownParsingPlugins();
@ -149,7 +145,7 @@ export function MessageText({ loading, content, onActionClick }: Props) {
value={props.value}
lang={props.lang}
actionsDisabled={loading}
onActionClick={onActionClickRef.current}
onActionClick={onActionClick}
/>
<EuiSpacer size="m" />
</>
@ -187,7 +183,7 @@ export function MessageText({ loading, content, onActionClick }: Props) {
parsingPluginList: [loadingCursorPlugin, esqlLanguagePlugin, ...parsingPlugins],
processingPluginList: processingPlugins,
};
}, [loading]);
}, [loading, onActionClick]);
return (
<EuiText size="s" className={containerClassName}>