github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug saving actions when editing rules. (#187764)

Browse source 
## Summary

Fixes a bug that deleted rule actions when editing a rule.
This commit is contained in:
Antonio 2024-07-08 18:59:07 +02:00 • committed by GitHub
parent e6f17e7c06
commit 3437c233fd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/kbn-alerts-ui-shared/src/common/apis/update_rule/update_rule.test.ts
View file

@ -114,13 +114,9 @@ describe('updateRule', () => {
},
],
});
expect(http.put.mock.calls[0]).toMatchInlineSnapshot(`
Array [
"/api/alerting/rule/12%2F3",
Object {
"body": "{\\"name\\":\\"test\\",\\"tags\\":[\\"foo\\"],\\"schedule\\":{\\"interval\\":\\"1m\\"},\\"params\\":{},\\"actions\\":[],\\"alert_delay\\":{\\"active\\":10}}",
},
]
`);
expect(http.put).toHaveBeenCalledWith('/api/alerting/rule/12%2F3', {
body: '{"name":"test","tags":["foo"],"schedule":{"interval":"1m"},"params":{},"actions":[{"group":"default","id":"2","params":{},"frequency":{"notify_when":"onActionGroupChange","throttle":null,"summary":false},"use_alert_data_for_template":false},{"id":".test-system-action","params":{}}],"alert_delay":{"active":10}}',
});
});
});

2
packages/kbn-alerts-ui-shared/src/common/apis/update_rule/update_rule.ts
View file

@ -44,7 +44,7 @@ export async function updateRule({
const res = await http.put<AsApiContract<Rule>>(
`${BASE_ALERTING_API_PATH}/rule/${encodeURIComponent(id)}`,
{
body: JSON.stringify(transformUpdateRuleBody(pick(rule, UPDATE_FIELDS))),
body: JSON.stringify(transformUpdateRuleBody(pick(rule, UPDATE_FIELDS_WITH_ACTIONS))),
}
);
return transformRule(res);