github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover] Fix toggle table column for classic table (#128603)

Browse source 
* Fx toggle table column
* Add functional test

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
This commit is contained in:
Dmitry Tomashevich 2022-03-30 14:19:52 +05:00 • committed by GitHub
parent 4f54124b77
commit 349b6cf5d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/plugins/discover/public/application/main/components/document_explorer_callout/document_explorer_callout.tsx
View file

@ -125,6 +125,7 @@ function CalloutTitle({ onCloseCallout }: { onCloseCallout: () => void }) {
aria-label={i18n.translate('discover.docExplorerCallout.closeButtonAriaLabel', {
defaultMessage: 'Close',
})}
data-test-subj="dscExplorerCalloutClose"
onClick={onCloseCallout}
type="button"
iconType="cross"

5
src/plugins/discover/public/components/doc_table/doc_table_wrapper.tsx
View file

@ -164,12 +164,13 @@ export const DocTableWrapper = forwardRef(
indexPattern={indexPattern}
row={current}
useNewFieldsApi={useNewFieldsApi}
onAddColumn={onAddColumn}
fieldsToShow={fieldsToShow}
onAddColumn={onAddColumn}
onRemoveColumn={onRemoveColumn}
/>
));
},
[columns, onFilter, indexPattern, useNewFieldsApi, onAddColumn, fieldsToShow]
[columns, onFilter, indexPattern, useNewFieldsApi, fieldsToShow, onAddColumn, onRemoveColumn]
);
return (

24
test/functional/apps/discover/_doc_table.ts
View file

@ -189,6 +189,30 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(defaultMessageElResubmit).to.be.ok();
});
});
it('should show allow toggling columns from the expanded document', async function () {
await PageObjects.discover.clickNewSearchButton();
await testSubjects.click('dscExplorerCalloutClose');
await retry.try(async function () {
await docTable.clickRowToggle({ isAnchorRow: false, rowIndex: rowToInspect - 1 });
// add columns
const fields = ['_id', '_index', 'agent'];
for (const field of fields) {
await testSubjects.click(`toggleColumnButton-${field}`);
}
const headerWithFields = await docTable.getHeaderFields();
expect(headerWithFields.join(' ')).to.contain(fields.join(' '));
// remove columns
for (const field of fields) {
await testSubjects.click(`toggleColumnButton-${field}`);
}
const headerWithoutFields = await docTable.getHeaderFields();
expect(headerWithoutFields.join(' ')).not.to.contain(fields.join(' '));
});
});
});
describe('add and remove columns', function () {