Revert changes to use_kibana_ui_setting (#50877)

This commit is contained in:
patrykkopycinski 2019-11-18 15:52:02 +01:00 committed by GitHub
parent eb4c47ef0c
commit 34c99cb1df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -34,22 +34,22 @@ export const useKibanaUiSetting = (key: string, defaultValue?: GenericValue) =>
const core = useKibanaCore();
const uiSettingsClient = core.uiSettings;
const uiInjectedMetadata = core.injectedMetadata;
const uiSetting$ = useMemo(() => uiSettingsClient.get$(key, defaultValue), [uiSettingsClient]);
const uiSetting = useObservable(uiSetting$);
const setUiSetting = useCallback((value: GenericValue) => uiSettingsClient.set(key, value), [
uiSettingsClient,
]);
const defaultTimezoneProvider = useMemo(() => timezoneProvider(uiSettingsClient)(), [
uiSettingsClient,
]);
if (key === DEFAULT_KBN_VERSION) {
return [uiInjectedMetadata.getKibanaVersion()];
}
/* eslint-disable react-hooks/rules-of-hooks */
if (key === DEFAULT_TIMEZONE_BROWSER) {
return [defaultTimezoneProvider];
return [useMemo(() => timezoneProvider(uiSettingsClient)(), [uiSettingsClient])];
}
const uiSetting$ = useMemo(() => uiSettingsClient.get$(key, defaultValue), [uiSettingsClient]);
const uiSetting = useObservable(uiSetting$);
const setUiSetting = useCallback((value: GenericValue) => uiSettingsClient.set(key, value), [
uiSettingsClient,
]);
/* eslint-enable react-hooks/rules-of-hooks */
return [uiSetting, setUiSetting];
};