github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixing flaky disable test (#142687)

Browse source 
* Unskipping test

* Adding retries

* Cleanup

* Cleanup
This commit is contained in:
Ying Mao 2022-10-05 08:26:07 -04:00 • committed by GitHub
parent 57876a8597
commit 34deabc6bb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

39
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/disable.ts
View file

@ -26,8 +26,7 @@ export default function createDisableRuleTests({ getService }: FtrProviderContex
const retry = getService('retry');
const supertest = getService('supertest');
// Failing: See https://github.com/elastic/kibana/issues/141864
describe.skip('disable', () => {
describe('disable', () => {
const objectRemover = new ObjectRemover(supertestWithoutAuth);
const ruleUtils = new RuleUtils({ space: Spaces.space1, supertestWithoutAuth });
@ -52,15 +51,17 @@ export default function createDisableRuleTests({ getService }: FtrProviderContex
await ruleUtils.disable(createdRule.id);
// task doc should still exist but be disabled
const taskRecord = await getScheduledTask(createdRule.scheduled_task_id);
expect(taskRecord.type).to.eql('task');
expect(taskRecord.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord.task.params)).to.eql({
alertId: createdRule.id,
spaceId: Spaces.space1.id,
consumer: 'alertsFixture',
await retry.try(async () => {
const taskRecord = await getScheduledTask(createdRule.scheduled_task_id);
expect(taskRecord.type).to.eql('task');
expect(taskRecord.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord.task.params)).to.eql({
alertId: createdRule.id,
spaceId: Spaces.space1.id,
consumer: 'alertsFixture',
});
expect(taskRecord.task.enabled).to.eql(false);
});
expect(taskRecord.task.enabled).to.eql(false);
// Ensure AAD isn't broken
await checkAAD({
@ -196,15 +197,17 @@ export default function createDisableRuleTests({ getService }: FtrProviderContex
.expect(204);
// task doc should still exist but be disabled
const taskRecord = await getScheduledTask(createdRule.scheduled_task_id);
expect(taskRecord.type).to.eql('task');
expect(taskRecord.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord.task.params)).to.eql({
alertId: createdRule.id,
spaceId: Spaces.space1.id,
consumer: 'alertsFixture',
await retry.try(async () => {
const taskRecord = await getScheduledTask(createdRule.scheduled_task_id);
expect(taskRecord.type).to.eql('task');
expect(taskRecord.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord.task.params)).to.eql({
alertId: createdRule.id,
spaceId: Spaces.space1.id,
consumer: 'alertsFixture',
});
expect(taskRecord.task.enabled).to.eql(false);
});
expect(taskRecord.task.enabled).to.eql(false);
// Ensure AAD isn't broken
await checkAAD({