Cleanup advanced settings (#93437)

* Cleanup advanced settings * Fix translations/telemetry settings * Fix telemetry settings * Fix discover api docs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2025-04-23 17:28:26 -04:00 · 2021-03-17 14:44:55 +01:00 · 2021-03-17 14:44:55 +01:00 · 34f8f62d4a
commit 34f8f62d4a
parent 6479e410d7
11 changed files with 12 additions and 65 deletions
--- a/api_docs/discover.json
+++ b/api_docs/discover.json
@ -911,21 +911,6 @@
    "interfaces": [],
    "enums": [],
    "misc": [
-      {
-        "tags": [],
-        "id": "def-common.AGGS_TERMS_SIZE_SETTING",
-        "type": "string",
-        "label": "AGGS_TERMS_SIZE_SETTING",
-        "description": [],
-        "source": {
-          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 11
-        },
-        "signature": [
-          "\"discover:aggs:terms:size\""
-        ],
-        "initialIsOpen": false
-      },
      {
        "tags": [],
        "id": "def-common.CONTEXT_DEFAULT_SIZE_SETTING",
@ -934,7 +919,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 16
+          "lineNumber": 15
        },
        "signature": [
          "\"context:defaultSize\""
@ -949,7 +934,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 17
+          "lineNumber": 16
        },
        "signature": [
          "\"context:step\""
@ -964,7 +949,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 18
+          "lineNumber": 17
        },
        "signature": [
          "\"context:tieBreakerFields\""
@ -994,7 +979,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 14
+          "lineNumber": 13
        },
        "signature": [
          "\"doc_table:hideTimeColumn\""
@ -1009,7 +994,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 19
+          "lineNumber": 18
        },
        "signature": [
          "\"doc_table:legacy\""
@ -1024,7 +1009,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 15
+          "lineNumber": 14
        },
        "signature": [
          "\"fields:popularLimit\""
@ -1039,7 +1024,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 20
+          "lineNumber": 19
        },
        "signature": [
          "\"discover:modifyColumnsOnSwitch\""
@ -1069,7 +1054,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 21
+          "lineNumber": 20
        },
        "signature": [
          "\"discover:searchFieldsFromSource\""
@ -1084,7 +1069,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 13
+          "lineNumber": 12
        },
        "signature": [
          "\"discover:searchOnPageLoad\""
@ -1099,7 +1084,7 @@
        "description": [],
        "source": {
          "path": "src/plugins/discover/common/index.ts",
-          "lineNumber": 12
+          "lineNumber": 11
        },
        "signature": [
          "\"discover:sort:defaultOrder\""
--- a/docs/management/advanced-options.asciidoc
+++ b/docs/management/advanced-options.asciidoc
@ -240,10 +240,6 @@ in the current index pattern is used.
 The columns that appear by default on the *Discover* page. The default is
 `_source`.

-[[discover-aggs-terms-size]]`discover:aggs:terms:size`::
-The number terms that are visualized when clicking the *Visualize* button in the
-field drop down. The default is `20`.
-
 [[discover-samplesize]]`discover:sampleSize`::
 The number of rows to show in the *Discover* table.

--- a/src/plugins/discover/common/index.ts
+++ b/src/plugins/discover/common/index.ts
@ -8,7 +8,6 @@

 export const DEFAULT_COLUMNS_SETTING = 'defaultColumns';
 export const SAMPLE_SIZE_SETTING = 'discover:sampleSize';
-export const AGGS_TERMS_SIZE_SETTING = 'discover:aggs:terms:size';
 export const SORT_DEFAULT_ORDER_SETTING = 'discover:sort:defaultOrder';
 export const SEARCH_ON_PAGE_LOAD_SETTING = 'discover:searchOnPageLoad';
 export const DOC_HIDE_TIME_COLUMN_SETTING = 'doc_table:hideTimeColumn';
--- a/src/plugins/discover/server/ui_settings.ts
+++ b/src/plugins/discover/server/ui_settings.ts
@ -14,7 +14,6 @@ import { METRIC_TYPE } from '@kbn/analytics';
 import {
  DEFAULT_COLUMNS_SETTING,
  SAMPLE_SIZE_SETTING,
-  AGGS_TERMS_SIZE_SETTING,
  SORT_DEFAULT_ORDER_SETTING,
  SEARCH_ON_PAGE_LOAD_SETTING,
  DOC_HIDE_TIME_COLUMN_SETTING,
@ -50,20 +49,6 @@ export const uiSettings: Record<string, UiSettingsParams> = {
    category: ['discover'],
    schema: schema.number(),
  },
-  [AGGS_TERMS_SIZE_SETTING]: {
-    name: i18n.translate('discover.advancedSettings.aggsTermsSizeTitle', {
-      defaultMessage: 'Number of terms',
-    }),
-    value: 20,
-    type: 'number',
-    description: i18n.translate('discover.advancedSettings.aggsTermsSizeText', {
-      defaultMessage:
-        'Determines how many terms will be visualized when clicking the "visualize" ' +
-        'button, in the field drop downs, in the discover sidebar.',
-    }),
-    category: ['discover'],
-    schema: schema.number(),
-  },
  [SORT_DEFAULT_ORDER_SETTING]: {
    name: i18n.translate('discover.advancedSettings.sortDefaultOrderTitle', {
      defaultMessage: 'Default sort direction',
--- a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
+++ b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@ -196,10 +196,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
    type: 'long',
    _meta: { description: 'Non-default value of setting.' },
  },
-  'discover:aggs:terms:size': {
-    type: 'long',
-    _meta: { description: 'Non-default value of setting.' },
-  },
  'context:tieBreakerFields': {
    type: 'array',
    items: {
--- a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
+++ b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
@ -68,7 +68,6 @@ export interface UsageStats {
  'discover:sampleSize': number;
  defaultColumns: string[];
  'context:defaultSize': number;
-  'discover:aggs:terms:size': number;
  'context:tieBreakerFields': string[];
  'discover:sort:defaultOrder': string;
  'context:step': number;
--- a/src/plugins/telemetry/schema/oss_plugins.json
+++ b/src/plugins/telemetry/schema/oss_plugins.json
@ -7703,12 +7703,6 @@
            "description": "Non-default value of setting."
          }
        },
-        "discover:aggs:terms:size": {
-          "type": "long",
-          "_meta": {
-            "description": "Non-default value of setting."
-          }
-        },
        "context:tieBreakerFields": {
          "type": "array",
          "items": {
--- a/src/plugins/visualize/common/constants.ts
+++ b/src/plugins/visualize/common/constants.ts
@ -6,6 +6,5 @@
 * Side Public License, v 1.
 */

-export const AGGS_TERMS_SIZE_SETTING = 'discover:aggs:terms:size';
 export const STATE_STORAGE_KEY = '_a';
 export const GLOBAL_STATE_STORAGE_KEY = '_g';
--- a/x-pack/plugins/rollup/server/plugin.ts
+++ b/x-pack/plugins/rollup/server/plugin.ts
@ -113,11 +113,11 @@ export class RollupPlugin implements Plugin<void, void, any, any> {
        value: true,
        description: i18n.translate('xpack.rollupJobs.rollupIndexPatternsDescription', {
          defaultMessage: `Enable the creation of index patterns which capture rollup indices,
-              which in turn enable visualizations based on rollup data. Refresh
-              the page to apply the changes.`,
+              which in turn enable visualizations based on rollup data.`,
        }),
        category: ['rollups'],
        schema: schema.boolean(),
+        requiresPageReload: true,
      },
    });

--- a/x-pack/plugins/translations/translations/ja-JP.json
+++ b/x-pack/plugins/translations/translations/ja-JP.json
@ -1448,8 +1448,6 @@
    "devTools.devToolsTitle": "開発ツール",
    "devTools.k7BreadcrumbsDevToolsLabel": "開発ツール",
    "devTools.pageTitle": "開発ツール",
-    "discover.advancedSettings.aggsTermsSizeText": "「可視化」ボタンをクリックした際に、フィールドドロップダウンや Discover サイドバーに可視化される用語の数を設定します。",
-    "discover.advancedSettings.aggsTermsSizeTitle": "用語数",
    "discover.advancedSettings.context.defaultSizeText": "コンテキストビューに表示される周りのエントリーの数",
    "discover.advancedSettings.context.defaultSizeTitle": "コンテキストサイズ",
    "discover.advancedSettings.context.sizeStepText": "コンテキストサイズを増減させる際の最低単位です",
@ -17315,7 +17313,6 @@
    "xpack.rollupJobs.listBreadcrumbTitle": "ロールアップジョブ",
    "xpack.rollupJobs.loadAction.errorTitle": "ロールアップジョブを読み込み中にエラーが発生",
    "xpack.rollupJobs.refreshAction.errorTitle": "ロールアップジョブの更新中にエラーが発生",
-    "xpack.rollupJobs.rollupIndexPatternsDescription": "ロールアップインデックスを捕捉するインデックスパターンの作成を有効にします。\n              それによりロールアップデータに基づくビジュアライゼーションが可能になります。更新\n              変更を適用するにはページ。",
    "xpack.rollupJobs.rollupIndexPatternsTitle": "ロールアップインデックスパターンを有効にする",
    "xpack.rollupJobs.startJobsAction.errorTitle": "ロールアップジョブの開始中にエラーが発生",
    "xpack.rollupJobs.stopJobsAction.errorTitle": "ロールアップジョブの停止中にエラーが発生",
--- a/x-pack/plugins/translations/translations/zh-CN.json
+++ b/x-pack/plugins/translations/translations/zh-CN.json
@ -1456,8 +1456,6 @@
    "devTools.devToolsTitle": "开发工具",
    "devTools.k7BreadcrumbsDevToolsLabel": "开发工具",
    "devTools.pageTitle": "开发工具",
-    "discover.advancedSettings.aggsTermsSizeText": "确定在单击“可视化”按钮时将在发现侧边栏的字段下拉列表中可视化多少个词。",
-    "discover.advancedSettings.aggsTermsSizeTitle": "词数目",
    "discover.advancedSettings.context.defaultSizeText": "要在上下文视图中显示的周围条目数目",
    "discover.advancedSettings.context.defaultSizeTitle": "上下文大小",
    "discover.advancedSettings.context.sizeStepText": "递增或递减上下文大小的步进大小",
@ -17545,7 +17543,6 @@
    "xpack.rollupJobs.listBreadcrumbTitle": "汇总/打包作业",
    "xpack.rollupJobs.loadAction.errorTitle": "加载汇总/打包作业时出错",
    "xpack.rollupJobs.refreshAction.errorTitle": "刷新汇总/打包作业时出错",
-    "xpack.rollupJobs.rollupIndexPatternsDescription": "启用用于捕获汇总/打包索引的索引模式的创建，\n              汇总/打包索引反过来基于汇总/打包数据启用可视化。刷新\n              页面以应用更改。",
    "xpack.rollupJobs.rollupIndexPatternsTitle": "启用汇总索引模式",
    "xpack.rollupJobs.startJobsAction.errorTitle": "启动汇总/打包作业时出错",
    "xpack.rollupJobs.stopJobsAction.errorTitle": "停止汇总/打包作业时出错",