github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

tiny embeddable state change performance optimization (#79646)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Anton Dosov 2020-10-12 15:40:54 +02:00 • committed by GitHub
parent de6855b3ef
commit 356c0175c2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/plugins/embeddable/public/lib/panel/embeddable_panel.tsx
View file

@ -20,6 +20,7 @@ import { EuiContextMenuPanelDescriptor, EuiPanel, htmlIdGenerator } from '@elast
import classNames from 'classnames';
import React from 'react';
import { Subscription } from 'rxjs';
import deepEqual from 'fast-deep-equal';
import { buildContextMenuForActions, UiActionsService, Action } from '../ui_actions';
import { CoreStart, OverlayStart } from '../../../../../core/public';
import { toMountPoint } from '../../../../kibana_react/public';
@ -123,9 +124,11 @@ export class EmbeddablePanel extends React.Component<Props, State> {
badges = badges.filter((badge) => disabledActions.indexOf(badge.id) === -1);
}
this.setState({
badges,
});
if (!deepEqual(this.state.badges, badges)) {
this.setState({
badges,
});
}
}
private async refreshNotifications() {
@ -139,9 +142,11 @@ export class EmbeddablePanel extends React.Component<Props, State> {
notifications = notifications.filter((badge) => disabledActions.indexOf(badge.id) === -1);
}
this.setState({
notifications,
});
if (!deepEqual(this.state.notifications, notifications)) {
this.setState({
notifications,
});
}
}
public UNSAFE_componentWillMount() {