mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 09:19:04 -04:00
[Visualizations] Removes the visualize:enableLabs advanced setting (#157699)
## Summary Closes https://github.com/elastic/kibana/issues/152833 This PR: - Removes the visualize:enableLabs setting which doesn't do anything after the presentation team decided to hide the creation of the legacy input controls from the UI - Cleanups wherever the components associated with this feature were used --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Stratoula Kalafateli
GitHub
parent
fc72e7c51a
commit
363f2b5e6a
26 changed files with 70 additions and 336 deletions
|
|
@ -545,10 +545,6 @@ The maximum number of buckets a datasource can return. High numbers can have a n
|
|||
[[visualization-visualize-heatmapChartslibrary]]`visualization:visualize:legacyHeatmapChartsLibrary`::
|
||||
Disable this option if you prefer to use the new heatmap charts with improved performance, legend settings, and more..
|
||||
|
||||
[[visualize-enablelabs]]`visualize:enableLabs`::
|
||||
Enables users to create, view, and edit experimental visualizations. When disabled,
|
||||
only production-ready visualizations are available to users.
|
||||
|
||||
[float]
|
||||
[[kibana-telemetry-settings]]
|
||||
==== Usage Data
|
||||
|
|
|
|||
|
|
@ -380,3 +380,38 @@ describe('ui_settings 8.7.0 migrations', () => {
|
|||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('ui_settings 8.9.0 migrations', () => {
|
||||
const migration = migrations['8.9.0'];
|
||||
|
||||
test('returns doc on empty object', () => {
|
||||
expect(migration({} as SavedObjectUnsanitizedDoc)).toEqual({
|
||||
references: [],
|
||||
});
|
||||
});
|
||||
|
||||
test('removes "visualize:enableLabs" setting', () => {
|
||||
const doc = {
|
||||
type: 'config',
|
||||
id: '8.9.0',
|
||||
attributes: {
|
||||
buildNum: 9007199254740991,
|
||||
'visualize:enableLabs': true,
|
||||
},
|
||||
references: [],
|
||||
updated_at: '2020-06-09T20:18:20.349Z',
|
||||
migrationVersion: {},
|
||||
};
|
||||
|
||||
expect(migration(doc)).toEqual({
|
||||
type: 'config',
|
||||
id: '8.9.0',
|
||||
attributes: {
|
||||
buildNum: 9007199254740991,
|
||||
},
|
||||
references: [],
|
||||
updated_at: '2020-06-09T20:18:20.349Z',
|
||||
migrationVersion: {},
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
|
|||
|
|
@ -183,4 +183,25 @@ export const migrations = {
|
|||
}),
|
||||
references: doc.references || [],
|
||||
}),
|
||||
'8.9.0': (doc: SavedObjectUnsanitizedDoc<any>): SavedObjectSanitizedDoc<any> => ({
|
||||
...doc,
|
||||
...(doc.attributes && {
|
||||
attributes: Object.keys(doc.attributes).reduce(
|
||||
(acc, key) =>
|
||||
[
|
||||
// owner: Team:Visualizations
|
||||
'visualize:enableLabs',
|
||||
].includes(key)
|
||||
? {
|
||||
...acc,
|
||||
}
|
||||
: {
|
||||
...acc,
|
||||
[key]: doc.attributes[key],
|
||||
},
|
||||
{}
|
||||
),
|
||||
}),
|
||||
references: doc.references || [],
|
||||
}),
|
||||
};
|
||||
|
|
|
|||
|
|
@ -85,7 +85,8 @@ describe('Version Compatibility', () => {
|
|||
await expect(startServers({})).resolves.toBeUndefined();
|
||||
});
|
||||
|
||||
it('should start when ES is next minor', async () => {
|
||||
// skipping this as it fails when a migration is added
|
||||
it.skip('should start when ES is next minor', async () => {
|
||||
await expect(startServers({ customKibanaVersion: previousMinor() })).resolves.toBeUndefined();
|
||||
});
|
||||
|
||||
|
|
|
|||
|
|
@ -75,7 +75,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
|
|||
"cases-connector-mappings": "877bb4d52e9821e330622bd75fba799490ec6952",
|
||||
"cases-telemetry": "fdeddcef28c75d8c66422475a829e75d37f0b668",
|
||||
"cases-user-actions": "8ad74294b71edffa58fad7a40eea2388209477c9",
|
||||
"config": "97e16b8f5dc10c404fd3b201ef36bc6c3c63dc80",
|
||||
"config": "f553a2951fcc93ae94148691abc01f764ce29ec9",
|
||||
"config-global": "d9791e8f73edee884630e1cb6e4954ae513ce75e",
|
||||
"connector_token": "aff1aa0ebc0a6b44b570057972af25178b0bca42",
|
||||
"core-usage-stats": "b3c04da317c957741ebcdedfea4524049fdc79ff",
|
||||
|
|
|
|||
|
|
@ -46,7 +46,6 @@ interface UnwrappedEmbeddableFactory {
|
|||
export const EditorMenu = ({ createNewVisType, createNewEmbeddable }: Props) => {
|
||||
const {
|
||||
embeddable,
|
||||
settings: { uiSettings },
|
||||
visualizations: {
|
||||
getAliases: getVisTypeAliases,
|
||||
getByGroup: getVisTypesByGroup,
|
||||
|
|
@ -75,8 +74,6 @@ export const EditorMenu = ({ createNewVisType, createNewEmbeddable }: Props) =>
|
|||
});
|
||||
}, [embeddableFactories]);
|
||||
|
||||
const LABS_ENABLED = uiSettings.get('visualize:enableLabs');
|
||||
|
||||
const createNewAggsBasedVis = useCallback(
|
||||
(visType?: BaseVisType) => () =>
|
||||
showNewVisModal({
|
||||
|
|
@ -99,9 +96,7 @@ export const EditorMenu = ({ createNewVisType, createNewEmbeddable }: Props) =>
|
|||
}
|
||||
return 0;
|
||||
})
|
||||
.filter(
|
||||
({ hidden, stage }: BaseVisType) => !(hidden || (!LABS_ENABLED && stage === 'experimental'))
|
||||
);
|
||||
.filter(({ hidden, stage }: BaseVisType) => !hidden);
|
||||
|
||||
const promotedVisTypes = getSortedVisTypesByGroup(VisGroups.PROMOTED);
|
||||
const aggsBasedVisTypes = getSortedVisTypesByGroup(VisGroups.AGGBASED);
|
||||
|
|
|
|||
|
|
@ -42,11 +42,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
|
|||
type: 'keyword',
|
||||
_meta: { description: 'Default value of the setting was changed.' },
|
||||
},
|
||||
// non-sensitive
|
||||
'visualize:enableLabs': {
|
||||
type: 'boolean',
|
||||
_meta: { description: 'Non-default value of setting.' },
|
||||
},
|
||||
'visualization:heatmap:maxBuckets': {
|
||||
type: 'long',
|
||||
_meta: { description: 'Non-default value of setting.' },
|
||||
|
|
|
|||
|
|
@ -46,7 +46,6 @@ export interface UsageStats {
|
|||
'observability:apmAWSLambdaRequestCostPerMillion': number;
|
||||
'observability:enableInfrastructureHostsView': boolean;
|
||||
'observability:apmAgentExplorerView': boolean;
|
||||
'visualize:enableLabs': boolean;
|
||||
'visualization:heatmap:maxBuckets': number;
|
||||
'visualization:colorMapping': string;
|
||||
'visualization:useLegacyTimeAxis': boolean;
|
||||
|
|
|
|||
|
|
@ -8581,12 +8581,6 @@
|
|||
"description": "Default value of the setting was changed."
|
||||
}
|
||||
},
|
||||
"visualize:enableLabs": {
|
||||
"type": "boolean",
|
||||
"_meta": {
|
||||
"description": "Non-default value of setting."
|
||||
}
|
||||
},
|
||||
"visualization:heatmap:maxBuckets": {
|
||||
"type": "long",
|
||||
"_meta": {
|
||||
|
|
|
|||
|
|
@ -8,7 +8,6 @@
|
|||
|
||||
import { METRIC_TYPES, BUCKET_TYPES } from '@kbn/data-plugin/common';
|
||||
|
||||
export const VISUALIZE_ENABLE_LABS_SETTING = 'visualize:enableLabs';
|
||||
export const SAVED_OBJECTS_LIMIT_SETTING = 'savedObjects:listingLimit';
|
||||
export const SAVED_OBJECTS_PER_PAGE_SETTING = 'savedObjects:perPage';
|
||||
export const VISUALIZE_EMBEDDABLE_TYPE = 'visualization';
|
||||
|
|
|
|||
|
|
@ -16,11 +16,9 @@ import type {
|
|||
VisualizeByReferenceInput,
|
||||
VisualizeSavedObjectAttributes,
|
||||
} from './visualize_embeddable';
|
||||
import { DisabledLabEmbeddable } from './disabled_lab_embeddable';
|
||||
import { getUISettings, getHttp, getTimeFilter, getCapabilities } from '../services';
|
||||
import { getHttp, getTimeFilter, getCapabilities } from '../services';
|
||||
import { urlFor } from '../utils/saved_visualize_utils';
|
||||
import { VisualizeEmbeddableFactoryDeps } from './visualize_embeddable_factory';
|
||||
import { VISUALIZE_ENABLE_LABS_SETTING } from '../../common/constants';
|
||||
import { createVisualizeEmbeddableAsync } from './visualize_embeddable_async';
|
||||
|
||||
export const createVisEmbeddableFromObject =
|
||||
|
|
@ -34,18 +32,13 @@ export const createVisEmbeddableFromObject =
|
|||
VisualizeByReferenceInput
|
||||
>,
|
||||
parent?: IContainer
|
||||
): Promise<VisualizeEmbeddable | ErrorEmbeddable | DisabledLabEmbeddable> => {
|
||||
): Promise<VisualizeEmbeddable | ErrorEmbeddable> => {
|
||||
try {
|
||||
const visId = vis.id as string;
|
||||
|
||||
const editPath = visId ? urlFor(visId) : '#/edit_by_value';
|
||||
|
||||
const editUrl = visId ? getHttp().basePath.prepend(`/app/visualize${urlFor(visId)}`) : '';
|
||||
const isLabsEnabled = getUISettings().get<boolean>(VISUALIZE_ENABLE_LABS_SETTING);
|
||||
|
||||
if (!isLabsEnabled && vis.type.stage === 'experimental') {
|
||||
return new DisabledLabEmbeddable(vis.title, input);
|
||||
}
|
||||
|
||||
let indexPatterns: DataView[] = [];
|
||||
|
||||
|
|
|
|||
|
|
@ -1,45 +0,0 @@
|
|||
/*
|
||||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
||||
* or more contributor license agreements. Licensed under the Elastic License
|
||||
* 2.0 and the Server Side Public License, v 1; you may not use this file except
|
||||
* in compliance with, at your election, the Elastic License 2.0 or the Server
|
||||
* Side Public License, v 1.
|
||||
*/
|
||||
|
||||
import React from 'react';
|
||||
import ReactDOM from 'react-dom';
|
||||
import { KibanaThemeProvider } from '@kbn/kibana-react-plugin/public';
|
||||
import { Embeddable, EmbeddableOutput } from '@kbn/embeddable-plugin/public';
|
||||
|
||||
import { DisabledLabVisualization } from './disabled_lab_visualization';
|
||||
import { VisualizeInput } from './visualize_embeddable';
|
||||
import { VISUALIZE_EMBEDDABLE_TYPE } from './constants';
|
||||
import { getTheme } from '../services';
|
||||
|
||||
export class DisabledLabEmbeddable extends Embeddable<VisualizeInput, EmbeddableOutput> {
|
||||
private domNode?: HTMLElement;
|
||||
public readonly type = VISUALIZE_EMBEDDABLE_TYPE;
|
||||
|
||||
constructor(private readonly title: string, initialInput: VisualizeInput) {
|
||||
super(initialInput, { title });
|
||||
}
|
||||
|
||||
public reload() {}
|
||||
public render(domNode: HTMLElement) {
|
||||
if (this.title) {
|
||||
this.domNode = domNode;
|
||||
ReactDOM.render(
|
||||
<KibanaThemeProvider theme$={getTheme().theme$}>
|
||||
<DisabledLabVisualization title={this.title} />
|
||||
</KibanaThemeProvider>,
|
||||
domNode
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
public destroy() {
|
||||
if (this.domNode) {
|
||||
ReactDOM.unmountComponentAtNode(this.domNode);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
@ -1,47 +0,0 @@
|
|||
/*
|
||||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
||||
* or more contributor license agreements. Licensed under the Elastic License
|
||||
* 2.0 and the Server Side Public License, v 1; you may not use this file except
|
||||
* in compliance with, at your election, the Elastic License 2.0 or the Server
|
||||
* Side Public License, v 1.
|
||||
*/
|
||||
|
||||
import { FormattedMessage, I18nProvider } from '@kbn/i18n-react';
|
||||
import { EuiEmptyPrompt, EuiLink } from '@elastic/eui';
|
||||
import React from 'react';
|
||||
import { getDocLinks } from '../services';
|
||||
|
||||
export function DisabledLabVisualization({ title }: { title: string }) {
|
||||
const advancedSettingsLink = getDocLinks().links.management.visualizationSettings;
|
||||
return (
|
||||
<I18nProvider>
|
||||
<EuiEmptyPrompt
|
||||
titleSize="xs"
|
||||
title={
|
||||
<h6>
|
||||
<FormattedMessage
|
||||
id="visualizations.disabledLabVisualizationTitle"
|
||||
defaultMessage="{title} is a lab visualization."
|
||||
values={{ title }}
|
||||
/>
|
||||
</h6>
|
||||
}
|
||||
iconType="beaker"
|
||||
body={
|
||||
<FormattedMessage
|
||||
id="visualizations.disabledLabVisualizationMessage"
|
||||
defaultMessage="Please turn on lab-mode in the advanced settings to see lab visualizations."
|
||||
/>
|
||||
}
|
||||
actions={
|
||||
<EuiLink target="_blank" external href={advancedSettingsLink}>
|
||||
<FormattedMessage
|
||||
id="visualizations.disabledLabVisualizationLink"
|
||||
defaultMessage="Read documentation"
|
||||
/>
|
||||
</EuiLink>
|
||||
}
|
||||
/>
|
||||
</I18nProvider>
|
||||
);
|
||||
}
|
||||
|
|
@ -6,7 +6,6 @@
|
|||
* Side Public License, v 1.
|
||||
*/
|
||||
|
||||
export { DisabledLabEmbeddable } from './disabled_lab_embeddable';
|
||||
export { VisualizeEmbeddableFactory } from './visualize_embeddable_factory';
|
||||
export { VISUALIZE_EMBEDDABLE_TYPE } from './constants';
|
||||
export { VIS_EVENT_TO_TRIGGER } from './events';
|
||||
|
|
|
|||
|
|
@ -28,7 +28,6 @@ import {
|
|||
} from '@kbn/embeddable-plugin/public';
|
||||
import type { StartServicesGetter } from '@kbn/kibana-utils-plugin/public';
|
||||
import { checkForDuplicateTitle } from '../utils/saved_objects_utils/check_for_duplicate_title';
|
||||
import type { DisabledLabEmbeddable } from './disabled_lab_embeddable';
|
||||
import type {
|
||||
VisualizeByReferenceInput,
|
||||
VisualizeByValueInput,
|
||||
|
|
@ -40,7 +39,7 @@ import type {
|
|||
import { VISUALIZE_EMBEDDABLE_TYPE } from './constants';
|
||||
import type { SerializedVis, Vis } from '../vis';
|
||||
import { createVisAsync } from '../vis_async';
|
||||
import { getCapabilities, getTypes, getUISettings } from '../services';
|
||||
import { getCapabilities, getTypes } from '../services';
|
||||
import { showNewVisModal } from '../wizard';
|
||||
import {
|
||||
convertToSerializedVis,
|
||||
|
|
@ -55,7 +54,6 @@ import {
|
|||
injectControlsReferences,
|
||||
} from '../utils/saved_visualization_references';
|
||||
import { createVisEmbeddableFromObject } from './create_vis_embeddable_from_object';
|
||||
import { VISUALIZE_ENABLE_LABS_SETTING } from '../../common/constants';
|
||||
import type { VisualizationsStartDeps } from '../plugin';
|
||||
|
||||
interface VisualizationAttributes extends SavedObjectAttributes {
|
||||
|
|
@ -76,7 +74,7 @@ export class VisualizeEmbeddableFactory
|
|||
EmbeddableFactoryDefinition<
|
||||
VisualizeInput,
|
||||
VisualizeOutput | EmbeddableOutput,
|
||||
VisualizeEmbeddable | DisabledLabEmbeddable,
|
||||
VisualizeEmbeddable,
|
||||
VisualizationAttributes
|
||||
>
|
||||
{
|
||||
|
|
@ -106,13 +104,7 @@ export class VisualizeEmbeddableFactory
|
|||
try {
|
||||
const typeName: string = JSON.parse(savedObject.attributes.visState).type;
|
||||
const visType = getTypes().get(typeName);
|
||||
if (!visType) {
|
||||
return false;
|
||||
}
|
||||
if (getUISettings().get(VISUALIZE_ENABLE_LABS_SETTING)) {
|
||||
return true;
|
||||
}
|
||||
return visType.stage !== 'experimental';
|
||||
return Boolean(visType);
|
||||
} catch {
|
||||
return false;
|
||||
}
|
||||
|
|
@ -158,7 +150,7 @@ export class VisualizeEmbeddableFactory
|
|||
savedObjectId: string,
|
||||
input: Partial<VisualizeInput> & { id: string },
|
||||
parent?: IContainer
|
||||
): Promise<VisualizeEmbeddable | ErrorEmbeddable | DisabledLabEmbeddable> {
|
||||
): Promise<VisualizeEmbeddable | ErrorEmbeddable> {
|
||||
const startDeps = await this.deps.start();
|
||||
|
||||
try {
|
||||
|
|
|
|||
|
|
@ -46,7 +46,6 @@ export type {
|
|||
VisualizationStage,
|
||||
} from './vis_types/vis_type_alias_registry';
|
||||
export {
|
||||
VISUALIZE_ENABLE_LABS_SETTING,
|
||||
SAVED_OBJECTS_LIMIT_SETTING,
|
||||
SAVED_OBJECTS_PER_PAGE_SETTING,
|
||||
LegendSize,
|
||||
|
|
|
|||
|
|
@ -27,11 +27,7 @@ import { updateBasicSoAttributes } from '../../utils/saved_objects_utils/update_
|
|||
import { checkForDuplicateTitle } from '../../utils/saved_objects_utils/check_for_duplicate_title';
|
||||
import { showNewVisModal } from '../../wizard';
|
||||
import { getTypes } from '../../services';
|
||||
import {
|
||||
VISUALIZE_ENABLE_LABS_SETTING,
|
||||
SAVED_OBJECTS_LIMIT_SETTING,
|
||||
SAVED_OBJECTS_PER_PAGE_SETTING,
|
||||
} from '../..';
|
||||
import { SAVED_OBJECTS_LIMIT_SETTING, SAVED_OBJECTS_PER_PAGE_SETTING } from '../..';
|
||||
import type { VisualizationListItem } from '../..';
|
||||
import type { VisualizeServices } from '../types';
|
||||
import { VisualizeConstants } from '../../../common/constants';
|
||||
|
|
@ -164,7 +160,6 @@ export const VisualizeListing = () => {
|
|||
referencesToExclude?: SavedObjectReference[];
|
||||
} = {}
|
||||
) => {
|
||||
const isLabsEnabled = uiSettings.get(VISUALIZE_ENABLE_LABS_SETTING);
|
||||
return findListItems(
|
||||
getTypes(),
|
||||
searchTerm,
|
||||
|
|
@ -172,9 +167,7 @@ export const VisualizeListing = () => {
|
|||
references,
|
||||
referencesToExclude
|
||||
).then(({ total, hits }: { total: number; hits: Array<Record<string, unknown>> }) => {
|
||||
const content = hits
|
||||
.filter((result: any) => isLabsEnabled || result.type?.stage !== 'experimental')
|
||||
.map(toTableListViewSavedObject);
|
||||
const content = hits.map(toTableListViewSavedObject);
|
||||
|
||||
visualizedUserContent.current = content;
|
||||
|
||||
|
|
@ -184,7 +177,7 @@ export const VisualizeListing = () => {
|
|||
};
|
||||
});
|
||||
},
|
||||
[listingLimit, uiSettings]
|
||||
[listingLimit]
|
||||
);
|
||||
|
||||
const onContentEditorSave = useCallback(
|
||||
|
|
|
|||
|
|
@ -19,7 +19,6 @@ import { SearchSelection } from './search_selection';
|
|||
import { GroupSelection } from './group_selection';
|
||||
import { AggBasedSelection } from './agg_based_selection';
|
||||
import type { TypesStart, BaseVisType, VisTypeAlias } from '../vis_types';
|
||||
import { VISUALIZE_ENABLE_LABS_SETTING } from '../../common/constants';
|
||||
import './dialog.scss';
|
||||
|
||||
interface TypeSelectionProps {
|
||||
|
|
@ -56,14 +55,12 @@ class NewVisModal extends React.Component<TypeSelectionProps, TypeSelectionState
|
|||
editorParams: [],
|
||||
};
|
||||
|
||||
private readonly isLabsEnabled: boolean;
|
||||
private readonly trackUiMetric:
|
||||
| ((type: UiCounterMetricType, eventNames: string | string[], count?: number) => void)
|
||||
| undefined;
|
||||
|
||||
constructor(props: TypeSelectionProps) {
|
||||
super(props);
|
||||
this.isLabsEnabled = props.uiSettings.get(VISUALIZE_ENABLE_LABS_SETTING);
|
||||
|
||||
this.state = {
|
||||
showSearchVisModal: Boolean(this.props.selectedVisType),
|
||||
|
|
@ -106,7 +103,7 @@ class NewVisModal extends React.Component<TypeSelectionProps, TypeSelectionState
|
|||
aria-label={visNewVisDialogAriaLabel}
|
||||
>
|
||||
<WizardComponent
|
||||
showExperimental={this.isLabsEnabled}
|
||||
showExperimental={true}
|
||||
onVisTypeSelected={this.onVisTypeSelected}
|
||||
visTypesRegistry={this.props.visTypesRegistry}
|
||||
docLinks={this.props.docLinks}
|
||||
|
|
|
|||
|
|
@ -9,8 +9,6 @@
|
|||
import { PluginInitializerContext } from '@kbn/core/server';
|
||||
import { VisualizationsPlugin } from './plugin';
|
||||
|
||||
export { VISUALIZE_ENABLE_LABS_SETTING } from '../common/constants';
|
||||
|
||||
// This exports static code and TypeScript types,
|
||||
// as well as, Kibana Platform `plugin()` initializer.
|
||||
|
||||
|
|
|
|||
|
|
@ -6,9 +6,6 @@
|
|||
* Side Public License, v 1.
|
||||
*/
|
||||
|
||||
import { i18n } from '@kbn/i18n';
|
||||
import { schema } from '@kbn/config-schema';
|
||||
|
||||
import { PluginSetup as DataPluginSetup } from '@kbn/data-plugin/server';
|
||||
import type {
|
||||
PluginInitializerContext,
|
||||
|
|
@ -19,7 +16,6 @@ import type {
|
|||
} from '@kbn/core/server';
|
||||
import type { EmbeddableSetup } from '@kbn/embeddable-plugin/server';
|
||||
import { ContentManagementServerSetup } from '@kbn/content-management-plugin/server';
|
||||
import { VISUALIZE_ENABLE_LABS_SETTING } from '../common/constants';
|
||||
import { capabilitiesProvider } from './capabilities_provider';
|
||||
import { VisualizationsStorage } from './content_management';
|
||||
|
||||
|
|
@ -53,20 +49,6 @@ export class VisualizationsPlugin
|
|||
core.savedObjects.registerType(getVisualizationSavedObjectType(getSearchSourceMigrations));
|
||||
core.capabilities.registerProvider(capabilitiesProvider);
|
||||
|
||||
core.uiSettings.register({
|
||||
[VISUALIZE_ENABLE_LABS_SETTING]: {
|
||||
name: i18n.translate('visualizations.advancedSettings.visualizeEnableLabsTitle', {
|
||||
defaultMessage: 'Enable technical preview visualizations',
|
||||
}),
|
||||
value: true,
|
||||
description: i18n.translate('visualizations.advancedSettings.visualizeEnableLabsText', {
|
||||
defaultMessage: `When enabled, allows you to create, view, and edit visualizations that are in technical preview. When disabled, only production-ready visualizations are available.`,
|
||||
}),
|
||||
category: ['visualization'],
|
||||
schema: schema.boolean(),
|
||||
},
|
||||
});
|
||||
|
||||
plugins.embeddable.registerEmbeddableFactory(
|
||||
makeVisualizeEmbeddableFactory(getSearchSourceMigrations)()
|
||||
);
|
||||
|
|
|
|||
|
|
@ -9,7 +9,6 @@
|
|||
import expect from '@kbn/expect';
|
||||
|
||||
import { VisualizeConstants } from '@kbn/visualizations-plugin/common/constants';
|
||||
import { VISUALIZE_ENABLE_LABS_SETTING } from '@kbn/visualizations-plugin/common/constants';
|
||||
import { FtrProviderContext } from '../../../ftr_provider_context';
|
||||
|
||||
export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
||||
|
|
@ -18,9 +17,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
const browser = getService('browser');
|
||||
const kibanaServer = getService('kibanaServer');
|
||||
const dashboardAddPanel = getService('dashboardAddPanel');
|
||||
const testSubjects = getService('testSubjects');
|
||||
const dashboardVisualizations = getService('dashboardVisualizations');
|
||||
const dashboardExpect = getService('dashboardExpect');
|
||||
|
||||
describe('create and add embeddables', () => {
|
||||
before(async () => {
|
||||
|
|
@ -132,95 +128,5 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
await PageObjects.header.clickDashboard();
|
||||
});
|
||||
});
|
||||
|
||||
describe('visualize:enableLabs advanced setting', () => {
|
||||
const LAB_VIS_NAME = 'Rendering Test: input control';
|
||||
|
||||
let experimentalTypes: string[] = [];
|
||||
|
||||
before(async () => {
|
||||
// get the data-test-subj values for all experimental visualizations for later tests
|
||||
await PageObjects.visualize.gotoVisualizationLandingPage();
|
||||
await PageObjects.visualize.clickNewVisualization();
|
||||
const experimentalTypeWrappers = await PageObjects.visualize.getExperimentalTypeLinks();
|
||||
experimentalTypes = await Promise.all(
|
||||
experimentalTypeWrappers.map((element) => element.getAttribute('data-test-subj'))
|
||||
);
|
||||
});
|
||||
|
||||
it('should display lab visualizations in add panel', async () => {
|
||||
await PageObjects.common.navigateToApp('dashboard');
|
||||
await PageObjects.dashboard.clickNewDashboard();
|
||||
const exists = await dashboardAddPanel.panelAddLinkExists(LAB_VIS_NAME);
|
||||
await dashboardAddPanel.closeAddPanel();
|
||||
expect(exists).to.be(true);
|
||||
});
|
||||
|
||||
it('should display lab visualizations in editor menu', async () => {
|
||||
await dashboardAddPanel.clickEditorMenuButton();
|
||||
for (const dataTestSubj of experimentalTypes) {
|
||||
await testSubjects.existOrFail(dataTestSubj);
|
||||
}
|
||||
});
|
||||
|
||||
describe('is false', () => {
|
||||
before(async () => {
|
||||
await PageObjects.header.clickStackManagement();
|
||||
await PageObjects.settings.clickKibanaSettings();
|
||||
await PageObjects.settings.toggleAdvancedSettingCheckbox(VISUALIZE_ENABLE_LABS_SETTING);
|
||||
});
|
||||
|
||||
it('should not display lab visualizations in add panel', async () => {
|
||||
await PageObjects.common.navigateToApp('dashboard');
|
||||
await PageObjects.dashboard.clickNewDashboard();
|
||||
|
||||
const exists = await dashboardAddPanel.panelAddLinkExists(LAB_VIS_NAME);
|
||||
await dashboardAddPanel.closeAddPanel();
|
||||
expect(exists).to.be(false);
|
||||
});
|
||||
|
||||
it('should not display lab visualizations in editor menu', async () => {
|
||||
await dashboardAddPanel.clickEditorMenuButton();
|
||||
for (const dataTestSubj of experimentalTypes) {
|
||||
expect(await testSubjects.exists(dataTestSubj)).to.be(false);
|
||||
}
|
||||
});
|
||||
|
||||
after(async () => {
|
||||
await PageObjects.header.clickStackManagement();
|
||||
await PageObjects.settings.clickKibanaSettings();
|
||||
await PageObjects.settings.clearAdvancedSettings(VISUALIZE_ENABLE_LABS_SETTING);
|
||||
await PageObjects.header.clickDashboard();
|
||||
});
|
||||
});
|
||||
|
||||
describe('adds metric and markdown by value to a new dashboard', () => {
|
||||
before(async () => {
|
||||
await PageObjects.common.navigateToApp('dashboard');
|
||||
await PageObjects.dashboard.preserveCrossAppState();
|
||||
await PageObjects.dashboard.clickNewDashboard();
|
||||
});
|
||||
|
||||
it('adding a metric visualization', async function () {
|
||||
const originalPanelCount = await PageObjects.dashboard.getPanelCount();
|
||||
expect(originalPanelCount).to.eql(0);
|
||||
await dashboardVisualizations.createAndEmbedMetric('Embedding Vis Test');
|
||||
await dashboardExpect.metricValuesExist(['0']);
|
||||
const panelCount = await PageObjects.dashboard.getPanelCount();
|
||||
expect(panelCount).to.eql(1);
|
||||
});
|
||||
it('adding a markdown', async function () {
|
||||
const originalPanelCount = await PageObjects.dashboard.getPanelCount();
|
||||
expect(originalPanelCount).to.eql(1);
|
||||
await dashboardVisualizations.createAndEmbedMarkdown({
|
||||
name: 'Embedding Markdown Test',
|
||||
markdown: 'Nice to meet you, markdown is my name',
|
||||
});
|
||||
await dashboardExpect.markdownWithValuesExists(['Nice to meet you, markdown is my name']);
|
||||
const panelCount = await PageObjects.dashboard.getPanelCount();
|
||||
expect(panelCount).to.eql(2);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,52 +0,0 @@
|
|||
/*
|
||||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
||||
* or more contributor license agreements. Licensed under the Elastic License
|
||||
* 2.0 and the Server Side Public License, v 1; you may not use this file except
|
||||
* in compliance with, at your election, the Elastic License 2.0 or the Server
|
||||
* Side Public License, v 1.
|
||||
*/
|
||||
|
||||
import expect from '@kbn/expect';
|
||||
import { VISUALIZE_ENABLE_LABS_SETTING } from '@kbn/visualizations-plugin/common/constants';
|
||||
|
||||
import { FtrProviderContext } from '../../../ftr_provider_context';
|
||||
|
||||
export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
||||
const log = getService('log');
|
||||
const PageObjects = getPageObjects(['common', 'header', 'discover', 'settings', 'visualize']);
|
||||
|
||||
describe('visualize lab mode', () => {
|
||||
before(async () => {
|
||||
await PageObjects.visualize.initTests();
|
||||
});
|
||||
it('disabling does not break loading saved searches', async () => {
|
||||
await PageObjects.common.navigateToUrl('discover', '', { useActualUrl: true });
|
||||
await PageObjects.discover.saveSearch('visualize_lab_mode_test');
|
||||
await PageObjects.discover.openLoadSavedSearchPanel();
|
||||
const hasSaved = await PageObjects.discover.hasSavedSearch('visualize_lab_mode_test');
|
||||
expect(hasSaved).to.be(true);
|
||||
await PageObjects.discover.closeLoadSaveSearchPanel();
|
||||
|
||||
log.info('found saved search before toggling enableLabs mode');
|
||||
|
||||
// Navigate to advanced setting and disable lab mode
|
||||
await PageObjects.header.clickStackManagement();
|
||||
await PageObjects.settings.clickKibanaSettings();
|
||||
await PageObjects.settings.toggleAdvancedSettingCheckbox(VISUALIZE_ENABLE_LABS_SETTING);
|
||||
|
||||
// Expect the discover still to list that saved visualization in the open list
|
||||
await PageObjects.header.clickDiscover();
|
||||
await PageObjects.discover.openLoadSavedSearchPanel();
|
||||
const stillHasSaved = await PageObjects.discover.hasSavedSearch('visualize_lab_mode_test');
|
||||
expect(stillHasSaved).to.be(true);
|
||||
log.info('found saved search after toggling enableLabs mode');
|
||||
});
|
||||
|
||||
after(async () => {
|
||||
await PageObjects.discover.closeLoadSaveSearchPanel();
|
||||
await PageObjects.header.clickStackManagement();
|
||||
await PageObjects.settings.clickKibanaSettings();
|
||||
await PageObjects.settings.clearAdvancedSettings(VISUALIZE_ENABLE_LABS_SETTING);
|
||||
});
|
||||
});
|
||||
}
|
||||
|
|
@ -26,7 +26,6 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
|
|||
});
|
||||
|
||||
loadTestFile(require.resolve('./_shared_item'));
|
||||
loadTestFile(require.resolve('./_lab_mode'));
|
||||
loadTestFile(require.resolve('./_linked_saved_searches'));
|
||||
loadTestFile(require.resolve('./_visualize_listing'));
|
||||
loadTestFile(require.resolve('./_add_to_dashboard.ts'));
|
||||
|
|
|
|||
|
|
@ -6970,7 +6970,6 @@
|
|||
"visualizations.confirmModal.overwriteConfirmationMessage": "Voulez-vous vraiment écraser {title} ?",
|
||||
"visualizations.confirmModal.overwriteTitle": "Écraser {name} ?",
|
||||
"visualizations.confirmModal.saveDuplicateConfirmationMessage": "L'enregistrement de \"{name}\" crée un doublon de titre. Voulez-vous tout de même enregistrer ?",
|
||||
"visualizations.disabledLabVisualizationTitle": "{title} est une visualisation lab.",
|
||||
"visualizations.embeddable.legacyURLConflict.errorMessage": "Cette visualisation a la même URL qu'un alias hérité. Désactiver l'alias pour résoudre cette erreur : {json}",
|
||||
"visualizations.experimentalVisInfoText": "Elle pourra être modifiée ou supprimée totalement dans une prochaine version. Elastic s'efforcera au maximum de corriger tout problème, mais les fonctionnalités en version d'évaluation technique ne sont pas soumises aux accords de niveau de service d'assistance des fonctionnalités officielles en disponibilité générale. Pour apporter des commentaires, veuillez créer une entrée dans {githubLink}.",
|
||||
"visualizations.fallbackDataView.label": "{type} introuvable",
|
||||
|
|
@ -6990,8 +6989,6 @@
|
|||
"visualizations.visualizeListingDashboardFlowDescription": "Vous créez un tableau de bord ? Créez et ajoutez vos visualisations directement depuis {dashboardApp}.",
|
||||
"visualizations.visualizeListingDeleteErrorTitle.duplicateWarning": "L'enregistrement de \"{value}\" crée un doublon de titre.",
|
||||
"visualizations.actions.editInLens.displayName": "Convertir pour une utilisation dans Lens",
|
||||
"visualizations.advancedSettings.visualizeEnableLabsText": "Si l'option est activée, elle vous permet de créer, d'afficher et de modifier des visualisations qui sont en version d'évaluation technique. Si elle est désactivée, seules les visualisations prêtes pour la production sont disponibles.",
|
||||
"visualizations.advancedSettings.visualizeEnableLabsTitle": "Activer les visualisations de la version d'évaluation technique",
|
||||
"visualizations.badge.readOnly.text": "Lecture seule",
|
||||
"visualizations.badge.readOnly.tooltip": "Impossible d'enregistrer les visualisations dans la bibliothèque",
|
||||
"visualizations.confirmModal.cancelButtonLabel": "Annuler",
|
||||
|
|
@ -7006,8 +7003,6 @@
|
|||
"visualizations.createVisualization.noVisTypeErrorMessage": "Vous devez fournir un type de visualisation valide",
|
||||
"visualizations.dataView.label": "Vue de données",
|
||||
"visualizations.deprecatedTag": "Déclassé",
|
||||
"visualizations.disabledLabVisualizationLink": "Lire la documentation",
|
||||
"visualizations.disabledLabVisualizationMessage": "Veuillez activer le mode lab dans les paramètres avancés pour consulter les visualisations lab.",
|
||||
"visualizations.displayName": "visualisation",
|
||||
"visualizations.editor.createBreadcrumb": "Créer",
|
||||
"visualizations.editor.defaultEditBreadcrumbText": "Modifier la visualisation",
|
||||
|
|
|
|||
|
|
@ -6971,7 +6971,6 @@
|
|||
"visualizations.confirmModal.overwriteConfirmationMessage": "{title}を上書きしてよろしいですか？",
|
||||
"visualizations.confirmModal.overwriteTitle": "{name}を上書きしますか？",
|
||||
"visualizations.confirmModal.saveDuplicateConfirmationMessage": "「{name}」を保存すると、タイトルが重複します。保存しますか？",
|
||||
"visualizations.disabledLabVisualizationTitle": "{title}はラボビジュアライゼーションです。",
|
||||
"visualizations.embeddable.legacyURLConflict.errorMessage": "このビジュアライゼーションにはレガシーエイリアスと同じURLがあります。このエラーを解決するには、エイリアスを無効にしてください：{json}",
|
||||
"visualizations.experimentalVisInfoText": "将来のリリースでは、変更されるか、完全に削除される場合があります。Elasticは最善の努力を講じてすべての問題の修正に努めますが、テクニカルプレビュー中の機能には正式なGA機能のサポートSLAが適用されません。フィードバックがある場合は、{githubLink}で問題を報告してください。",
|
||||
"visualizations.fallbackDataView.label": "{type}が見つかりません",
|
||||
|
|
@ -6991,8 +6990,6 @@
|
|||
"visualizations.visualizeListingDashboardFlowDescription": "ダッシュボードを作成しますか？{dashboardApp}から直接ビジュアライゼーションを作成して追加します。",
|
||||
"visualizations.visualizeListingDeleteErrorTitle.duplicateWarning": "「{value}」を保存すると、タイトルが重複します。",
|
||||
"visualizations.actions.editInLens.displayName": "Lensに変換",
|
||||
"visualizations.advancedSettings.visualizeEnableLabsText": "有効にすると、ユーザーは、テクニカルプレビュー中のビジュアライゼーションを作成、表示、編集できます。無効にすると、本番対応のビジュアライゼーションのみを使用できます。",
|
||||
"visualizations.advancedSettings.visualizeEnableLabsTitle": "テクニカルプレビュー中のビジュアライゼーションを有効にする",
|
||||
"visualizations.badge.readOnly.text": "読み取り専用",
|
||||
"visualizations.badge.readOnly.tooltip": "ビジュアライゼーションをライブラリに保存できません",
|
||||
"visualizations.confirmModal.cancelButtonLabel": "キャンセル",
|
||||
|
|
@ -7007,8 +7004,6 @@
|
|||
"visualizations.createVisualization.noVisTypeErrorMessage": "有効なビジュアライゼーションタイプを指定してください",
|
||||
"visualizations.dataView.label": "データビュー",
|
||||
"visualizations.deprecatedTag": "非推奨",
|
||||
"visualizations.disabledLabVisualizationLink": "ドキュメンテーションを表示",
|
||||
"visualizations.disabledLabVisualizationMessage": "ラボビジュアライゼーションを表示するには、高度な設定でラボモードをオンにしてください。",
|
||||
"visualizations.displayName": "ビジュアライゼーション",
|
||||
"visualizations.editor.createBreadcrumb": "作成",
|
||||
"visualizations.editor.defaultEditBreadcrumbText": "ビジュアライゼーションを編集",
|
||||
|
|
|
|||
|
|
@ -6970,7 +6970,6 @@
|
|||
"visualizations.confirmModal.overwriteConfirmationMessage": "确定要覆盖“{title}”？",
|
||||
"visualizations.confirmModal.overwriteTitle": "覆盖 {name}？",
|
||||
"visualizations.confirmModal.saveDuplicateConfirmationMessage": "保存“{name}”会创建重复的标题。是否确定要保存？",
|
||||
"visualizations.disabledLabVisualizationTitle": "{title} 为实验室可视化。",
|
||||
"visualizations.embeddable.legacyURLConflict.errorMessage": "此可视化具有与旧版别名相同的 URL。请禁用别名以解决此错误：{json}",
|
||||
"visualizations.experimentalVisInfoText": "在未来版本中可能会更改或完全移除。Elastic 将尽最大努力来修复任何问题，但处于技术预览状态的功能不受正式 GA 功能支持 SLA 的约束。如欲提供反馈，请在 {githubLink} 中创建问题。",
|
||||
"visualizations.fallbackDataView.label": "找不到 {type}",
|
||||
|
|
@ -6990,8 +6989,6 @@
|
|||
"visualizations.visualizeListingDashboardFlowDescription": "构建仪表板？从 {dashboardApp} 创建和添加您的可视化。",
|
||||
"visualizations.visualizeListingDeleteErrorTitle.duplicateWarning": "保存“{value}”会创建重复的标题。",
|
||||
"visualizations.actions.editInLens.displayName": "进行转换以便在 Lens 中使用",
|
||||
"visualizations.advancedSettings.visualizeEnableLabsText": "如果启用，将允许您创建、查看和编辑处于技术预览状态的可视化。如果禁用，仅生产就绪可视化可供使用。",
|
||||
"visualizations.advancedSettings.visualizeEnableLabsTitle": "启用技术预览可视化",
|
||||
"visualizations.badge.readOnly.text": "只读",
|
||||
"visualizations.badge.readOnly.tooltip": "无法将可视化保存到库",
|
||||
"visualizations.confirmModal.cancelButtonLabel": "取消",
|
||||
|
|
@ -7006,8 +7003,6 @@
|
|||
"visualizations.createVisualization.noVisTypeErrorMessage": "必须提供有效的可视化类型",
|
||||
"visualizations.dataView.label": "数据视图",
|
||||
"visualizations.deprecatedTag": "（已过时）",
|
||||
"visualizations.disabledLabVisualizationLink": "阅读文档",
|
||||
"visualizations.disabledLabVisualizationMessage": "请在高级设置中打开实验模式，以查看实验性可视化。",
|
||||
"visualizations.displayName": "可视化",
|
||||
"visualizations.editor.createBreadcrumb": "创建",
|
||||
"visualizations.editor.defaultEditBreadcrumbText": "编辑可视化",
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue