github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[9.0] [Uptime] Fix skipped a11y tests (#214396) (#214621)

Browse source 
# Backport

This will backport the following commits from `main` to `9.0`:
- [[Uptime] Fix skipped a11y tests
(#214396)](https://github.com/elastic/kibana/pull/214396)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Justin
Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2025-03-14T17:01:45Z","message":"[Uptime]
Fix skipped a11y tests (#214396)\n\n## Summary\n\nResolves
#204152.\n\nAttempt to fix the mislabeled element by adding the `figure`
role to
it.","sha":"631a840db44a26553acca83182ab0071e9db3abb","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["skipped-test","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","Team:obs-ux-management","v9.1.0"],"title":"[Uptime]
Fix skipped a11y
tests","number":214396,"url":"https://github.com/elastic/kibana/pull/214396","mergeCommit":{"message":"[Uptime]
Fix skipped a11y tests (#214396)\n\n## Summary\n\nResolves
#204152.\n\nAttempt to fix the mislabeled element by adding the `figure`
role to
it.","sha":"631a840db44a26553acca83182ab0071e9db3abb"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214396","number":214396,"mergeCommit":{"message":"[Uptime]
Fix skipped a11y tests (#214396)\n\n## Summary\n\nResolves
#204152.\n\nAttempt to fix the mislabeled element by adding the `figure`
role to it.","sha":"631a840db44a26553acca83182ab0071e9db3abb"}}]}]
BACKPORT-->

Co-authored-by: Justin Kambic <jk@elastic.co>
This commit is contained in:
Kibana Machine 2025-03-15 05:46:12 +11:00 • committed by GitHub
parent 60ec42a349
commit 36986a89e7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 13 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/charts/__snapshots__/chart_wrapper.test.tsx.snap generated
View file

@ -2,7 +2,7 @@
exports[`ChartWrapper component renders the component with loading false 1`] = `
<EuiErrorBoundary>
<div
<figure
intl={
Object {
"$t": [Function],
@ -133,13 +133,13 @@ exports[`ChartWrapper component renders the component with loading false 1`] = `
height={144}
up={4}
/>
</div>
</figure>
</EuiErrorBoundary>
`;
exports[`ChartWrapper component renders the component with loading true 1`] = `
<EuiErrorBoundary>
<div
<figure
intl={
Object {
"$t": [Function],
@ -270,7 +270,7 @@ exports[`ChartWrapper component renders the component with loading true 1`] = `
height={144}
up={4}
/>
</div>
</figure>
<EuiFlexGroup
alignItems="center"
justifyContent="spaceAround"

4
x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/charts/chart_wrapper/chart_wrapper.tsx
View file

@ -33,7 +33,7 @@ export const ChartWrapper: FC<PropsWithChildren<Props>> = ({
return (
<EuiErrorBoundary>
<div
<figure
style={{
height,
opacity,
@ -42,7 +42,7 @@ export const ChartWrapper: FC<PropsWithChildren<Props>> = ({
{...(rest as HTMLAttributes<HTMLDivElement>)}
>
{children}
</div>
</figure>
{loading === true && (
<EuiFlexGroup
justifyContent="spaceAround"

8
x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/charts/duration_charts.test.tsx
View file

@ -48,7 +48,7 @@ describe('MonitorCharts component', () => {
};
it('renders the component without errors', () => {
const { getByLabelText } = render(
const { getByRole } = render(
<DurationChartComponent
loading={false}
anomalies={null}
@ -72,7 +72,11 @@ describe('MonitorCharts component', () => {
},
}
);
expect(getByLabelText(`A chart displaying the monitor's ping duration, grouped by location.`));
const figureElement = getByRole('figure');
expect(figureElement).toHaveAttribute(
'aria-label',
"A chart displaying the monitor's ping duration, grouped by location."
);
});
it('renders an empty state when no monitor data is present', () => {

3
x-pack/test/accessibility/apps/group1/uptime.ts
View file

@ -19,8 +19,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const es = getService('es');
const toasts = getService('toasts');
// Failing: See https://github.com/elastic/kibana/issues/210245
describe.skip('uptime Accessibility', () => {
describe('uptime Accessibility', () => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/uptime/blank');
await makeChecks(es, A11Y_TEST_MONITOR_ID, 150, 1, 1000, {