mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 01:38:56 -04:00
[ML] AIOps Hiding saved query controls (#210556)
The AIOps pages in ML make use of the shared query bar component, but do not support saved queries. By having the load and save query options in the menu, it can give the impression that these options are generally available but for some reason cannot be used. This PR adds a new optional flag which allows the load and save options to be hidden from the menu. The flag defaults to always showing the options. Fixes https://github.com/elastic/kibana/issues/209152 **Before**  **After** 
This commit is contained in:
parent
9cad58719b
commit
36c764ebf7
6 changed files with 15 additions and 1 deletions
|
@ -75,6 +75,7 @@ export interface QueryBarMenuProps extends WithCloseFilterEditorConfirmModalProp
|
|||
showQueryInput?: boolean;
|
||||
showFilterBar?: boolean;
|
||||
showSaveQuery?: boolean;
|
||||
showSavedQueryControls?: boolean;
|
||||
timeRangeForSuggestionsOverride?: boolean;
|
||||
filtersForSuggestions?: Filter[];
|
||||
indexPatterns?: Array<DataView | string>;
|
||||
|
@ -110,6 +111,7 @@ function QueryBarMenuComponent({
|
|||
showQueryInput,
|
||||
showFilterBar,
|
||||
showSaveQuery,
|
||||
showSavedQueryControls,
|
||||
indexPatterns,
|
||||
timeRangeForSuggestionsOverride,
|
||||
filtersForSuggestions,
|
||||
|
@ -176,6 +178,7 @@ function QueryBarMenuComponent({
|
|||
timeFilter,
|
||||
query,
|
||||
showSaveQuery,
|
||||
showSavedQueryControls,
|
||||
showFilterBar,
|
||||
showQueryInput,
|
||||
savedQueryService,
|
||||
|
|
|
@ -171,6 +171,7 @@ export interface QueryBarMenuPanelsProps {
|
|||
timeFilter?: SavedQueryTimeFilter;
|
||||
query?: Query;
|
||||
showSaveQuery?: boolean;
|
||||
showSavedQueryControls?: boolean;
|
||||
showQueryInput?: boolean;
|
||||
showFilterBar?: boolean;
|
||||
savedQueryService: SavedQueryService;
|
||||
|
@ -199,6 +200,7 @@ export function useQueryBarMenuPanels({
|
|||
timeFilter,
|
||||
query,
|
||||
showSaveQuery,
|
||||
showSavedQueryControls = true,
|
||||
showFilterBar,
|
||||
showQueryInput,
|
||||
savedQueryService,
|
||||
|
@ -220,7 +222,10 @@ export function useQueryBarMenuPanels({
|
|||
const { appName, usageCollection, uiSettings, http, storage, application } = kibana.services;
|
||||
const reportUiCounter = usageCollection?.reportUiCounter.bind(usageCollection, appName);
|
||||
const showSavedQueries =
|
||||
showQueryInput && showFilterBar && application.capabilities.savedQueryManagement?.showQueries;
|
||||
showSavedQueryControls &&
|
||||
showQueryInput &&
|
||||
showFilterBar &&
|
||||
application.capabilities.savedQueryManagement?.showQueries;
|
||||
const cancelPendingListingRequest = useRef<() => void>(() => {});
|
||||
|
||||
const [hasSavedQueries, setHasSavedQueries] = useState(false);
|
||||
|
|
|
@ -87,6 +87,8 @@ export interface SearchBarOwnProps<QT extends AggregateQuery | Query = Query> {
|
|||
query?: QT | Query;
|
||||
// Show when user has privileges to save. See `canShowSavedQuery(...)` lib.
|
||||
showSaveQuery?: boolean;
|
||||
// Show the controls to save and load saved queries
|
||||
showSavedQueryControls?: boolean;
|
||||
savedQuery?: SavedQuery;
|
||||
onQueryChange?: (payload: { dateRange: TimeRange; query?: QT | Query }) => void;
|
||||
onQuerySubmit?: (
|
||||
|
@ -556,6 +558,7 @@ class SearchBarUI<QT extends (Query | AggregateQuery) | Query = Query> extends C
|
|||
showQueryInput={this.props.showQueryInput}
|
||||
showFilterBar={this.props.showFilterBar}
|
||||
showSaveQuery={this.props.showSaveQuery}
|
||||
showSavedQueryControls={this.props.showSavedQueryControls}
|
||||
isDisabled={this.props.isDisabled}
|
||||
buttonProps={{ size: this.shouldShowDatePickerAsBadge() ? 's' : 'm' }}
|
||||
indexPatterns={this.props.indexPatterns}
|
||||
|
|
|
@ -117,6 +117,7 @@ export const SearchPanelContent = ({
|
|||
showFilterBar={true}
|
||||
showDatePicker={false}
|
||||
showQueryInput={true}
|
||||
showSavedQueryControls={false}
|
||||
query={searchInput}
|
||||
onQuerySubmit={(params: { dateRange: TimeRange; query?: Query | undefined }) =>
|
||||
searchHandler({ query: params.query })
|
||||
|
|
|
@ -80,6 +80,7 @@ export const SearchBarWrapper: FC<SearchBarProps> = ({
|
|||
showDatePicker={false}
|
||||
showQueryInput
|
||||
query={resultQuery}
|
||||
showSavedQueryControls={false}
|
||||
filters={filters ?? []}
|
||||
onQuerySubmit={onQuerySubmit}
|
||||
indexPatterns={[dataView]}
|
||||
|
|
|
@ -98,6 +98,7 @@ export const SearchPanel: FC<Props> = ({ searchString, searchQueryLanguage, setS
|
|||
showFilterBar={true}
|
||||
showDatePicker={false}
|
||||
showQueryInput={true}
|
||||
showSavedQueryControls={false}
|
||||
query={searchInput}
|
||||
onQuerySubmit={(params: { dateRange: TimeRange; query?: Query | undefined }) =>
|
||||
searchHandler({ query: params.query })
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue