github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Adding the data- prefix to the shared-item HTMLElements (#10888)

Browse source
This commit is contained in:
Brandon Kobel 2017-04-05 08:03:46 -04:00 • committed by GitHub
parent c09b69e432
commit 36f676cc2d
12 changed files with 21 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/functional/apps/dashboard/_dashboard.js
View file

@ -104,16 +104,16 @@ bdd.it('retains dark theme in state', async function () {
expect(isDarkThemeOn).to.equal(true);
});
bdd.it('should have shared-items-count set to the number of visualizations', function checkSavedItemsCount() {
bdd.it('should have data-shared-items-count set to the number of visualizations', function checkSavedItemsCount() {
const visualizations = PageObjects.dashboard.getTestVisualizations();
return PageObjects.common.tryForTime(10000, () => PageObjects.dashboard.getSharedItemsCount())
.then(function (count) {
PageObjects.common.log('shared-items-count = ' + count);
PageObjects.common.log('data-shared-items-count = ' + count);
expect(count).to.eql(visualizations.length);
});
});
bdd.it('should have panels with expected shared-item title and description', function checkTitles() {
bdd.it('should have panels with expected data-shared-item title and description', function checkTitles() {
const visualizations = PageObjects.dashboard.getTestVisualizations();
return PageObjects.common.tryForTime(10000, function () {
return PageObjects.dashboard.getPanelSharedItemData()

4
test/functional/apps/discover/_discover.js
View file

@ -226,8 +226,8 @@ bdd.describe('discover app', function describeIndexTests() {
});
bdd.describe('shared-item', function () {
bdd.it('should have correct shared-item title and description', async () => {
bdd.describe('data-shared-item', function () {
bdd.it('should have correct data-shared-item title and description', async () => {
const expected = {
title: 'A Saved Search',
description: 'A Saved Search Description'

4
test/functional/apps/visualize/_shared_item.js
View file

@ -13,9 +13,9 @@ bdd.describe('visualize app', function describeIndexTests() {
return PageObjects.common.navigateToApp('visualize');
});
bdd.describe('shared-item', function indexPatternCreation() {
bdd.describe('data-shared-item', function indexPatternCreation() {
bdd.it('should have the correct shared-item title and description', function () {
bdd.it('should have the correct data-shared-item title and description', function () {
const expected = {
title: 'Shared-Item Visualization AreaChart',
description: 'AreaChart'