github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Serverless] Unskip search navigation test (#170224)

Browse source 
## Summary

fix https://github.com/elastic/kibana/issues/166597
This commit is contained in:
Anton Dosov 2023-10-31 17:29:04 +01:00 • committed by GitHub
parent 40e524bd09
commit 376c50cdae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
packages/shared-ux/chrome/navigation/src/ui/components/navigation_item.tsx
View file

@ -9,6 +9,7 @@
import React, { Fragment, useEffect, useMemo } from 'react';
import type { AppDeepLinkId, ChromeProjectNavigationNode } from '@kbn/core-chrome-browser';
import { EuiCollapsibleNavItem } from '@elastic/eui';
import classNames from 'classnames';
import { useNavigation as useNavigationServices } from '../../services';
import { useInitNavNode } from '../hooks';
@ -74,6 +75,10 @@ function NavigationItemComp<
if (isRootLevel) {
const href = getNavigationNodeHref(navNode);
const dataTestSubj = classNames(`nav-item`, {
[`nav-item-deepLinkId-${navNode.deepLink?.id}`]: !!navNode.deepLink,
[`nav-item-isActive`]: navNode.isActive,
});
return (
<EuiCollapsibleNavItem
@ -82,7 +87,7 @@ function NavigationItemComp<
icon={navNode.icon}
iconProps={{ size: 'm' }}
isSelected={navNode.isActive}
data-test-subj={`nav-item-${navNode.id}`}
data-test-subj={dataTestSubj}
linkProps={{
href,
onClick: (e: React.MouseEvent) => {

17
x-pack/test_serverless/functional/test_suites/search/navigation.ts
View file

@ -16,8 +16,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const browser = getService('browser');
// FLAKY: https://github.com/elastic/kibana/issues/166597
describe.skip('navigation', function () {
describe('navigation', function () {
before(async () => {
await svlCommonPage.login();
await svlSearchNavigation.navigateToLandingPage();
@ -65,7 +64,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
await svlCommonNavigation.sidenav.expectLinkActive({
deepLinkId: 'serverlessElasticsearch',
});
await svlCommonNavigation.breadcrumbs.expectBreadcrumbExists({ text: `Getting started` });
await svlCommonNavigation.breadcrumbs.expectBreadcrumbExists({ text: `Get started` });
await testSubjects.existOrFail(`svlSearchOverviewPage`);
await expectNoPageReload();
@ -73,16 +72,20 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
it("management apps from the sidenav hide the 'stack management' root from the breadcrumbs", async () => {
await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'management:triggersActions' });
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Alerts', 'Rules']);
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Explore', 'Alerts', 'Rules']);
await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'management:index_management' });
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Index Management', 'Indices']);
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts([
'Content',
'Index Management',
'Indices',
]);
await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'management:ingest_pipelines' });
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Ingest Pipelines']);
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Content', 'Ingest Pipelines']);
await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'management:api_keys' });
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['API keys']);
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Security', 'API keys']);
});
it('navigate management', async () => {