fix(slo): sli value summary calculation (#164598)

This commit is contained in:
Kevin Delemme 2023-08-24 08:09:58 -04:00 committed by GitHub
parent 65573fc93e
commit 37efbf350d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 15 additions and 15 deletions

View file

@ -58,7 +58,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {
@ -286,7 +286,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {
@ -514,7 +514,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {
@ -757,7 +757,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {
@ -1013,7 +1013,7 @@ Array [
"goodEvents": "goodEvents",
"totalEvents": "totalEvents",
},
"script": "if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }",
"script": "if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }",
},
},
"statusCode": Object {

View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_30D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_7D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_90D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_MONTHLY_ALIGNED: TransformPutTransformRequest =
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -88,7 +88,7 @@ export const SUMMARY_OCCURRENCES_WEEKLY_ALIGNED: TransformPutTransformRequest =
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -88,7 +88,7 @@ export const SUMMARY_TIMESLICES_30D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -88,7 +88,7 @@ export const SUMMARY_TIMESLICES_7D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -88,7 +88,7 @@ export const SUMMARY_TIMESLICES_90D_ROLLING: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -116,7 +116,7 @@ export const SUMMARY_TIMESLICES_MONTHLY_ALIGNED: TransformPutTransformRequest =
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {

View file

@ -101,7 +101,7 @@ export const SUMMARY_TIMESLICES_WEEKLY_ALIGNED: TransformPutTransformRequest = {
totalEvents: 'totalEvents',
},
script:
'if (params.totalEvents == 0) { return -1 } else { return params.goodEvents / params.totalEvents }',
'if (params.totalEvents == 0) { return -1 } else if (params.goodEvents >= params.totalEvents) { return 1 } else { return params.goodEvents / params.totalEvents }',
},
},
errorBudgetInitial: {