github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Graph] Unskip a11y functional test (#141798)

Browse source
This commit is contained in:
Matthias Wilhelm 2022-09-29 12:43:47 +02:00 • committed by GitHub
parent 94fe1e6353
commit 384ecc4b7b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
x-pack/plugins/graph/public/components/settings/url_template_form.tsx
View file

@ -261,7 +261,15 @@ export function UrlTemplateForm(props: UrlTemplateFormProps) {
defaultMessage: 'Toolbar icon',
})}
>
<div role="listbox">
<div
role="listbox"
aria-label={i18n.translate(
'xpack.graph.settings.drillDowns.toolbarIconPickerSelectionAriaLabel',
{
defaultMessage: 'Toolbar icon selection',
}
)}
>
{urlTemplateIconChoices.map((icon) => (
<LegacyIcon
aria-label={icon.label}

3
x-pack/plugins/graph/public/components/workspace_layout/workspace_top_nav_menu.tsx
View file

@ -178,6 +178,9 @@ export const WorkspaceTopNavMenu = (props: WorkspaceTopNavMenuProps) => {
ownFocus: true,
className: 'gphSettingsFlyout',
maxWidth: 520,
'aria-label': i18n.translate('xpack.graph.settings.ariaLabel', {
defaultMessage: 'Settings',
}),
}
);
},

7
x-pack/test/accessibility/apps/graph.ts
View file

@ -79,12 +79,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await browser.pressKeys(browser.keys.ESCAPE);
});
// https://github.com/elastic/kibana/issues/134693
it.skip('Graph settings drilldown tab - add new drilldown', async function () {
it('Graph settings drilldown tab - add new drilldown', async function () {
await testSubjects.click('graphSettingsButton');
await testSubjects.click('drillDowns');
await testSubjects.click('graphAddNewTemplate');
await a11y.testAppSnapshot();
await testSubjects.click('graphRemoveUrlTemplate');
await testSubjects.click('euiFlyoutCloseButton');
await browser.pressKeys(browser.keys.ESCAPE);
});