github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[SpyPanel] reduced scope of new parameter on visualize, added a default if no option is passed in for show-spy-panel Removed conditional on from discover

Browse source
This commit is contained in:
Khalah Jones-Golden 2015-10-30 14:51:20 -04:00 • committed by Court Ewing
parent bec0201905
commit 3979f0f76c
5 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/kibana/public/dashboard/components/panel/panel.html
View file

@ -28,7 +28,7 @@
<visualize ng-switch-when="visualization"
vis="savedObj.vis"
search-source="savedObj.searchSource"
chrome="chrome"
show-spy-panel="chrome.getVisible()"
class="panel-content">
</visualize>

2
src/plugins/kibana/public/discover/index.html
View file

@ -176,7 +176,7 @@
</header>
<visualize ng-if="vis && rows.length != 0" chrome="chrome" vis="vis" es-resp="mergedEsResp" search-source="searchSource"></visualize>
<visualize ng-if="vis && rows.length != 0" vis="vis" es-resp="mergedEsResp" search-source="searchSource"></visualize>
</div>
<div class="discover-table" fixed-scroll>

2
src/plugins/kibana/public/visualize/editor/editor.html
View file

@ -138,7 +138,7 @@
</div>
</div>
<visualize chrome="chrome" vis="vis" editable-vis="editableVis" search-source="savedVis.searchSource"></visualize>
<visualize show-spy-panel="chrome.getVisible()" vis="vis" editable-vis="editableVis" search-source="savedVis.searchSource"></visualize>
</div>
</div>

2
src/ui/public/visualize/visualize.html
View file

@ -11,4 +11,4 @@
ng-class="{ loading: vis.type.requiresSearch && searchSource.activeFetchCount > 0 }"
class="visualize-chart"></div>
<!-- <pre>{{chartData | json}}</pre> -->
<visualize-spy ng-if="vis.type.requiresSearch && chrome.getVisible()"></visualize-spy>
<visualize-spy ng-if="vis.type.requiresSearch && showSpyPanel"></visualize-spy>

6
src/ui/public/visualize/visualize.js
View file

@ -16,7 +16,7 @@ define(function (require) {
return {
restrict: 'E',
scope : {
chrome: '=',
showSpyPanel: '=?',
vis: '=',
editableVis: '=?',
esResp: '=?',
@ -27,6 +27,10 @@ define(function (require) {
var chart; // set in "vis" watcher
var minVisChartHeight = 180;
if (_.isUndefined($scope.showSpyPanel)) {
$scope.showSpyPanel = true;
}
function getter(selector) {
return function () {
var $sel = $el.find(selector);