github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[EDR Workflows] Fix saved query skipped test (#187352)

Browse source
This commit is contained in:
Tomasz Ciecierski 2024-07-02 17:27:45 +02:00 • committed by GitHub
parent 8fc3d3ca1b
commit 3b9269faee
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 131 additions and 150 deletions
Download patch file Download diff file Expand all files Collapse all files

135
x-pack/plugins/osquery/cypress/e2e/all/saved_queries.cy.ts
View file

@ -5,7 +5,12 @@
* 2.0.
*/
import { LIVE_QUERY_EDITOR } from '../../screens/live_query';
import { closeToastIfVisible, generateRandomStringName } from '../../tasks/integrations';
import {
LIVE_QUERY_EDITOR,
RESULTS_TABLE_BUTTON,
RESULTS_TABLE_COLUMNS_BUTTON,
} from '../../screens/live_query';
import {
ADD_QUERY_BUTTON,
customActionEditSavedQuerySelector,
@ -16,15 +21,17 @@ import {
import { preparePack } from '../../tasks/packs';
import {
addToCase,
BIG_QUERY,
checkResults,
deleteAndConfirm,
fillInQueryTimeout,
inputQuery,
selectAllAgents,
submitQuery,
verifyQueryTimeout,
viewRecentCaseAndCheckResults,
} from '../../tasks/live_query';
import { navigateTo } from '../../tasks/navigation';
import { getSavedQueriesComplexTest } from '../../tasks/saved_queries';
import {
loadCase,
cleanupCase,
@ -34,6 +41,7 @@ import {
cleanupSavedQuery,
} from '../../tasks/api_fixtures';
import { ServerlessRoleName } from '../../support/roles';
import { getAdvancedButton } from '../../screens/integrations';
describe('ALL - Saved queries', { tags: ['@ess', '@serverless'] }, () => {
let caseId: string;
@ -53,9 +61,128 @@ describe('ALL - Saved queries', { tags: ['@ess', '@serverless'] }, () => {
cleanupCase(caseId);
});
getSavedQueriesComplexTest();
it(
'should create a new query and verify: \n ' +
'- hidden columns, full screen and sorting \n' +
'- pagination \n' +
'- query can viewed (status), edited and deleted ',
() => {
const timeout = '601';
const suffix = generateRandomStringName(1)[0];
const savedQueryId = `Saved-Query-Id-${suffix}`;
const savedQueryDescription = `Test saved query description ${suffix}`;
cy.contains('New live query').click();
selectAllAgents();
inputQuery(BIG_QUERY);
getAdvancedButton().click();
fillInQueryTimeout(timeout);
submitQuery();
checkResults();
// enter fullscreen
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter fullscreen$/).should('exist');
cy.contains('Exit fullscreen').should('not.exist');
cy.getBySel(RESULTS_TABLE_BUTTON).click();
it.skip('checks that user cant add a saved query with an ID that already exists', () => {
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter Fullscreen$/).should('not.exist');
cy.contains('Exit fullscreen').should('exist');
// hidden columns
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns35');
cy.getBySel('dataGridColumnSelectorButton').click();
cy.get('[data-popover-open="true"]').should('be.visible');
cy.getBySel('dataGridColumnSelectorToggleColumnVisibility-osquery.cmdline').click();
cy.getBySel('dataGridColumnSelectorToggleColumnVisibility-osquery.cwd').click();
cy.getBySel(
'dataGridColumnSelectorToggleColumnVisibility-osquery.disk_bytes_written.number'
).click();
cy.getBySel('dataGridColumnSelectorButton').click();
cy.get('[data-popover-open="true"]').should('not.exist');
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
// change pagination
cy.getBySel('pagination-button-next').click();
cy.getBySel('globalLoadingIndicator').should('not.exist');
cy.getBySel('pagination-button-next').click();
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
// enter fullscreen
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter fullscreen$/).should('not.exist');
cy.contains('Exit fullscreen').should('exist');
cy.getBySel(RESULTS_TABLE_BUTTON).click();
// sorting
cy.getBySel('dataGridHeaderCellActionButton-osquery.egid').click({ force: true });
cy.contains(/Sort A-Z$/).click();
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter fullscreen$/).should('exist');
// visit Status results
cy.getBySel('osquery-status-tab').click();
cy.get('tbody > tr.euiTableRow').should('have.lengthOf', 2);
// save new query
cy.contains('Exit full screen').should('not.exist');
cy.contains('Save for later').click();
cy.contains('Save query');
cy.get('input[name="id"]').type(`${savedQueryId}{downArrow}{enter}`);
cy.get('input[name="description"]').type(`${savedQueryDescription}{downArrow}{enter}`);
cy.getBySel('savedQueryFlyoutSaveButton').click();
cy.contains('Successfully saved');
closeToastIfVisible();
// play saved query
navigateTo('/app/osquery/saved_queries');
cy.contains(savedQueryId);
cy.get(`[aria-label="Run ${savedQueryId}"]`).click();
selectAllAgents();
verifyQueryTimeout(timeout);
submitQuery();
// edit saved query
cy.contains('Saved queries').click();
cy.contains(savedQueryId);
cy.get(`[aria-label="Edit ${savedQueryId}"]`).click();
cy.get('input[name="description"]').type(` Edited{downArrow}{enter}`);
// Run in test configuration
cy.contains('Test configuration').click();
selectAllAgents();
verifyQueryTimeout(timeout);
submitQuery();
checkResults();
// Disabled submit button in test configuration
cy.contains('Submit').should('not.be.disabled');
cy.getBySel('osquery-save-query-flyout').within(() => {
cy.contains('Query is a required field').should('not.exist');
// this clears the input
inputQuery('{selectall}{backspace}{selectall}{backspace}');
cy.contains('Query is a required field');
inputQuery(BIG_QUERY);
cy.contains('Query is a required field').should('not.exist');
});
// Save edited
cy.getBySel('euiFlyoutCloseButton').click();
cy.getBySel('update-query-button').click();
cy.contains(`${savedQueryDescription} Edited`);
// delete saved query
cy.contains(savedQueryId);
cy.get(`[aria-label="Edit ${savedQueryId}"]`).click();
deleteAndConfirm('query');
cy.contains(savedQueryId).should('exist');
cy.contains(savedQueryId).should('not.exist');
}
);
it('checks that user cant add a saved query with an ID that already exists', () => {
cy.contains('Saved queries').click();
cy.contains('Add saved query').click();
cy.get('input[name="id"]').type(`users_elastic{downArrow}{enter}`);

146
x-pack/plugins/osquery/cypress/tasks/saved_queries.ts
View file

@ -1,146 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { getAdvancedButton } from '../screens/integrations';
import { RESULTS_TABLE_BUTTON, RESULTS_TABLE_COLUMNS_BUTTON } from '../screens/live_query';
import { closeToastIfVisible, generateRandomStringName } from './integrations';
import {
checkResults,
BIG_QUERY,
deleteAndConfirm,
inputQuery,
selectAllAgents,
submitQuery,
fillInQueryTimeout,
verifyQueryTimeout,
} from './live_query';
import { navigateTo } from './navigation';
export const getSavedQueriesComplexTest = () =>
describe('Saved queries Complex Test', () => {
const timeout = '601';
const suffix = generateRandomStringName(1)[0];
const savedQueryId = `Saved-Query-Id-${suffix}`;
const savedQueryDescription = `Test saved query description ${suffix}`;
it(
'should create a new query and verify: \n ' +
'- hidden columns, full screen and sorting \n' +
'- pagination \n' +
'- query can viewed (status), edited and deleted ',
() => {
cy.contains('New live query').click();
selectAllAgents();
inputQuery(BIG_QUERY);
getAdvancedButton().click();
fillInQueryTimeout(timeout);
submitQuery();
checkResults();
// enter fullscreen
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter fullscreen$/).should('exist');
cy.contains('Exit fullscreen').should('not.exist');
cy.getBySel(RESULTS_TABLE_BUTTON).click();
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter Fullscreen$/).should('not.exist');
cy.contains('Exit fullscreen').should('exist');
// hidden columns
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns35');
cy.getBySel('dataGridColumnSelectorButton').click();
cy.get('[data-popover-open="true"]').should('be.visible');
cy.getBySel('dataGridColumnSelectorToggleColumnVisibility-osquery.cmdline').click();
cy.getBySel('dataGridColumnSelectorToggleColumnVisibility-osquery.cwd').click();
cy.getBySel(
'dataGridColumnSelectorToggleColumnVisibility-osquery.disk_bytes_written.number'
).click();
cy.getBySel('dataGridColumnSelectorButton').click();
cy.get('[data-popover-open="true"]').should('not.exist');
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
// change pagination
cy.getBySel('pagination-button-next').click();
cy.getBySel('globalLoadingIndicator').should('not.exist');
cy.getBySel('pagination-button-next').click();
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
// enter fullscreen
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter fullscreen$/).should('not.exist');
cy.contains('Exit fullscreen').should('exist');
cy.getBySel(RESULTS_TABLE_BUTTON).click();
// sorting
cy.getBySel('dataGridHeaderCellActionButton-osquery.egid').click({ force: true });
cy.contains(/Sort A-Z$/).click();
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter fullscreen$/).should('exist');
// visit Status results
cy.getBySel('osquery-status-tab').click();
cy.get('tbody > tr.euiTableRow').should('have.lengthOf', 2);
// save new query
cy.contains('Exit full screen').should('not.exist');
cy.contains('Save for later').click();
cy.contains('Save query');
cy.get('input[name="id"]').type(`${savedQueryId}{downArrow}{enter}`);
cy.get('input[name="description"]').type(`${savedQueryDescription}{downArrow}{enter}`);
cy.getBySel('savedQueryFlyoutSaveButton').click();
cy.contains('Successfully saved');
closeToastIfVisible();
// play saved query
navigateTo('/app/osquery/saved_queries');
cy.contains(savedQueryId);
cy.get(`[aria-label="Run ${savedQueryId}"]`).click();
selectAllAgents();
verifyQueryTimeout(timeout);
submitQuery();
// edit saved query
cy.contains('Saved queries').click();
cy.contains(savedQueryId);
cy.get(`[aria-label="Edit ${savedQueryId}"]`).click();
cy.get('input[name="description"]').type(` Edited{downArrow}{enter}`);
// Run in test configuration
cy.contains('Test configuration').click();
selectAllAgents();
verifyQueryTimeout(timeout);
submitQuery();
checkResults();
// Disabled submit button in test configuration
cy.contains('Submit').should('not.be.disabled');
cy.getBySel('osquery-save-query-flyout').within(() => {
cy.contains('Query is a required field').should('not.exist');
// this clears the input
inputQuery('{selectall}{backspace}{selectall}{backspace}');
cy.contains('Query is a required field');
inputQuery(BIG_QUERY);
cy.contains('Query is a required field').should('not.exist');
});
// Save edited
cy.getBySel('euiFlyoutCloseButton').click();
cy.getBySel('update-query-button').click();
cy.contains(`${savedQueryDescription} Edited`);
// delete saved query
cy.contains(savedQueryId);
cy.get(`[aria-label="Edit ${savedQueryId}"]`).click();
deleteAndConfirm('query');
cy.contains(savedQueryId).should('exist');
cy.contains(savedQueryId).should('not.exist');
}
);
});