github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.12] [ES|QL] Small improvements on the warnings/errors (#172782) (#172843)

Browse source 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[ES|QL] Small improvements on the warnings/errors
(#172782)](https://github.com/elastic/kibana/pull/172782)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2023-12-07T15:35:34Z","message":"[ES|QL]
Small improvements on the warnings/errors (#172782)\n\n##
Summary\r\n\r\nThis is a PR which:\r\n\r\n- Corrects the icon shown in
warnings (it was displaying the error icon\r\nwhich is wrong)\r\n<img
width=\"1253\"
alt=\"image\"\r\nsrc=\"4f388edd-734c-4299-9def-841ac6fccba1\">\r\n\r\n-
Makes the icon also clickable (opens the popover with the list
of\r\nwarnings/errors)\r\n\r\nCo-authored-by: Marco Liberati
<dej611@users.noreply.github.com>","sha":"71ed936685042fb4073e9d035bdb8bd777e8cabd","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport:prev-minor","Feature:ES|QL","v8.12.0","v8.13.0"],"number":172782,"url":"https://github.com/elastic/kibana/pull/172782","mergeCommit":{"message":"[ES|QL]
Small improvements on the warnings/errors (#172782)\n\n##
Summary\r\n\r\nThis is a PR which:\r\n\r\n- Corrects the icon shown in
warnings (it was displaying the error icon\r\nwhich is wrong)\r\n<img
width=\"1253\"
alt=\"image\"\r\nsrc=\"4f388edd-734c-4299-9def-841ac6fccba1\">\r\n\r\n-
Makes the icon also clickable (opens the popover with the list
of\r\nwarnings/errors)\r\n\r\nCo-authored-by: Marco Liberati
<dej611@users.noreply.github.com>","sha":"71ed936685042fb4073e9d035bdb8bd777e8cabd"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172782","number":172782,"mergeCommit":{"message":"[ES|QL]
Small improvements on the warnings/errors (#172782)\n\n##
Summary\r\n\r\nThis is a PR which:\r\n\r\n- Corrects the icon shown in
warnings (it was displaying the error icon\r\nwhich is wrong)\r\n<img
width=\"1253\"
alt=\"image\"\r\nsrc=\"4f388edd-734c-4299-9def-841ac6fccba1\">\r\n\r\n-
Makes the icon also clickable (opens the popover with the list
of\r\nwarnings/errors)\r\n\r\nCo-authored-by: Marco Liberati
<dej611@users.noreply.github.com>","sha":"71ed936685042fb4073e9d035bdb8bd777e8cabd"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This commit is contained in:
Kibana Machine 2023-12-07 11:53:30 -05:00 • committed by GitHub
parent f917515e6a
commit 3b9c879d6c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
packages/kbn-text-based-editor/src/editor_footer.tsx
View file

@ -109,7 +109,14 @@ export function ErrorsWarningsPopover({
<EuiFlexItem grow={false}>
<EuiFlexGroup gutterSize="xs" responsive={false} alignItems="center">
<EuiFlexItem grow={false}>
<EuiIcon type="error" color={strings.color} size="s" />
<EuiIcon
type={type}
color={strings.color}
size="s"
onClick={() => {
setIsPopoverOpen(!isPopoverOpen);
}}
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiPopover