github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

unskip accessibility - dashboard_edit_panel tests (#96710)

Browse source 
* unskip

* added render complete

* added render complete in couple other places

* minor corrections

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Rashmi Kulkarni 2021-04-14 15:05:12 -07:00 • committed by GitHub
parent deaa7794d5
commit 3ba640403f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/functional/services/dashboard/panel_actions.ts
View file

@ -24,7 +24,7 @@ const SAVE_TO_LIBRARY_TEST_SUBJ = 'embeddablePanelAction-saveToLibrary';
export function DashboardPanelActionsProvider({ getService, getPageObjects }: FtrProviderContext) { export function DashboardPanelActionsProvider({ getService, getPageObjects }: FtrProviderContext) {
const log = getService('log'); const log = getService('log');
const testSubjects = getService('testSubjects'); const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['header', 'common']); const PageObjects = getPageObjects(['header', 'common', 'dashboard']);
const inspector = getService('inspector'); const inspector = getService('inspector');
return new (class DashboardPanelActions { return new (class DashboardPanelActions {
@ -147,6 +147,7 @@ export function DashboardPanelActionsProvider({ getService, getPageObjects }: Ft
await this.openContextMenu(); await this.openContextMenu();
} }
await testSubjects.click(CLONE_PANEL_DATA_TEST_SUBJ); await testSubjects.click(CLONE_PANEL_DATA_TEST_SUBJ);
await PageObjects.dashboard.waitForRenderComplete();
} }
async openCopyToModalByTitle(title?: string) { async openCopyToModalByTitle(title?: string) {

3
x-pack/test/accessibility/apps/dashboard_edit_panel.ts
View file

@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PANEL_TITLE = 'Visualization PieChart'; const PANEL_TITLE = 'Visualization PieChart';
// FLAKY: https://github.com/elastic/kibana/issues/92114 describe('Dashboard Edit Panel', () => {
describe.skip('Dashboard Edit Panel', () => {
before(async () => { before(async () => {
await esArchiver.load('dashboard/drilldowns'); await esArchiver.load('dashboard/drilldowns');
await esArchiver.loadIfNeeded('logstash_functional'); await esArchiver.loadIfNeeded('logstash_functional');