github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix centered dashboard listing (#21119)

Browse source
This commit is contained in:
dave.snider@gmail.com 2018-07-24 08:44:16 -07:00 • committed by GitHub
parent 3e9c26a402
commit 3bc65f142c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/core_plugins/kibana/public/dashboard/listing/__snapshots__/dashboard_listing.test.js.snap
View file

@ -6,10 +6,9 @@ exports[`after fetch hideWriteControls 1`] = `
data-test-subj="dashboardLandingPage"
restrictWidth={false}
>
<EuiPageBody
restrictWidth={true}
>
<EuiPageBody>
<EuiPageContent
className="dashboardLandingPageContent"
horizontalPosition="center"
panelPaddingSize="l"
>
@ -36,10 +35,9 @@ exports[`after fetch initialFilter 1`] = `
data-test-subj="dashboardLandingPage"
restrictWidth={false}
>
<EuiPageBody
restrictWidth={true}
>
<EuiPageBody>
<EuiPageContent
className="dashboardLandingPageContent"
horizontalPosition="center"
panelPaddingSize="l"
>
@ -188,10 +186,9 @@ exports[`after fetch renders call to action when no dashboards exist 1`] = `
data-test-subj="dashboardLandingPage"
restrictWidth={false}
>
<EuiPageBody
restrictWidth={true}
>
<EuiPageBody>
<EuiPageContent
className="dashboardLandingPageContent"
horizontalPosition="center"
panelPaddingSize="l"
>
@ -248,10 +245,9 @@ exports[`after fetch renders table rows 1`] = `
data-test-subj="dashboardLandingPage"
restrictWidth={false}
>
<EuiPageBody
restrictWidth={true}
>
<EuiPageBody>
<EuiPageContent
className="dashboardLandingPageContent"
horizontalPosition="center"
panelPaddingSize="l"
>
@ -400,10 +396,9 @@ exports[`after fetch renders warning when listingLimit is exceeded 1`] = `
data-test-subj="dashboardLandingPage"
restrictWidth={false}
>
<EuiPageBody
restrictWidth={true}
>
<EuiPageBody>
<EuiPageContent
className="dashboardLandingPageContent"
horizontalPosition="center"
panelPaddingSize="l"
>
@ -583,8 +578,6 @@ exports[`renders empty page in before initial fetch to avoid flickering 1`] = `
data-test-subj="dashboardLandingPage"
restrictWidth={false}
>
<EuiPageBody
restrictWidth={true}
/>
<EuiPageBody />
</EuiPage>
`;

5
src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js
View file

@ -454,7 +454,7 @@ export class DashboardListing extends React.Component {
}
return (
<EuiPageContent horizontalPosition="center">
<EuiPageContent className="dashboardLandingPageContent" horizontalPosition="center">
{this.renderListingOrEmptyState()}
</EuiPageContent>
);
@ -463,7 +463,8 @@ export class DashboardListing extends React.Component {
render() {
return (
<EuiPage data-test-subj="dashboardLandingPage" className="dashboardLandingPage">
<EuiPageBody restrictWidth>
{/* TODO: add restrictWidth prop on EuiPageBody here when EUI@3.0.2 is applied */}
<EuiPageBody>
{this.renderPageContent()}
</EuiPageBody>
</EuiPage>

11
src/core_plugins/kibana/public/dashboard/styles/index.less
View file

@ -434,7 +434,16 @@ dashboard-viewport-provider {
}
}
.dashboardLandingPage {
// Mimics EuiPageBackground
dashboard-listing {
background-color: @globalColorLightestGray;
min-height: 100vh;
}
.dashboardLandingPage {
background: @globalColorLightestGray;
}
.dashboardLandingPageContent {
max-width: 1000px !important; // Temp fix till EUI@3.0.2 is merged
}