github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[7.5] [ML] Fix anomaly detection test suite (#51712) (#52050)

Browse source 
* [ML] Fix anomaly detection test suite (#51712)

This PR re-enables the anomaly detection test suite and disables Firefox test execution for now. It also increases stability for `clickEditDetector` and removes unneeded retries.

* Add retry for add detector as well
This commit is contained in:
Robert Oskamp 2019-12-03 16:19:44 +01:00 • committed by GitHub
parent bacf2bbe24
commit 3bfe9f9868
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

5
x-pack/test/functional/apps/machine_learning/anomaly_detection/index.ts
View file

@ -6,8 +6,9 @@
import { FtrProviderContext } from '../../../ftr_provider_context';
export default function({ loadTestFile }: FtrProviderContext) {
// FLAKY: https://github.com/elastic/kibana/issues/51669
describe.skip('anomaly detection', function() {
describe('anomaly detection', function() {
this.tags(['skipFirefox']);
loadTestFile(require.resolve('./single_metric_job'));
loadTestFile(require.resolve('./multi_metric_job'));
loadTestFile(require.resolve('./population_job'));

6
x-pack/test/functional/services/machine_learning/job_management.ts
View file

@ -15,7 +15,6 @@ export function MachineLearningJobManagementProvider(
mlApi: ProvidedType<typeof MachineLearningAPIProvider>
) {
const testSubjects = getService('testSubjects');
const retry = getService('retry');
return {
async navigateToNewJobSourceSelection() {
@ -36,10 +35,7 @@ export function MachineLearningJobManagementProvider(
},
async assertStartDatafeedModalExists() {
// this retry can be removed as soon as #48734 is merged
await retry.tryForTime(5000, async () => {
await testSubjects.existOrFail('mlStartDatafeedModal');
});
await testSubjects.existOrFail('mlStartDatafeedModal', { timeout: 5000 });
},
async confirmStartDatafeedModal() {

26
x-pack/test/functional/services/machine_learning/job_wizard_advanced.ts
View file

@ -141,15 +141,14 @@ export function MachineLearningJobWizardAdvancedProvider({
},
async openCreateDetectorModal() {
await testSubjects.click('mlAddDetectorButton');
await this.assertCreateDetectorModalExists();
await retry.tryForTime(20 * 1000, async () => {
await testSubjects.click('mlAddDetectorButton');
await this.assertCreateDetectorModalExists();
});
},
async assertCreateDetectorModalExists() {
// this retry can be removed as soon as #48734 is merged
await retry.tryForTime(5000, async () => {
await testSubjects.existOrFail('mlCreateDetectorModal');
});
await testSubjects.existOrFail('mlCreateDetectorModal', { timeout: 5000 });
},
async assertDetectorFunctionInputExists() {
@ -298,18 +297,17 @@ export function MachineLearningJobWizardAdvancedProvider({
},
async clickEditDetector(detectorIndex: number) {
await testSubjects.click(
`mlAdvancedDetector ${detectorIndex} > mlAdvancedDetectorEditButton`
);
await this.assertCreateDetectorModalExists();
await retry.tryForTime(20 * 1000, async () => {
await testSubjects.click(
`mlAdvancedDetector ${detectorIndex} > mlAdvancedDetectorEditButton`
);
await this.assertCreateDetectorModalExists();
});
},
async createJob() {
await testSubjects.clickWhenNotDisabled('mlJobWizardButtonCreateJob');
// this retry can be removed as soon as #48734 is merged
await retry.tryForTime(5000, async () => {
await testSubjects.existOrFail('mlStartDatafeedModal');
});
await testSubjects.existOrFail('mlStartDatafeedModal', { timeout: 10 * 1000 });
},
};
}