github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[obs AI Assistant] fix title_conversation failing test (#216112)

Browse source 
Closes #215952

[obs AI Assistant] fix title_conversation failing test
This commit is contained in:
Arturo Lidueña 2025-03-31 16:56:32 +02:00 • committed by GitHub
parent c4f7c649b1
commit 3c9593b1a6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

22
x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/complete/functions/title_conversation.spec.ts
View file

@ -11,20 +11,20 @@ import {
TITLE_CONVERSATION_FUNCTION_NAME,
TITLE_SYSTEM_MESSAGE,
} from '@kbn/observability-ai-assistant-plugin/server/service/client/operators/get_generated_title';
import { MessageRole } from '@kbn/observability-ai-assistant-plugin/common';
import {
LlmProxy,
createLlmProxy,
} from '../../../../../../../observability_ai_assistant_api_integration/common/create_llm_proxy';
import { chatComplete } from '../../utils/conversation';
import { chatComplete, clearConversations } from '../../utils/conversation';
import type { DeploymentAgnosticFtrProviderContext } from '../../../../../ftr_provider_context';
export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderContext) {
const log = getService('log');
const observabilityAIAssistantAPIClient = getService('observabilityAIAssistantApi');
const es = getService('es');
// Failing: See https://github.com/elastic/kibana/issues/215952
// Failing: See https://github.com/elastic/kibana/issues/215952
describe.skip('when calling the title_conversation function', function () {
describe('when calling the title_conversation function', function () {
// Fails on MKI: https://github.com/elastic/kibana/issues/205581
this.tags(['failsOnMKI']);
let llmProxy: LlmProxy;
@ -52,7 +52,8 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
let conversationId: string;
before(async () => {
void llmProxy.interceptTitle(TITLE);
await clearConversations(es);
const simulatorPromise = llmProxy.interceptTitle(TITLE);
void llmProxy.interceptConversation('The sky is blue because of Rayleigh scattering.');
const res = await chatComplete({
@ -65,7 +66,12 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
await llmProxy.waitForAllInterceptorsToHaveBeenCalled();
titleRequestBody = llmProxy.interceptedRequests[0].requestBody;
const simulator = await simulatorPromise;
titleRequestBody = simulator.requestBody;
});
after(async () => {
await clearConversations(es);
});
it('makes 2 requests to the LLM', () => {
@ -74,13 +80,13 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
it('sends the correct system message to the LLM for the title', () => {
expect(
titleRequestBody.messages.find((message) => message.role === 'system')?.content
titleRequestBody.messages.find((message) => message.role === MessageRole.System)?.content
).to.be(TITLE_SYSTEM_MESSAGE);
});
it('sends the correct user message to the LLM for the title', () => {
expect(
titleRequestBody.messages.find((message) => message.role === 'user')?.content
titleRequestBody.messages.find((message) => message.role === MessageRole.User)?.content
).to.contain('Why the sky is blue?');
});