github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Visualize] Do not display a toast about missing provider when error is displayed (#189866)

Browse source 
## Summary

To reproduce:
1. Trigger an error on visualize visualization on the dashboard. A quick
way of doing it would be just to import this saved object, that creates
a visualization on a field that doesn't exist.
2. This toast appears:
<img width="1142" alt="Screenshot 2024-08-05 at 11 44 48"
src="https://github.com/user-attachments/assets/e6d945f6-a53d-403e-a898-77f76de5494b">



[test_toast_bug.json](https://github.com/user-attachments/files/16493961/test_toast_bug.json)


This PR fixes it (doesn't display the toast). Should we backport? 🤔
This commit is contained in:
Marta Bondyra 2024-08-06 12:33:42 +02:00 • committed by GitHub
parent 13b15bd2e3
commit 3cf66e1498
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/plugins/visualizations/public/embeddable/visualize_embeddable.tsx
View file

@ -527,20 +527,27 @@ export class VisualizeEmbeddable
}
private renderError(error: ErrorLike | string) {
const { core } = this.deps.start();
if (isFallbackDataView(this.vis.data.indexPattern)) {
return (
<VisualizationMissedSavedObjectError
renderMode={this.input.renderMode ?? 'view'}
savedObjectMeta={{
savedObjectType: this.vis.data.savedSearchId ? 'search' : DATA_VIEW_SAVED_OBJECT_TYPE,
}}
application={getApplication()}
message={typeof error === 'string' ? error : error.message}
/>
<KibanaRenderContextProvider {...core}>
<VisualizationMissedSavedObjectError
renderMode={this.input.renderMode ?? 'view'}
savedObjectMeta={{
savedObjectType: this.vis.data.savedSearchId ? 'search' : DATA_VIEW_SAVED_OBJECT_TYPE,
}}
application={getApplication()}
message={typeof error === 'string' ? error : error.message}
/>
</KibanaRenderContextProvider>
);
}
return <VisualizationError error={error} />;
return (
<KibanaRenderContextProvider {...core}>
<VisualizationError error={error} />
</KibanaRenderContextProvider>
);
}
public destroy() {