github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 01:13:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[maps] unskip Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/dashboard_maps_by_value·ts (#153973)

Browse source 
Fixes https://github.com/elastic/kibana/issues/153959

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2063

test failing because of EMS access issues. Refactored test to remove EMS
dependency as EMS connectivity is not the intention of the test.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Nathan Reese 2023-03-30 12:14:22 -06:00 • committed by GitHub
parent 78450b0fae
commit 3cfa8a92d4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

19
x-pack/test/functional/apps/dashboard/group2/dashboard_maps_by_value.ts
View file

@ -25,7 +25,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const dashboardAddPanel = getService('dashboardAddPanel');
const kibanaServer = getService('kibanaServer');
const LAYER_NAME = 'World Countries';
let mapCounter = 0;
async function createAndAddMapByValue() {
@ -48,11 +47,11 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await dashboardPanelActions.openContextMenu();
await dashboardPanelActions.clickEdit();
await PageObjects.maps.clickAddLayer();
await PageObjects.maps.selectEMSBoundariesSource();
await PageObjects.maps.selectVectorLayer(LAYER_NAME);
await PageObjects.maps.selectLayerGroupCard();
await testSubjects.click('importFileButton');
if (saveToLibrary) {
await testSubjects.click('importFileButton');
await testSubjects.click('mapSaveButton');
await PageObjects.timeToVisualize.ensureSaveModalIsOpen;
@ -76,9 +75,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.dashboard.clickNewDashboard();
}
// FLAKY: https://github.com/elastic/kibana/issues/135293
// FLAKY: https://github.com/elastic/kibana/issues/153959
describe.skip('dashboard maps by value', function () {
describe('dashboard maps by value', function () {
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');
await kibanaServer.importExport.load(
@ -116,7 +113,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
it('updates the panel on return', async () => {
const hasLayer = await PageObjects.maps.doesLayerExist(LAYER_NAME);
const hasLayer = await PageObjects.maps.doesLayerExist('Layer group');
expect(hasLayer).to.be(true);
});
});
@ -130,13 +127,15 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('updates the existing panel when adding to dashboard', async () => {
await editByValueMap(true);
const hasLayer = await PageObjects.maps.doesLayerExist(LAYER_NAME);
const hasLayer = await PageObjects.maps.doesLayerExist('Layer group');
expect(hasLayer).to.be(true);
});
it('does not update the panel when only saving to library', async () => {
await editByValueMap(true, false);
const hasLayer = await PageObjects.maps.doesLayerExist('Layer group');
expect(hasLayer).to.be(false);
});
});
});

15
x-pack/test/functional/page_objects/gis_page.ts
View file

@ -533,9 +533,9 @@ export class GisPageObject extends FtrService {
await this.waitForLayersToLoad();
}
async selectEMSBoundariesSource() {
this.log.debug(`Select Elastic Maps Service boundaries source`);
await this.testSubjects.click('emsBoundaries');
async selectLayerGroupCard() {
this.log.debug(`Click layer group card`);
await this.testSubjects.click('layerGroup');
}
async selectFileUploadCard() {
@ -543,15 +543,6 @@ export class GisPageObject extends FtrService {
await this.testSubjects.click('uploadFile');
}
async selectVectorLayer(vectorLayerName: string) {
this.log.debug(`Select EMS vector layer ${vectorLayerName}`);
if (!vectorLayerName) {
throw new Error(`You did not provide the EMS layer to select`);
}
await this.comboBox.set('emsVectorComboBox', vectorLayerName);
await this.waitForLayersToLoad();
}
async removeLayer(layerName: string) {
this.log.debug(`Remove layer ${layerName}`);
await this.openLayerPanel(layerName);