github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution][Investigations] - Change context menu text and add test (#117673) (#117710)

Browse source 
Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
This commit is contained in:
Kibana Machine 2021-11-05 15:30:49 -04:00 • committed by GitHub
parent fd86f36b72
commit 3deb3a9dc5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 114 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

113
x-pack/plugins/security_solution/public/timelines/components/timeline/cell_rendering/default_cell_renderer.test.tsx
View file

@ -161,3 +161,116 @@ describe('DefaultCellRenderer', () => {
).toBeTruthy();
});
});
describe('host link rendering', () => {
const data = cloneDeep(mockTimelineData[0].data);
const hostNameHeader = cloneDeep(defaultHeaders[4]);
beforeEach(() => {
const { getColumnRenderer: realGetColumnRenderer } = jest.requireActual(
'../body/renderers/get_column_renderer'
);
getColumnRendererMock.mockImplementation(realGetColumnRenderer); // link rendering tests must use the real renderer
});
test('it renders a link button for `host.name` when `isTimeline` is true', () => {
const id = 'host.name';
const isTimeline = true;
const wrapper = mount(
<TestProviders>
<DragDropContextWrapper browserFields={mockBrowserFields}>
<DroppableWrapper droppableId="testing">
<DefaultCellRenderer
browserFields={undefined}
columnId={id}
ecsData={undefined}
data={data}
eventId="_id-123"
header={hostNameHeader}
isDetails={false}
isDraggable={true}
isExpandable={false}
isExpanded={false}
isTimeline={isTimeline}
linkValues={[]}
rowIndex={3}
setCellProps={jest.fn()}
timelineId={'timeline-1-query'}
/>
</DroppableWrapper>
</DragDropContextWrapper>
</TestProviders>
);
expect(wrapper.find('[data-test-subj="host-details-button"]').first().text()).toEqual('apache');
});
test('it does NOT render a link button for `host.name` when `isTimeline` is false', () => {
const id = 'host.name';
const isTimeline = false;
const wrapper = mount(
<TestProviders>
<DragDropContextWrapper browserFields={mockBrowserFields}>
<DroppableWrapper droppableId="testing">
<DefaultCellRenderer
browserFields={undefined}
columnId={id}
ecsData={undefined}
data={data}
eventId="_id-123"
header={hostNameHeader}
isDetails={false}
isDraggable={true}
isExpandable={false}
isExpanded={false}
isTimeline={isTimeline}
linkValues={[]}
rowIndex={3}
setCellProps={jest.fn()}
timelineId={'timeline-1-query'}
/>
</DroppableWrapper>
</DragDropContextWrapper>
</TestProviders>
);
expect(wrapper.find('[data-test-subj="host-details-button"]').exists()).toBe(false);
});
test('it does NOT render a link button for non-host fields when `isTimeline` is true', () => {
const id = '@timestamp'; // a non-host field
const isTimeline = true;
const timestampHeader = cloneDeep(defaultHeaders[0]);
const wrapper = mount(
<TestProviders>
<DragDropContextWrapper browserFields={mockBrowserFields}>
<DroppableWrapper droppableId="testing">
<DefaultCellRenderer
browserFields={undefined}
columnId={id}
ecsData={undefined}
data={data}
eventId="_id-123"
header={timestampHeader}
isDetails={false}
isDraggable={true}
isExpandable={false}
isExpanded={false}
isTimeline={isTimeline}
linkValues={[]}
rowIndex={3}
setCellProps={jest.fn()}
timelineId={'timeline-1-query'}
/>
</DroppableWrapper>
</DragDropContextWrapper>
</TestProviders>
);
expect(wrapper.find('[data-test-subj="host-details-button"]').exists()).toBe(false);
});
});

2
x-pack/plugins/timelines/public/components/t_grid/translations.ts
View file

@ -22,7 +22,7 @@ export const EVENTS_TABLE_ARIA_LABEL = ({
export const BULK_ACTION_OPEN_SELECTED = i18n.translate(
'xpack.timelines.timeline.openSelectedTitle',
{
defaultMessage: 'Open selected',
defaultMessage: 'Mark as open',
}
);