github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Vis Editor] Fix undefined error in Field control (#37179) (#37314)

Browse source 
* Add default value for labels in sortByLabel function

* TS: make label optional
This commit is contained in:
Maryia Lapata 2019-05-29 12:55:38 +03:00 • committed by GitHub
parent 3de093d1b6
commit 3f27ffb869
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/legacy/ui/public/vis/editors/default/default_editor_utils.tsx
View file

@ -25,7 +25,7 @@ import { AggType } from 'ui/agg_types';
// https://github.com/babel/babel/issues/7641
//
export type ComboBoxGroupedOption = EuiComboBoxOptionProps & {
label: string;
label?: string;
value?: AggType;
options?: ComboBoxGroupedOption[];
};
@ -37,7 +37,7 @@ export type ComboBoxGroupedOption = EuiComboBoxOptionProps & {
* @param groupBy A field name which aggregations is grouped by.
* @param labelName A name of a property which value will be displayed.
*
* @returns An array of grouped and sorted alphabetically `aggs` that are compatible with EuiComboBox options. If `aggs` is not an array, the function returns an ampry array.
* @returns An array of grouped and sorted alphabetically `aggs` that are compatible with EuiComboBox options. If `aggs` is not an array, the function returns an empty array.
*/
function groupAggregationsBy(
aggs: AggType[],
@ -80,7 +80,7 @@ function groupAggregationsBy(
}
function sortByLabel(a: ComboBoxGroupedOption, b: ComboBoxGroupedOption) {
return a.label.toLowerCase().localeCompare(b.label.toLowerCase());
return (a.label || '').toLowerCase().localeCompare((b.label || '').toLowerCase());
}
export { groupAggregationsBy };