github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution][THI] - remove obsolete analyzerDatePickersAndSourcererDisabled feature flag (#205176)

Browse source 
## Summary

This PR removes the `analyzerDatePickersAndSourcererDisabled` feature
flag that was introduced a long time ago and has been in `disabled:
false` state for many months.
I noticed that the line was moved in [this
PR](https://github.com/elastic/kibana/pull/176064) over 6 months ago but
the introduction of the feature precedes that.

No UI changes introduced!
This commit is contained in:
Philippe Oberti 2025-01-08 16:59:58 +01:00 • committed by GitHub
parent 019f0e8414
commit 3fd987caa8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 14 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

6
x-pack/solutions/security/plugins/security_solution/common/experimental_features.ts
View file

@ -190,12 +190,6 @@ export const allowedExperimentalValues = Object.freeze({
*/ */
timelineEsqlTabDisabled: false, timelineEsqlTabDisabled: false,
/*
* Disables date pickers and sourcerer in analyzer if needed.
*
*/
analyzerDatePickersAndSourcererDisabled: false,
/** /**
* Enables graph visualization in alerts flyout * Enables graph visualization in alerts flyout
*/ */

32
x-pack/solutions/security/plugins/security_solution/public/resolver/view/controls/index.tsx
View file

@ -22,7 +22,6 @@ import {
userSetPositionOfCamera, userSetPositionOfCamera,
} from '../../store/camera/action'; } from '../../store/camera/action';
import type { State } from '../../../common/store/types'; import type { State } from '../../../common/store/types';
import { useIsExperimentalFeatureEnabled } from '../../../common/hooks/use_experimental_features';
import { SourcererButton } from './sourcerer_selection'; import { SourcererButton } from './sourcerer_selection';
import { DateSelectionButton } from './date_picker'; import { DateSelectionButton } from './date_picker';
import { StyledGraphControls, StyledGraphControlsColumn, StyledEuiRange } from './styles'; import { StyledGraphControls, StyledGraphControlsColumn, StyledEuiRange } from './styles';
@ -61,9 +60,6 @@ export const GraphControls = React.memo(
selectors.scalingFactor(state.analyzer[id]) selectors.scalingFactor(state.analyzer[id])
); );
const { timestamp } = useContext(SideEffectContext); const { timestamp } = useContext(SideEffectContext);
const isDatePickerAndSourcererDisabled = useIsExperimentalFeatureEnabled(
'analyzerDatePickersAndSourcererDisabled'
);
const [activePopover, setPopover] = useState<PopoverType>(null); const [activePopover, setPopover] = useState<PopoverType>(null);
const colorMap = useColors(); const colorMap = useColors();
@ -143,22 +139,18 @@ export const GraphControls = React.memo(
isOpen={activePopover === 'nodeLegend'} isOpen={activePopover === 'nodeLegend'}
setActivePopover={setActivePopover} setActivePopover={setActivePopover}
/> />
{!isDatePickerAndSourcererDisabled ? ( <SourcererButton
<> id={id}
<SourcererButton closePopover={closePopover}
id={id} isOpen={activePopover === 'sourcererSelection'}
closePopover={closePopover} setActivePopover={setActivePopover}
isOpen={activePopover === 'sourcererSelection'} />
setActivePopover={setActivePopover} <DateSelectionButton
/> id={id}
<DateSelectionButton closePopover={closePopover}
id={id} isOpen={activePopover === 'datePicker'}
closePopover={closePopover} setActivePopover={setActivePopover}
isOpen={activePopover === 'datePicker'} />
setActivePopover={setActivePopover}
/>
</>
) : null}
{isSplitPanel && showPanelOnClick && ( {isSplitPanel && showPanelOnClick && (
<ShowPanelButton showPanelOnClick={showPanelOnClick} /> <ShowPanelButton showPanelOnClick={showPanelOnClick} />
)} )}

32
x-pack/solutions/security/plugins/security_solution/public/timelines/containers/use_timeline_data_filters.ts
View file

@ -6,27 +6,19 @@
*/ */
import { useMemo } from 'react'; import { useMemo } from 'react';
import { useSelector } from 'react-redux';
import { useLocation } from 'react-router-dom';
import { useDeepEqualSelector } from '../../common/hooks/use_selector'; import { useDeepEqualSelector } from '../../common/hooks/use_selector';
import { import {
isLoadingSelector, isLoadingSelector,
startSelector, startSelector,
endSelector, endSelector,
} from '../../common/components/super_date_picker/selectors'; } from '../../common/components/super_date_picker/selectors';
import { useIsExperimentalFeatureEnabled } from '../../common/hooks/use_experimental_features';
import { SourcererScopeName } from '../../sourcerer/store/model'; import { SourcererScopeName } from '../../sourcerer/store/model';
import { useSourcererDataView } from '../../sourcerer/containers'; import { useSourcererDataView } from '../../sourcerer/containers';
import { getScopeFromPath } from '../../sourcerer/containers/sourcerer_paths';
import { sourcererSelectors } from '../../common/store';
export function useTimelineDataFilters(isActiveTimelines: boolean) { export function useTimelineDataFilters(isActiveTimelines: boolean) {
const getStartSelector = useMemo(() => startSelector(), []); const getStartSelector = useMemo(() => startSelector(), []);
const getEndSelector = useMemo(() => endSelector(), []); const getEndSelector = useMemo(() => endSelector(), []);
const getIsLoadingSelector = useMemo(() => isLoadingSelector(), []); const getIsLoadingSelector = useMemo(() => isLoadingSelector(), []);
const isDatePickerAndSourcererDisabled = useIsExperimentalFeatureEnabled(
'analyzerDatePickersAndSourcererDisabled'
);
const shouldUpdate = useDeepEqualSelector((state) => { const shouldUpdate = useDeepEqualSelector((state) => {
if (isActiveTimelines) { if (isActiveTimelines) {
@ -49,35 +41,15 @@ export function useTimelineDataFilters(isActiveTimelines: boolean) {
return getEndSelector(state.inputs.global); return getEndSelector(state.inputs.global);
} }
}); });
const defaultDataView = useSelector(sourcererSelectors.defaultDataView);
const { pathname } = useLocation();
const { selectedPatterns: nonTimelinePatterns } = useSourcererDataView(
getScopeFromPath(pathname)
);
const { selectedPatterns: timelinePatterns } = useSourcererDataView(SourcererScopeName.timeline);
const selectedPatterns = useMemo(() => {
return isActiveTimelines
? [...new Set([...timelinePatterns, ...defaultDataView.patternList])]
: [...new Set([...nonTimelinePatterns, ...defaultDataView.patternList])];
}, [isActiveTimelines, timelinePatterns, nonTimelinePatterns, defaultDataView.patternList]);
const { selectedPatterns: analyzerPatterns } = useSourcererDataView(SourcererScopeName.analyzer); const { selectedPatterns: analyzerPatterns } = useSourcererDataView(SourcererScopeName.analyzer);
return useMemo(() => { return useMemo(() => {
return { return {
selectedPatterns: isDatePickerAndSourcererDisabled ? selectedPatterns : analyzerPatterns, selectedPatterns: analyzerPatterns,
from, from,
to, to,
shouldUpdate, shouldUpdate,
}; };
}, [ }, [from, to, shouldUpdate, analyzerPatterns]);
selectedPatterns,
from,
to,
shouldUpdate,
isDatePickerAndSourcererDisabled,
analyzerPatterns,
]);
} }