github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

render only once (#90601)

Browse source
This commit is contained in:
Joe Reuter 2021-02-11 17:56:29 +01:00 • committed by GitHub
parent 9da625b31d
commit 40570a633f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
x-pack/plugins/lens/public/editor_frame_service/embeddable/embeddable.test.tsx
View file

@ -104,7 +104,7 @@ describe('embeddable', () => {
mountpoint.remove();
});
it('should render expression with expression renderer', async () => {
it('should render expression once with expression renderer', async () => {
const embeddable = new Embeddable(
{
timefilter: dataPluginMock.createSetupContract().query.timefilter.timefilter,
@ -123,11 +123,18 @@ describe('embeddable', () => {
],
}),
},
{} as LensEmbeddableInput
{
timeRange: {
from: 'now-15m',
to: 'now',
},
} as LensEmbeddableInput
);
await embeddable.initializeSavedVis({} as LensEmbeddableInput);
embeddable.render(mountpoint);
// wait one tick to give embeddable time to initialize
await new Promise((resolve) => setTimeout(resolve, 0));
expect(expressionRenderer).toHaveBeenCalledTimes(1);
expect(expressionRenderer.mock.calls[0][0]!.expression).toEqual(`my
| expression`);

3
x-pack/plugins/lens/public/editor_frame_service/embeddable/embeddable.tsx
View file

@ -229,9 +229,6 @@ export class Embeddable
this.expression = expression ? toExpression(expression) : null;
await this.initializeOutput();
this.isInitialized = true;
if (this.domNode) {
this.render(this.domNode);
}
}
onContainerStateChanged(containerState: LensEmbeddableInput) {