github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.x] [Synthetics] Fixes broken e2e tests !! (#197567) (#197579)

Browse source 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Fixes broken e2e tests !!
(#197567)](https://github.com/elastic/kibana/pull/197567)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-24T09:10:51Z","message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Fixes broken e2e tests
!!","number":197567,"url":"https://github.com/elastic/kibana/pull/197567","mergeCommit":{"message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197567","number":197567,"mergeCommit":{"message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848"}}]}] BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
This commit is contained in:
Kibana Machine 2024-10-24 21:56:59 +11:00 • committed by GitHub
parent 30822bfae7
commit 407d794861
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

21
x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/alert_rules/custom_status_alert.journey.ts
View file

@ -5,8 +5,7 @@
* 2.0.
*/
import { journey, step, before, after, expect } from '@elastic/synthetics';
import { RetryService } from '@kbn/ftr-common-functional-services';
import { journey, step, before, after } from '@elastic/synthetics';
import { syntheticsAppPageProvider } from '../../page_objects/synthetics_app';
import { SyntheticsServices } from '../services/synthetics_services';
@ -14,8 +13,6 @@ journey(`CustomStatusAlert`, async ({ page, params }) => {
const syntheticsApp = syntheticsAppPageProvider({ page, kibanaUrl: params.kibanaUrl, params });
const services = new SyntheticsServices(params);
const getService = params.getService;
const retry: RetryService = getService('retry');
const firstCheckTime = new Date(Date.now()).toISOString();
@ -61,19 +58,7 @@ journey(`CustomStatusAlert`, async ({ page, params }) => {
});
step('verify rule creation', async () => {
await retry.try(async () => {
const rules = await services.getRules();
expect(rules.length).toBe(3);
expect(rules[2].params).toStrictEqual({
condition: {
downThreshold: 3,
locationsThreshold: 1,
groupBy: 'locationId',
window: {
numberOfChecks: 5,
},
},
});
});
await syntheticsApp.goToRulesPage();
await page.waitForSelector(`text='Synthetics status rule'`);
});
});

8
x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/services/synthetics_services.ts
View file

@ -221,14 +221,6 @@ export class SyntheticsServices {
}
}
async getRules() {
const response = await axios.get(this.kibanaUrl + '/internal/alerting/rules/_find', {
auth: { username: 'elastic', password: 'changeme' },
headers: { 'kbn-xsrf': 'true' },
});
return response.data.data;
}
async setupTestConnector() {
const indexConnector = {
name: 'test index',

5
x-pack/plugins/observability_solution/synthetics/e2e/synthetics/page_objects/synthetics_app.tsx
View file

@ -393,5 +393,10 @@ export function syntheticsAppPageProvider({
const isDisabled = await addMonitorBtn.isDisabled();
return !isDisabled;
},
async goToRulesPage() {
const rulesPage = '/app/observability/alerts/rules';
await page.goto(basePath + rulesPage);
},
};
}