github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[i18n] Fix some hardcoded translations on Dashboard & Discover (#105555)

Browse source 
* [i18n] fix objectType in dashboard/save_search save modal

* [i18n] fix objectType in visualize save modal

* add translations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Dzmitry Lemechko 2021-07-14 18:11:35 +02:00 • committed by GitHub
parent bcda0684ea
commit 40e5725d0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/plugins/dashboard/public/application/top_nav/save_modal.tsx
View file

@ -8,6 +8,7 @@
import React, { Fragment } from 'react';
import { FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';
import { EuiFormRow, EuiTextArea, EuiSwitch } from '@elastic/eui';
import type { SavedObjectsTaggingApi } from '../../services/saved_objects_tagging_oss';
@ -148,7 +149,9 @@ export class DashboardSaveModal extends React.Component<Props, State> {
title={this.props.title}
showCopyOnSave={this.props.showCopyOnSave}
initialCopyOnSave={this.props.showCopyOnSave}
objectType="dashboard"
objectType={i18n.translate('dashboard.topNav.saveModal.objectType', {
defaultMessage: 'dashboard',
})}
options={this.renderDashboardSaveOptions()}
showDescription={false}
/>

4
src/plugins/discover/public/application/apps/main/components/top_nav/on_save_search.tsx
View file

@ -135,7 +135,9 @@ export async function onSaveSearch({
onClose={() => {}}
title={savedSearch.title}
showCopyOnSave={!!savedSearch.id}
objectType="search"
objectType={i18n.translate('discover.localMenu.saveSaveSearchObjectType', {
defaultMessage: 'search',
})}
description={i18n.translate('discover.localMenu.saveSaveSearchDescription', {
defaultMessage:
'Save your Discover search so you can use it in visualizations and dashboards',

8
src/plugins/visualize/public/application/utils/get_top_nav_config.tsx
View file

@ -449,7 +449,9 @@ export const getTopNavConfig = (
onSave={onSave}
options={tagOptions}
getAppNameFromId={stateTransfer.getAppNameFromId}
objectType={'visualization'}
objectType={i18n.translate('visualize.topNavMenu.saveVisualizationObjectType', {
defaultMessage: 'visualization',
})}
onClose={() => {}}
originatingApp={originatingApp}
returnToOriginSwitchLabel={
@ -475,7 +477,9 @@ export const getTopNavConfig = (
canSaveByReference={Boolean(visualizeCapabilities.save)}
onSave={onSave}
tagOptions={tagOptions}
objectType={'visualization'}
objectType={i18n.translate('visualize.topNavMenu.saveVisualizationObjectType', {
defaultMessage: 'visualization',
})}
onClose={() => {}}
/>
);

3
x-pack/plugins/translations/translations/ja-JP.json
View file

@ -673,6 +673,7 @@
"dashboard.topNav.options.syncColorsBetweenPanelsSwitchLabel": "パネル全体でカラーパレットを同期",
"dashboard.topNav.options.useMarginsBetweenPanelsSwitchLabel": "パネルの間に余白を使用",
"dashboard.topNav.saveModal.descriptionFormRowLabel": "説明",
"dashboard.topNav.saveModal.objectType": "dashboard",
"dashboard.topNav.saveModal.storeTimeWithDashboardFormRowHelpText": "有効化すると、ダッシュボードが読み込まれるごとに現在選択された時刻の時間フィルターが変更されます。",
"dashboard.topNav.saveModal.storeTimeWithDashboardFormRowLabel": "ダッシュボードに時刻を保存",
"dashboard.topNav.showCloneModal.dashboardCopyTitle": "{title}のコピー",
@ -1698,6 +1699,7 @@
"discover.localMenu.openTitle": "開く",
"discover.localMenu.optionsDescription": "オプション",
"discover.localMenu.saveSaveSearchDescription": "ビジュアライゼーションとダッシュボードで使用できるように Discover の検索を保存します",
"discover.localMenu.saveSaveSearchObjectType": "discover",
"discover.localMenu.saveSearchDescription": "検索を保存します",
"discover.localMenu.saveTitle": "保存",
"discover.localMenu.shareSearchDescription": "検索を共有します",
@ -5138,6 +5140,7 @@
"visualize.topNavMenu.saveVisualizationButtonAriaLabel": "ビジュアライゼーションを保存",
"visualize.topNavMenu.saveVisualizationButtonLabel": "保存",
"visualize.topNavMenu.saveVisualizationDisabledButtonTooltip": "保存する前に変更を適用または破棄",
"visualize.topNavMenu.saveVisualizationObjectType": "visualize",
"visualize.topNavMenu.saveVisualizationToLibraryButtonLabel": "ライブラリに保存",
"visualize.topNavMenu.shareVisualizationButtonAriaLabel": "ビジュアライゼーションを共有",
"visualize.topNavMenu.shareVisualizationButtonLabel": "共有",

3
x-pack/plugins/translations/translations/zh-CN.json
View file

@ -676,6 +676,7 @@
"dashboard.topNav.options.syncColorsBetweenPanelsSwitchLabel": "在面板之间同步调色板",
"dashboard.topNav.options.useMarginsBetweenPanelsSwitchLabel": "在面板间使用边距",
"dashboard.topNav.saveModal.descriptionFormRowLabel": "描述",
"dashboard.topNav.saveModal.objectType": "dashboard",
"dashboard.topNav.saveModal.storeTimeWithDashboardFormRowHelpText": "每次加载此仪表板时，都会将时间筛选更改为当前选定的时间。",
"dashboard.topNav.saveModal.storeTimeWithDashboardFormRowLabel": "将时间随仪表板保存",
"dashboard.topNav.showCloneModal.dashboardCopyTitle": "{title} 副本",
@ -1708,6 +1709,7 @@
"discover.localMenu.openTitle": "打开",
"discover.localMenu.optionsDescription": "选项",
"discover.localMenu.saveSaveSearchDescription": "保存您的 Discover 搜索，以便可以在可视化和仪表板中使用该搜索",
"discover.localMenu.saveSaveSearchObjectType": "discover",
"discover.localMenu.saveSearchDescription": "保存搜索",
"discover.localMenu.saveTitle": "保存",
"discover.localMenu.shareSearchDescription": "共享搜索",
@ -5166,6 +5168,7 @@
"visualize.topNavMenu.saveVisualizationButtonAriaLabel": "保存可视化",
"visualize.topNavMenu.saveVisualizationButtonLabel": "保存",
"visualize.topNavMenu.saveVisualizationDisabledButtonTooltip": "保存前应用或放弃所做更改",
"visualize.topNavMenu.saveVisualizationObjectType": "visualize",
"visualize.topNavMenu.saveVisualizationToLibraryButtonLabel": "保存到库",
"visualize.topNavMenu.shareVisualizationButtonAriaLabel": "共享可视化",
"visualize.topNavMenu.shareVisualizationButtonLabel": "共享",