github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[TSVB] Allow string fields on value count aggregation (#79267)

Browse source 
* [TSVB] Enable string fields for value count aggregation

* fix test title

* Allow all field types for value count aggregation

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Stratoula Kalafateli 2020-10-06 08:55:51 +03:00 • committed by GitHub
parent cf45fef4c5
commit 40ef7205f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.js
View file

@ -25,6 +25,7 @@ export function getSupportedFieldsByMetricType(type) {
case METRIC_TYPES.CARDINALITY:
return Object.values(KBN_FIELD_TYPES).filter((t) => t !== KBN_FIELD_TYPES.HISTOGRAM);
case METRIC_TYPES.VALUE_COUNT:
return Object.values(KBN_FIELD_TYPES);
case METRIC_TYPES.AVERAGE:
case METRIC_TYPES.SUM:
return [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.HISTOGRAM];

7
src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.test.js
View file

@ -18,18 +18,23 @@
*/
import { getSupportedFieldsByMetricType } from './get_supported_fields_by_metric_type';
import { KBN_FIELD_TYPES } from '../../../../../../plugins/data/public';
describe('getSupportedFieldsByMetricType', () => {
const shouldHaveHistogramAndNumbers = (type) =>
it(`should return numbers and histogram for ${type}`, () => {
expect(getSupportedFieldsByMetricType(type)).toEqual(['number', 'histogram']);
});
const shouldSupportAllFieldTypes = (type) =>
it(`should return all field types for ${type}`, () => {
expect(getSupportedFieldsByMetricType(type)).toEqual(Object.values(KBN_FIELD_TYPES));
});
const shouldHaveOnlyNumbers = (type) =>
it(`should return only numbers for ${type}`, () => {
expect(getSupportedFieldsByMetricType(type)).toEqual(['number']);
});
shouldHaveHistogramAndNumbers('value_count');
shouldSupportAllFieldTypes('value_count');
shouldHaveHistogramAndNumbers('avg');
shouldHaveHistogramAndNumbers('sum');