github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ML] Fixing job deletion slow refresh delay (#30371) (#30486)

Browse source
This commit is contained in:
James Gowdy 2019-02-11 10:26:53 +00:00 • committed by GitHub
parent 908ce15a52
commit 4130ddd93b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 25 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
x-pack/plugins/ml/common/constants/jobs_list.js Normal file
View file

@ -0,0 +1,10 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/
export const DEFAULT_REFRESH_INTERVAL_MS = 30000;
export const MINIMUM_REFRESH_INTERVAL_MS = 5000;
export const DELETING_JOBS_REFRESH_INTERVAL_MS = 2000;

7
x-pack/plugins/ml/common/constants/states.js
View file

@ -12,14 +12,14 @@ export const DATAFEED_STATE = {
STARTING: 'starting',
STOPPED: 'stopped',
STOPPING: 'stopping',
DELETED: 'deleted'
DELETED: 'deleted',
};
export const FORECAST_REQUEST_STATE = {
FAILED: 'failed',
FINISHED: 'finished',
SCHEDULED: 'scheduled',
STARTED: 'started'
STARTED: 'started',
};
export const JOB_STATE = {
@ -27,5 +27,6 @@ export const JOB_STATE = {
CLOSING: 'closing',
FAILED: 'failed',
OPENED: 'opened',
OPENING: 'opening'
OPENING: 'opening',
DELETED: 'deleted',
};

5
x-pack/plugins/ml/public/jobs/jobs_list/components/delete_job_modal/delete_job_modal.js
View file

@ -19,6 +19,7 @@ import {
} from '@elastic/eui';
import { deleteJobs } from '../utils';
import { DELETING_JOBS_REFRESH_INTERVAL_MS } from '../../../../../common/constants/jobs_list';
import { injectI18n, FormattedMessage } from '@kbn/i18n/react';
export const DeleteJobModal = injectI18n(class extends Component {
@ -70,9 +71,9 @@ export const DeleteJobModal = injectI18n(class extends Component {
deleteJobs(this.state.jobs);
setTimeout(() => {
this.closeModal();
this.refreshJobs();
}, 500);
this.closeModal();
}, DELETING_JOBS_REFRESH_INTERVAL_MS);
}
setEL = (el) => {

10
x-pack/plugins/ml/public/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js
View file

@ -24,6 +24,12 @@ import { UpgradeWarning } from '../../../../components/upgrade';
import { RefreshJobsListButton } from '../refresh_jobs_list_button';
import { isEqual } from 'lodash';
import {
DEFAULT_REFRESH_INTERVAL_MS,
MINIMUM_REFRESH_INTERVAL_MS,
DELETING_JOBS_REFRESH_INTERVAL_MS,
} from '../../../../../common/constants/jobs_list';
import React, {
Component
} from 'react';
@ -34,9 +40,7 @@ import {
EuiSpacer,
} from '@elastic/eui';
const DEFAULT_REFRESH_INTERVAL_MS = 30000;
const MINIMUM_REFRESH_INTERVAL_MS = 5000;
const DELETING_JOBS_REFRESH_INTERVAL_MS = 2000;
let jobsRefreshInterval = null;
let deletingJobsRefreshTimeout = null;

2
x-pack/plugins/ml/public/jobs/jobs_list/components/utils.js
View file

@ -179,7 +179,7 @@ export function deleteJobs(jobs, finish = () => {}) {
const jobIds = jobs.map(j => j.id);
mlJobService.deleteJobs(jobIds)
.then((resp) => {
showResults(resp, DATAFEED_STATE.DELETED);
showResults(resp, JOB_STATE.DELETED);
finish();
})
.catch((error) => {