[SECURITY SOLUTION] bug styling (#80572)

* remove beta

* fix i18n

* fix cypress tests

* forget to save

* x-pack test
This commit is contained in:
Xavier Mouligneau 2020-10-15 13:24:17 -04:00 committed by GitHub
parent d10d70b2ac
commit 41db7d175c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
19 changed files with 14 additions and 84 deletions

View file

@ -168,7 +168,7 @@ describe('Custom detection rules creation', () => {
goToRuleDetails();
cy.get(RULE_NAME_HEADER).should('have.text', `${newRule.name} Beta`);
cy.get(RULE_NAME_HEADER).should('have.text', `${newRule.name}`);
cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newRule.description);
cy.get(ABOUT_DETAILS).within(() => {
getDetails(SEVERITY_DETAILS).should('have.text', newRule.severity);
@ -328,7 +328,7 @@ describe('Custom detection rules deletion and edition', () => {
fillAboutRule(editedRule);
saveEditedRule();
cy.get(RULE_NAME_HEADER).should('have.text', `${editedRule.name} Beta`);
cy.get(RULE_NAME_HEADER).should('have.text', `${editedRule.name}`);
cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', editedRule.description);
cy.get(ABOUT_DETAILS).within(() => {
getDetails(SEVERITY_DETAILS).should('have.text', editedRule.severity);

View file

@ -131,7 +131,7 @@ describe.skip('Detection rules, EQL', () => {
goToRuleDetails();
cy.get(RULE_NAME_HEADER).should('have.text', `${eqlRule.name} Beta`);
cy.get(RULE_NAME_HEADER).should('have.text', `${eqlRule.name}`);
cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', eqlRule.description);
cy.get(ABOUT_DETAILS).within(() => {
getDetails(SEVERITY_DETAILS).should('have.text', eqlRule.severity);

View file

@ -115,7 +115,7 @@ describe('Detection rules, machine learning', () => {
goToRuleDetails();
cy.get(RULE_NAME_HEADER).should('have.text', `${machineLearningRule.name} Beta`);
cy.get(RULE_NAME_HEADER).should('have.text', `${machineLearningRule.name}`);
cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', machineLearningRule.description);
cy.get(ABOUT_DETAILS).within(() => {
getDetails(SEVERITY_DETAILS).should('have.text', machineLearningRule.severity);

View file

@ -132,7 +132,7 @@ describe('Detection rules, override', () => {
goToRuleDetails();
cy.get(RULE_NAME_HEADER).should('have.text', `${newOverrideRule.name} Beta`);
cy.get(RULE_NAME_HEADER).should('have.text', `${newOverrideRule.name}`);
cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newOverrideRule.description);
cy.get(ABOUT_DETAILS).within(() => {
getDetails(SEVERITY_DETAILS).should('have.text', newOverrideRule.severity);

View file

@ -129,7 +129,7 @@ describe('Detection rules, threshold', () => {
goToRuleDetails();
cy.get(RULE_NAME_HEADER).should('have.text', `${newThresholdRule.name} Beta`);
cy.get(RULE_NAME_HEADER).should('have.text', `${newThresholdRule.name}`);
cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newThresholdRule.description);
cy.get(ABOUT_DETAILS).within(() => {
getDetails(SEVERITY_DETAILS).should('have.text', newThresholdRule.severity);

View file

@ -60,7 +60,7 @@ describe('Cases', () => {
createNewCaseWithTimeline(case1);
backToCases();
cy.get(ALL_CASES_PAGE_TITLE).should('have.text', 'Cases Beta');
cy.get(ALL_CASES_PAGE_TITLE).should('have.text', 'Cases');
cy.get(ALL_CASES_OPEN_CASES_STATS).should('have.text', 'Open cases1');
cy.get(ALL_CASES_CLOSED_CASES_STATS).should('have.text', 'Closed cases0');
cy.get(ALL_CASES_OPEN_CASES_COUNT).should('have.text', 'Open cases (1)');

View file

@ -7,18 +7,9 @@
import React from 'react';
import { HeaderPage, HeaderPageProps } from '../../../common/components/header_page';
import * as i18n from './translations';
const CaseHeaderPageComponent: React.FC<HeaderPageProps> = (props) => (
<HeaderPage hideSourcerer={true} {...props} />
);
CaseHeaderPageComponent.defaultProps = {
badgeOptions: {
beta: true,
text: i18n.PAGE_BADGE_LABEL,
tooltip: i18n.PAGE_BADGE_TOOLTIP,
},
};
export const CaseHeaderPage = React.memo(CaseHeaderPageComponent);

View file

@ -1,22 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/
import { i18n } from '@kbn/i18n';
export const PAGE_BADGE_LABEL = i18n.translate(
'xpack.securitySolution.case.caseView.pageBadgeLabel',
{
defaultMessage: 'Beta',
}
);
export const PAGE_BADGE_TOOLTIP = i18n.translate(
'xpack.securitySolution.case.caseView.pageBadgeTooltip',
{
defaultMessage:
'Case Workflow is still in beta. Please help us improve by reporting issues or bugs in the Kibana repo.',
}
);

View file

@ -56,7 +56,7 @@ export const initSourcererScope = {
errorMessage: null,
indexPattern: EMPTY_INDEX_PATTERN,
indicesExist: true,
loading: true,
loading: false,
selectedPatterns: [],
};

View file

@ -7,20 +7,11 @@
import React from 'react';
import { HeaderPage, HeaderPageProps } from '../../../common/components/header_page';
import * as i18n from './translations';
const DetectionEngineHeaderPageComponent: React.FC<HeaderPageProps> = (props) => (
<HeaderPage hideSourcerer={true} {...props} />
);
DetectionEngineHeaderPageComponent.defaultProps = {
badgeOptions: {
beta: true,
text: i18n.PAGE_BADGE_LABEL,
tooltip: i18n.PAGE_BADGE_TOOLTIP,
},
};
export const DetectionEngineHeaderPage = React.memo(DetectionEngineHeaderPageComponent);
DetectionEngineHeaderPage.displayName = 'DetectionEngineHeaderPage';

View file

@ -1,22 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/
import { i18n } from '@kbn/i18n';
export const PAGE_BADGE_LABEL = i18n.translate(
'xpack.securitySolution.detectionEngine.headerPage.pageBadgeLabel',
{
defaultMessage: 'Beta',
}
);
export const PAGE_BADGE_TOOLTIP = i18n.translate(
'xpack.securitySolution.detectionEngine.headerPage.pageBadgeTooltip',
{
defaultMessage:
'Alerts is still in beta. Please help us improve by reporting issues or bugs in the Kibana repo.',
}
);

View file

@ -561,7 +561,7 @@ export const EndpointList = () => {
return (
<AdministrationListPage
data-test-subj="endpointPage"
beta={true}
beta={false}
title={
<FormattedMessage
id="xpack.securitySolution.endpoint.list.pageTitle"

View file

@ -405,7 +405,7 @@ export const PolicyList = React.memo(() => {
)}
<AdministrationListPage
data-test-subj="policyListPage"
beta={true}
beta={false}
title={
<FormattedMessage
id="xpack.securitySolution.policyList.pageTitle"

View file

@ -67,7 +67,7 @@ export const TrustedAppsPage = memo(() => {
return (
<AdministrationListPage
data-test-subj="trustedAppsListPage"
beta={true}
beta={false}
title={
<FormattedMessage
id="xpack.securitySolution.trustedapps.list.pageTitle"

View file

@ -14822,8 +14822,6 @@
"xpack.securitySolution.case.caseView.noTags": "現在、このケースにタグは割り当てられていません。",
"xpack.securitySolution.case.caseView.openedOn": "開始日",
"xpack.securitySolution.case.caseView.optional": "オプション",
"xpack.securitySolution.case.caseView.pageBadgeLabel": "ベータ",
"xpack.securitySolution.case.caseView.pageBadgeTooltip": "ケースワークフローはまだベータです。Kibana repoで問題や不具合を報告して製品の改善にご協力ください。",
"xpack.securitySolution.case.caseView.particpantsLabel": "参加者",
"xpack.securitySolution.case.caseView.pushNamedIncident": "{ thirdParty }インシデントとしてプッシュ",
"xpack.securitySolution.case.caseView.pushThirdPartyIncident": "外部インシデントとしてプッシュ",
@ -15199,8 +15197,6 @@
"xpack.securitySolution.detectionEngine.emptyActionSecondary": "ドキュメントに移動",
"xpack.securitySolution.detectionEngine.emptyTitle": "セキュリティアプリケーションの検出エンジンに関連したインデックスがないようです",
"xpack.securitySolution.detectionEngine.goToDocumentationButton": "ドキュメンテーションを表示",
"xpack.securitySolution.detectionEngine.headerPage.pageBadgeLabel": "ベータ",
"xpack.securitySolution.detectionEngine.headerPage.pageBadgeTooltip": "アラートはまだベータ段階です。Kibana repoで問題や不具合を報告して製品の改善にご協力ください。",
"xpack.securitySolution.detectionEngine.lastSignalTitle": "前回のアラート",
"xpack.securitySolution.detectionEngine.mitreAttack.addTitle": "MITRE ATT&amp;CK\\u2122脅威を追加",
"xpack.securitySolution.detectionEngine.mitreAttack.tacticPlaceHolderDescription": "Tacticを追加...",

View file

@ -14831,8 +14831,6 @@
"xpack.securitySolution.case.caseView.noTags": "当前没有为此案例分配标记。",
"xpack.securitySolution.case.caseView.openedOn": "打开时间",
"xpack.securitySolution.case.caseView.optional": "可选",
"xpack.securitySolution.case.caseView.pageBadgeLabel": "公测版",
"xpack.securitySolution.case.caseView.pageBadgeTooltip": "案例工作流仍为公测版。请通过在 Kibana 存储库中报告问题或错误,帮助我们改进产品。",
"xpack.securitySolution.case.caseView.particpantsLabel": "参与者",
"xpack.securitySolution.case.caseView.pushNamedIncident": "推送为 { thirdParty } 事件",
"xpack.securitySolution.case.caseView.pushThirdPartyIncident": "推送为外部事件",
@ -15208,8 +15206,6 @@
"xpack.securitySolution.detectionEngine.emptyActionSecondary": "前往文档",
"xpack.securitySolution.detectionEngine.emptyTitle": "似乎在 Security 应用程序中没有与检测引擎相关的索引",
"xpack.securitySolution.detectionEngine.goToDocumentationButton": "查看文档",
"xpack.securitySolution.detectionEngine.headerPage.pageBadgeLabel": "公测版",
"xpack.securitySolution.detectionEngine.headerPage.pageBadgeTooltip": "告警仍为公测版。请通过在 Kibana 存储库中报告问题或错误,帮助我们改进产品。",
"xpack.securitySolution.detectionEngine.lastSignalTitle": "上一告警",
"xpack.securitySolution.detectionEngine.mitreAttack.addTitle": "添加 MITRE ATT&amp;CK\\u2122 威胁",
"xpack.securitySolution.detectionEngine.mitreAttack.tacticPlaceHolderDescription": "选择策略......",

View file

@ -103,7 +103,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
it('finds page title', async () => {
const title = await testSubjects.getVisibleText('header-page-title');
expect(title).to.equal('Endpoints BETA');
expect(title).to.equal('Endpoints');
});
it('displays table data', async () => {

View file

@ -30,7 +30,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
it('displays page title', async () => {
const policyTitle = await testSubjects.getVisibleText('header-page-title');
expect(policyTitle).to.equal('Policies BETA');
expect(policyTitle).to.equal('Policies');
});
it('shows header create policy button', async () => {
const createButtonTitle = await testSubjects.getVisibleText('headerCreateNewPolicyButton');

View file

@ -20,7 +20,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
it('should show page title', async () => {
expect(await testSubjects.getVisibleText('header-page-title')).to.equal(
'Trusted Applications BETA'
'Trusted Applications'
);
});