github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.7] [Discover] Address flaky filters modal in alerting tests (#152548) (#152660)

Browse source 
# Backport

This will backport the following commits from `main` to `8.7`:
- [[Discover] Address flaky filters modal in alerting tests
(#152548)](https://github.com/elastic/kibana/pull/152548)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-03-06T08:11:49Z","message":"[Discover]
Address flaky filters modal in alerting tests (#152548)\n\nCloses
https://github.com/elastic/kibana/issues/152477\r\nCloses
https://github.com/elastic/kibana/issues/152478\r\nCloses
https://github.com/elastic/kibana/issues/152479\r\n\r\n150x (alert
tests)\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1978\r\n100x
(context
tests)\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1979","sha":"d8f9b1dc032a24c2db6187f16f4542649ee642b4","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.8.0"],"number":152548,"url":"https://github.com/elastic/kibana/pull/152548","mergeCommit":{"message":"[Discover]
Address flaky filters modal in alerting tests (#152548)\n\nCloses
https://github.com/elastic/kibana/issues/152477\r\nCloses
https://github.com/elastic/kibana/issues/152478\r\nCloses
https://github.com/elastic/kibana/issues/152479\r\n\r\n150x (alert
tests)\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1978\r\n100x
(context
tests)\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1979","sha":"d8f9b1dc032a24c2db6187f16f4542649ee642b4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152548","number":152548,"mergeCommit":{"message":"[Discover]
Address flaky filters modal in alerting tests (#152548)\n\nCloses
https://github.com/elastic/kibana/issues/152477\r\nCloses
https://github.com/elastic/kibana/issues/152478\r\nCloses
https://github.com/elastic/kibana/issues/152479\r\n\r\n150x (alert
tests)\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1978\r\n100x
(context
tests)\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1979","sha":"d8f9b1dc032a24c2db6187f16f4542649ee642b4"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
This commit is contained in:
Kibana Machine 2023-03-06 04:06:07 -05:00 • committed by GitHub
parent 729dcc026f
commit 4240e88a24
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/functional/apps/context/_discover_navigation.ts
View file

@ -48,6 +48,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
for (const [columnName, value] of TEST_FILTER_COLUMN_NAMES) {
await filterBar.addFilter({ field: columnName, operation: 'is', value });
await PageObjects.header.waitUntilLoadingHasFinished();
}
});
@ -82,7 +83,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await retry.waitFor('next anchor timestamp matches previous anchor timestamp', async () => {
// get the timestamp of the first row
const firstContextTimestamp = await getTimestamp(false);
await dataGrid.clickRowToggle({ isAnchorRow: true });
await dataGrid.clickRowToggle({ rowIndex: 0 });
const rowActions = await dataGrid.getRowActions({ rowIndex: 0 });
await rowActions[1].click();

1
test/functional/services/filter_bar.ts
View file

@ -304,6 +304,7 @@ export class FilterBarService extends FtrService {
await this.testSubjects.clickWhenNotDisabled('saveFilter');
});
await this.testSubjects.waitForDeleted('saveFilter');
await this.header.awaitGlobalLoadingIndicatorHidden();
}