Fix IE specific flexbox min-height issue (#66555)

* Fix IE specific flexbox min-height issue

* Use internetExplorerOnly mixin

* Fix other issues in IE

* Add a comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Daniil Suleiman 2020-05-19 09:50:31 +03:00 committed by GitHub
parent 0d71ed2ba2
commit 428fd06491
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 3 deletions

View file

@ -75,6 +75,12 @@
margin: 0 auto;
min-height: calc(100vh - #{$euiHeaderHeightCompensation});
@include internetExplorerOnly {
// IE specific bug with min-height in flex container, described in the next link
// https://github.com/philipwalton/flexbugs#3-min-height-on-a-flex-container-wont-apply-to-its-flex-items
height: calc(100vh - #{$euiHeaderHeightCompensation});
}
&.hidden-chrome {
min-height: 100vh;
}

View file

@ -70,8 +70,7 @@
.visEditor__visualization {
display: flex;
flex-basis: 100%;
flex: 1;
flex: 1 1 auto; // Fixes IE bug: the editor overflows a visualization on small screens
overflow: hidden;
@include euiBreakpoint('xs', 's', 'm') {

View file

@ -4,6 +4,11 @@
.visEditorSidebar {
min-width: $vis-editor-sidebar-min-width;
// a hack for IE, issue: https://github.com/elastic/kibana/issues/66586
> .visEditorSidebar__formWrapper {
flex-basis: auto;
}
}
.visEditorSidebar__form {

View file

@ -177,7 +177,7 @@ function DefaultEditorSideBar({
gutterSize="none"
responsive={false}
>
<EuiFlexItem>
<EuiFlexItem className="visEditorSidebar__formWrapper">
<form
className="visEditorSidebar__form"
name="visualizeEditor"